)]}'
{"ceilometer/pipeline.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3755d186e6ea198d1654aa10542d8f50a34d5c3d","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                lambda c: c.name):"},{"line_number":233,"context_line":"            if self.support_counter(counter_name):"},{"line_number":234,"context_line":"                self._publish_counters(0, ctxt, counters, source)"},{"line_number":235,"context_line":"        self.flush(ctxt, source)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    # (yjiang5) To support counters like instance:m1.tiny,"},{"line_number":238,"context_line":"    # which include variable part at the end starting with \u0027:\u0027."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FA%2BI%3D","line":235,"updated":"2013-02-11 16:38:07.000000000","message":"It seems like it would be better to flush at the end of the loop in the manager where publish_counters() is called, outside of the pipeline itself. That way we only flush once per periodic task.","commit_id":"b13f2193709854f2b18df7c47835e29656d4fc5f"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d884927d90fa6bb53cebe933c1cf10671b8bd0f5","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                lambda c: c.name):"},{"line_number":233,"context_line":"            if self.support_counter(counter_name):"},{"line_number":234,"context_line":"                self._publish_counters(0, ctxt, counters, source)"},{"line_number":235,"context_line":"        self.flush(ctxt, source)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    # (yjiang5) To support counters like instance:m1.tiny,"},{"line_number":238,"context_line":"    # which include variable part at the end starting with \u0027:\u0027."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B%2FXk%3D","line":235,"in_reply_to":"AAAAM3%2F%2FA%2BI%3D","updated":"2013-02-12 10:20:00.000000000","message":"I\u0027ve built a new version with a context manager.","commit_id":"b13f2193709854f2b18df7c47835e29656d4fc5f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ff95b2b4abae2a831050bb744bfed49b89eab4ff","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        LOG.audit(\"Pipeline %s: Published counters\", self)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def publisher(self, context, source):"},{"line_number":245,"context_line":"        \"\"\"Build a new Publisher for this pipeline."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        :param context: The context."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B%2FBs%3D","line":244,"updated":"2013-02-12 14:38:31.000000000","message":"This method seems superfluous. Why not have the caller instantiated the context manager directly?","commit_id":"44e262d98d70433aa193369eaf7cfbafd687085d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"2b6963a8a68aca2619acf9a03dbaaaecf758e53b","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        LOG.audit(\"Pipeline %s: Published counters\", self)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def publisher(self, context, source):"},{"line_number":245,"context_line":"        \"\"\"Build a new Publisher for this pipeline."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        :param context: The context."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B%2B4w%3D","line":244,"in_reply_to":"AAAAM3%2F%2B%2FBs%3D","updated":"2013-02-12 15:45:12.000000000","message":"While not necessary, I though it was simpler to hide it in the pipeline to simplify the API. Don\u0027t you think?","commit_id":"44e262d98d70433aa193369eaf7cfbafd687085d"}]}