)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"afedd4b37521a606a90b37c813d183c61b90d07d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"A different fix has been done on master for the same"},{"line_number":27,"context_line":"problem and that cannot be cherry-picked to stable/kilo"},{"line_number":28,"context_line":"for the above reason."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I331e087d1385046465d8faed5d0d3c62b31d9b3f"},{"line_number":31,"context_line":"Closes-Bug: 1488707"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_900ee18a","line":28,"updated":"2015-09-10 14:03:14.000000000","message":"could you add original Change-Id? just add a line:\n\n  \u0027see: \u003coriginal-change-id\u003e\u0027","commit_id":"ddc5bd03cb3c19f6e225e74617ab8405809475d5"}],"ceilometer/identity/notifications.py":[{"author":{"_account_id":11580,"name":"Ashwin Agate","email":"agateaaa@gmail.com","username":"agateaaa"},"change_message_id":"bc53a07b50c8dfda91b6016624de8b205e2b25ac","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def event_types(self):"},{"line_number":102,"context_line":"        return [\u0027%s\\..*\u0027 % self.resource_name]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"class Trust(IdentityCRUD):"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    resource_type \u003d \u0027OS-TRUST:trust\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_bb100150","line":104,"updated":"2015-08-26 23:02:22.000000000","message":"I think you can derive this from _Base instead of IdentityCRUD to conform to rest of the classes in this file which override process_notification method","commit_id":"05b4caf8e379a594ecd88a496699b446af150272"}],"ceilometer/tests/identity/test_notifications.py":[{"author":{"_account_id":11580,"name":"Ashwin Agate","email":"agateaaa@gmail.com","username":"agateaaa"},"change_message_id":"2bee5603ae74c202eafca8b3e9ed8bada8b26e15","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                                   notifications.Role)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def test_create_trust(self):"},{"line_number":241,"context_line":"        self._test_operation(\u0027OS-TRUST:trust\u0027, \u0027created\u0027, TRUST_ID,"},{"line_number":242,"context_line":"                             notifications.Trust, \u0027trust\u0027)"},{"line_number":243,"context_line":"        self._test_audit_operation(\u0027OS-TRUST:trust\u0027, \u0027created\u0027, TRUST_ID,"},{"line_number":244,"context_line":"                                   notifications.Trust, \u0027trust\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_fbb8b9e7","line":241,"updated":"2015-08-26 23:15:54.000000000","message":"Also these tests seem to be not doing anything special, just regurgitating values we provide. I would say not to make any additions (like adding converted_resource_type to all other methods) just my opinion","commit_id":"05b4caf8e379a594ecd88a496699b446af150272"},{"author":{"_account_id":11580,"name":"Ashwin Agate","email":"agateaaa@gmail.com","username":"agateaaa"},"change_message_id":"ff5fc21931f8949d9f0d49c479819d2298c5cf90","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                                   notifications.Role)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def test_create_trust(self):"},{"line_number":241,"context_line":"        self._test_operation(\u0027OS-TRUST:trust\u0027, \u0027created\u0027, TRUST_ID,"},{"line_number":242,"context_line":"                             notifications.Trust, \u0027trust\u0027)"},{"line_number":243,"context_line":"        self._test_audit_operation(\u0027OS-TRUST:trust\u0027, \u0027created\u0027, TRUST_ID,"},{"line_number":244,"context_line":"                                   notifications.Trust, \u0027trust\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_212600bb","line":241,"in_reply_to":"da20952f_3663a8b3","updated":"2015-08-27 00:03:39.000000000","message":"ah i see I see it now thanks!...may be easier way would have been to have method like _test_operation(service_event_name, expected_meter_name, ..,) and service_event_name gets set to \u0027identity.OS-TRUST:trust.create and expected_event_type gets set to \u0027identity.trust.created\u0027. But that would mean refactoring all other methods. String concats and substitutions with resource_type, etc makes it more hard to follow","commit_id":"05b4caf8e379a594ecd88a496699b446af150272"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"49c2ec31d86f8561dd607d17184d7327c3e5cd27","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                                   notifications.Role)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def test_create_trust(self):"},{"line_number":241,"context_line":"        self._test_operation(\u0027OS-TRUST:trust\u0027, \u0027created\u0027, TRUST_ID,"},{"line_number":242,"context_line":"                             notifications.Trust, \u0027trust\u0027)"},{"line_number":243,"context_line":"        self._test_audit_operation(\u0027OS-TRUST:trust\u0027, \u0027created\u0027, TRUST_ID,"},{"line_number":244,"context_line":"                                   notifications.Trust, \u0027trust\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_3663a8b3","line":241,"in_reply_to":"da20952f_5baa051b","updated":"2015-08-26 23:41:02.000000000","message":"Ashwin: I dont think so, its the transporter in plugin_base:agent:NotificationBase() that gets mocked (Line 158). Real code in Trust:process_notification is called(Line 159) and the output sample is tested.","commit_id":"05b4caf8e379a594ecd88a496699b446af150272"},{"author":{"_account_id":11580,"name":"Ashwin Agate","email":"agateaaa@gmail.com","username":"agateaaa"},"change_message_id":"def931292798b02c718bac531f53915f28b33d73","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                                   notifications.Role)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def test_create_trust(self):"},{"line_number":241,"context_line":"        self._test_operation(\u0027OS-TRUST:trust\u0027, \u0027created\u0027, TRUST_ID,"},{"line_number":242,"context_line":"                             notifications.Trust, \u0027trust\u0027)"},{"line_number":243,"context_line":"        self._test_audit_operation(\u0027OS-TRUST:trust\u0027, \u0027created\u0027, TRUST_ID,"},{"line_number":244,"context_line":"                                   notifications.Trust, \u0027trust\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_5baa051b","line":241,"in_reply_to":"da20952f_9b3f3d25","updated":"2015-08-26 23:31:10.000000000","message":"Yes but sample is also mocked up too, not that it exercise real code. GIGO ;-)","commit_id":"05b4caf8e379a594ecd88a496699b446af150272"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"c1acf45e5aa757686ef8afd0f961a1ffc29f85dc","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                                   notifications.Role)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def test_create_trust(self):"},{"line_number":241,"context_line":"        self._test_operation(\u0027OS-TRUST:trust\u0027, \u0027created\u0027, TRUST_ID,"},{"line_number":242,"context_line":"                             notifications.Trust, \u0027trust\u0027)"},{"line_number":243,"context_line":"        self._test_audit_operation(\u0027OS-TRUST:trust\u0027, \u0027created\u0027, TRUST_ID,"},{"line_number":244,"context_line":"                                   notifications.Trust, \u0027trust\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_9b3f3d25","line":241,"in_reply_to":"da20952f_fbb8b9e7","updated":"2015-08-26 23:22:32.000000000","message":"@Ashwin: I think the tests test fields of the generated sample. Line 34 is where the input notification is defined, so in this case, it should be OS-TRUST:trust, the tests were passing earlier because this should have been changed with the earlier fix, but if we dont add the converted_resource_type to the trust tests, the tests will fail now.","commit_id":"05b4caf8e379a594ecd88a496699b446af150272"}]}