)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"cd9e0843b05f8a2021846d92839e35e8a2d1c5c0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"and Bug#1353039 due to large data types of those columns."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Even if unique index gets added later, indexing resource"},{"line_number":19,"context_line":"table columns should boost performance of both inserts and"},{"line_number":20,"context_line":"queries."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I2a99bdac88f5fa14ac5f82497d1a12196419ae68"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_122af47e","line":19,"updated":"2015-08-27 21:54:37.000000000","message":"why would indexing boost insert performance? more indexes typically means worse insert performance.","commit_id":"7c70668b97b3ff565e514365096ccf5b11c261ad"},{"author":{"_account_id":11580,"name":"Ashwin Agate","email":"agateaaa@gmail.com","username":"agateaaa"},"change_message_id":"f63d70053ab875200be898aba93c4a5e96851c33","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Even if unique index gets added later, indexing resource"},{"line_number":19,"context_line":"table columns should boost performance of both inserts and"},{"line_number":20,"context_line":"queries."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I2a99bdac88f5fa14ac5f82497d1a12196419ae68"},{"line_number":23,"context_line":"Closes-Bug: #1488544"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_5865b91b","line":20,"updated":"2015-08-28 18:58:11.000000000","message":"Yes I agree, I should have probably said reduces lookup time for a resource during insert","commit_id":"7c70668b97b3ff565e514365096ccf5b11c261ad"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"44bfc6e312549ea2afbf349db0f46f9d4cf252da","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Even if unique index gets added later, indexing resource"},{"line_number":19,"context_line":"table columns should boost performance of both inserts and"},{"line_number":20,"context_line":"queries."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I2a99bdac88f5fa14ac5f82497d1a12196419ae68"},{"line_number":23,"context_line":"Closes-Bug: #1488544"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_f28b89c1","line":20,"in_reply_to":"da20952f_5865b91b","updated":"2015-08-28 20:08:38.000000000","message":"ah, got it. makes sense.","commit_id":"7c70668b97b3ff565e514365096ccf5b11c261ad"}],"ceilometer/storage/sqlalchemy/migrate_repo/versions/045_add_resource_indexes.py":[{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"0e60e2802e5ee7858850d9d6179c11434cbde8f0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import sqlalchemy as sa"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# (HP) Add indexes on all resource table columns"},{"line_number":17,"context_line":"def upgrade(migrate_engine):"},{"line_number":18,"context_line":"    meta \u003d sa.MetaData(bind\u003dmigrate_engine)"},{"line_number":19,"context_line":"    resource \u003d sa.Table(\u0027resource\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_4926b6bb","line":16,"updated":"2015-08-27 02:33:18.000000000","message":"Prefix HP is probably not needed here","commit_id":"6ba549a646edc2abb215df6a92adfb9bc0d9d674"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"0e60e2802e5ee7858850d9d6179c11434cbde8f0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    index \u003d sa.Index(\u0027ix_resource_source_id\u0027, resource.c.source_id)"},{"line_number":38,"context_line":"    index.drop(bind\u003dmigrate_engine)"},{"line_number":39,"context_line":"    index \u003d sa.Index(\u0027ix_resource_metadata_hash\u0027, resource.c.metadata_hash)"},{"line_number":40,"context_line":"    index.drop(bind\u003dmigrate_engine)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_8606fd1e","line":40,"updated":"2015-08-27 02:33:18.000000000","message":"SQL schema downgrades are not supported on master. Refer: https://review.openstack.org/211379","commit_id":"6ba549a646edc2abb215df6a92adfb9bc0d9d674"}]}
