)]}'
{"ceilometer/tests/unit/test_event_pipeline.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"c1928d7edb9a8f103f2c8e30f0dfdfeb9931a947","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        event_pipeline_endpoint \u003d pipeline.EventPipelineEndpoint("},{"line_number":409,"context_line":"            mock.Mock(), pipeline_manager.pipelines[0])"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        fake_publisher.publish_events.side_effect \u003d Exception"},{"line_number":412,"context_line":"        ret \u003d event_pipeline_endpoint.sample(None, \u0027compute.vagrant-precise\u0027,"},{"line_number":413,"context_line":"                                             \u0027a\u0027, [test_data], None)"},{"line_number":414,"context_line":"        self.assertEqual(oslo_messaging.NotificationResult.REQUEUE, ret)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_d3d950f4","line":411,"updated":"2015-09-01 01:46:39.000000000","message":"maybe it is better to tests the \"ack_on_event_error\" with True situation, you can test it with mocked LOG and test the log messaging. see: https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/notify/dispatcher.py#L96","commit_id":"73441c7e42abfbc2e6671d386a181c52cd13cec4"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"db21b9d54ac7859142f6ab84d037a34db0ba62a2","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        event_pipeline_endpoint \u003d pipeline.EventPipelineEndpoint("},{"line_number":409,"context_line":"            mock.Mock(), pipeline_manager.pipelines[0])"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        fake_publisher.publish_events.side_effect \u003d Exception"},{"line_number":412,"context_line":"        ret \u003d event_pipeline_endpoint.sample(None, \u0027compute.vagrant-precise\u0027,"},{"line_number":413,"context_line":"                                             \u0027a\u0027, [test_data], None)"},{"line_number":414,"context_line":"        self.assertEqual(oslo_messaging.NotificationResult.REQUEUE, ret)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_0711be5c","line":411,"in_reply_to":"da20952f_d3d950f4","updated":"2015-09-01 04:16:11.000000000","message":"Yeah, testing the log message (at https://github.com/openstack/ceilometer/blob/master/ceilometer/pipeline.py#L423) can be done even with ack_on_event_error as False. It already being done by https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/unit/event/test_endpoint.py#L170, so in this case, it will just be a repetition of that test case..","commit_id":"73441c7e42abfbc2e6671d386a181c52cd13cec4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ade3bd31c1b5d412889c8056811481841226c9b0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from ceilometer.publisher import test as test_publisher"},{"line_number":29,"context_line":"from ceilometer.publisher import utils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"cfg.CONF.import_opt(\u0027ack_on_event_error\u0027, \u0027ceilometer.notification\u0027,"},{"line_number":32,"context_line":"                    group\u003d\u0027notification\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_93572126","line":31,"updated":"2015-09-01 22:12:11.000000000","message":"just curious but why do we need this?","commit_id":"8828b258e14439cec1769df9cc8912f8c7ced98c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ade3bd31c1b5d412889c8056811481841226c9b0","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            \u0027message_id\u0027: uuid.uuid4(),"},{"line_number":386,"context_line":"            \u0027event_type\u0027: \u0027a\u0027,"},{"line_number":387,"context_line":"            \u0027generated\u0027: \u00272013-08-08 21:06:37.803826\u0027,"},{"line_number":388,"context_line":"            \u0027timestamp\u0027: \u00272013-08-08 21:06:37.803826\u0027,"},{"line_number":389,"context_line":"            \u0027traits\u0027: ["},{"line_number":390,"context_line":"                {\u0027name\u0027: \u0027t_text\u0027,"},{"line_number":391,"context_line":"                 \u0027value\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_5362e917","line":388,"updated":"2015-09-01 22:12:11.000000000","message":"(nit) timestamp isn\u0027t a real attribute in Event","commit_id":"8828b258e14439cec1769df9cc8912f8c7ced98c"}]}