)]}'
{"ceilometer/event/endpoint.py":[{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"e9c87c2a33de6455c7e13622dd8b154a10805693","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if not cfg.CONF.event.record_sample_only_events:"},{"line_number":46,"context_line":"            self.filter_rule \u003d oslo_messaging.NotificationFilter("},{"line_number":47,"context_line":"                event_type\u003d\u0027^(?!telemetry.api$).+$\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def info(self, ctxt, publisher_id, event_type, payload, metadata):"},{"line_number":50,"context_line":"        \"\"\"Convert message to Ceilometer Event."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_100b3e25","line":48,"updated":"2015-09-01 01:00:11.000000000","message":"When  https://review.openstack.org/#/c/213851/ merges, this also needs to exclude telemetry.polling","commit_id":"139c894f945eadeb4a86ae919dfc6f1e24215da7"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"b96f2f497967b075e9e0c96e0cfb5c8cb54b2277","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if not cfg.CONF.event.record_sample_only_events:"},{"line_number":46,"context_line":"            self.filter_rule \u003d oslo_messaging.NotificationFilter("},{"line_number":47,"context_line":"                event_type\u003d\u0027^(?!telemetry.api$).+$\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def info(self, ctxt, publisher_id, event_type, payload, metadata):"},{"line_number":50,"context_line":"        \"\"\"Convert message to Ceilometer Event."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_f0332a60","line":48,"in_reply_to":"da20952f_100b3e25","updated":"2015-09-01 01:06:41.000000000","message":"thanks for reminding me ;)","commit_id":"139c894f945eadeb4a86ae919dfc6f1e24215da7"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"47b134dc170f60031cf5199caf0c2cdd80d45cb5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.manager \u003d manager"},{"line_number":45,"context_line":"        if not cfg.CONF.event.record_sample_only_events:"},{"line_number":46,"context_line":"            excluded_event_types \u003d [\u0027telemetry.api\u0027, \u0027telemetry.polling\u0027]"},{"line_number":47,"context_line":"            excluded \u003d \u0027^(?!(%s)$).+$\u0027 % \u0027|\u0027.join(excluded_event_types)"},{"line_number":48,"context_line":"            self.filter_rule \u003d oslo_messaging.NotificationFilter("},{"line_number":49,"context_line":"                event_type\u003dexcluded)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_53df8e0c","line":47,"updated":"2015-09-07 02:51:56.000000000","message":"the *excluded* is a regular expression to exclude \u0027telemetry.api\u0027 and \u0027telemetry.polling\u0027 type events.","commit_id":"2a0dd8515f2e5a25efbfd265730c89dc0d8eaaf0"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"f0658356ab48149e1481e2ae2d1793ad99ab7233","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from ceilometer import messaging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"OPT \u003d cfg.BoolOpt(\u0027record_sample_only_events\u0027,"},{"line_number":28,"context_line":"                  default\u003dFalse,"},{"line_number":29,"context_line":"                  help\u003d\u0027A switcher to enable/disable recording events from\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_c3f7f157","line":26,"updated":"2015-09-09 07:54:02.000000000","message":"Sorry, but the name is not informative at all:(\n\"Sample\" are generated always: notification, polling or API posting. So it\u0027s not clear what \u0027sample_only\u0027 means.\nI may suggest the name \"record_non_notification_events\"","commit_id":"ec1d0b14cdcb1f778fe56b23d61b138f3f349888"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e48d23ff7ec395a82ea1eb26362eb1d72e6225f8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from ceilometer import messaging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"OPT \u003d cfg.BoolOpt(\u0027record_sample_only_events\u0027,"},{"line_number":28,"context_line":"                  default\u003dFalse,"},{"line_number":29,"context_line":"                  help\u003d\u0027A switcher to enable/disable recording events from\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_a6a8cadc","line":26,"in_reply_to":"da20952f_c3f7f157","updated":"2015-09-09 08:30:32.000000000","message":"yeah, thanks for suggestion, this sounds more clearly!","commit_id":"ec1d0b14cdcb1f778fe56b23d61b138f3f349888"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"f0658356ab48149e1481e2ae2d1793ad99ab7233","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"OPT \u003d cfg.BoolOpt(\u0027record_sample_only_events\u0027,"},{"line_number":28,"context_line":"                  default\u003dFalse,"},{"line_number":29,"context_line":"                  help\u003d\u0027A switcher to enable/disable recording events from\u0027"},{"line_number":30,"context_line":"                       \u0027 ceilometer-polling notifications or API posting\u0027"},{"line_number":31,"context_line":"                       \u0027 sample requests.\u0027)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_035ac950","line":29,"updated":"2015-09-09 07:54:02.000000000","message":"I would remove \u0027notifications\u0027 after \u0027ceilometer-polling\u0027. I understand what you mean here, but I\u0027m afraid it may be confusing because \u0027polling\u0027 and \u0027notifications\u0027 usually mean two different ways of getting measures.","commit_id":"ec1d0b14cdcb1f778fe56b23d61b138f3f349888"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e48d23ff7ec395a82ea1eb26362eb1d72e6225f8","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"OPT \u003d cfg.BoolOpt(\u0027record_sample_only_events\u0027,"},{"line_number":28,"context_line":"                  default\u003dFalse,"},{"line_number":29,"context_line":"                  help\u003d\u0027A switcher to enable/disable recording events from\u0027"},{"line_number":30,"context_line":"                       \u0027 ceilometer-polling notifications or API posting\u0027"},{"line_number":31,"context_line":"                       \u0027 sample requests.\u0027)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_c6805e4c","line":29,"in_reply_to":"da20952f_035ac950","updated":"2015-09-09 08:30:32.000000000","message":"Done","commit_id":"ec1d0b14cdcb1f778fe56b23d61b138f3f349888"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c9460ffc3c319162f461d883865f993135827b12","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"OPT \u003d cfg.BoolOpt(\u0027record_non_notification_events\u0027,"},{"line_number":28,"context_line":"                  default\u003dFalse,"},{"line_number":29,"context_line":"                  help\u003d\u0027A switcher to enable/disable recording events from\u0027"},{"line_number":30,"context_line":"                       \u0027 ceilometer-polling and API posting sample requests.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_9c7840fa","line":27,"updated":"2015-09-10 12:14:42.000000000","message":"non-notification sounds strange.... maybe enable_ipc_events or enable_sample_events?","commit_id":"18f38be44fdcb75528a510a9a02497d1222da732"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"c9d30a6178d3aa5ec0220f1fce07d89e044ef39d","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"OPT \u003d cfg.BoolOpt(\u0027record_non_notification_events\u0027,"},{"line_number":28,"context_line":"                  default\u003dFalse,"},{"line_number":29,"context_line":"                  help\u003d\u0027A switcher to enable/disable recording events from\u0027"},{"line_number":30,"context_line":"                       \u0027 ceilometer-polling and API posting sample requests.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_ce6115d5","line":27,"in_reply_to":"da20952f_9c7840fa","updated":"2015-09-10 14:47:36.000000000","message":"done, the enable_sample_events is a bit like previous record_sample_only_events :)","commit_id":"18f38be44fdcb75528a510a9a02497d1222da732"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"201d6fca8b66bf7138035e6ba418c9a19c4a86f4","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"OPT \u003d cfg.BoolOpt(\u0027record_non_notification_events\u0027,"},{"line_number":28,"context_line":"                  default\u003dFalse,"},{"line_number":29,"context_line":"                  help\u003d\u0027A switcher to enable/disable recording events from\u0027"},{"line_number":30,"context_line":"                       \u0027 ceilometer-polling and API posting sample requests.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_e0ede6f0","line":27,"in_reply_to":"da20952f_ce6115d5","updated":"2015-09-11 09:37:14.000000000","message":":) looks like we need voting","commit_id":"18f38be44fdcb75528a510a9a02497d1222da732"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c9460ffc3c319162f461d883865f993135827b12","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"OPT \u003d cfg.BoolOpt(\u0027record_non_notification_events\u0027,"},{"line_number":28,"context_line":"                  default\u003dFalse,"},{"line_number":29,"context_line":"                  help\u003d\u0027A switcher to enable/disable recording events from\u0027"},{"line_number":30,"context_line":"                       \u0027 ceilometer-polling and API posting sample requests.\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"cfg.CONF.register_opt(OPT, group\u003d\u0027event\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_fcdffcd3","line":29,"updated":"2015-09-10 12:14:42.000000000","message":"Build events from IPC messages from ceilometer-polling...","commit_id":"18f38be44fdcb75528a510a9a02497d1222da732"}],"ceilometer/tests/functional/test_notification.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"133c13e88d0b6be0252ca97fe968e2f223c9ecd0","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                      TEST_NOTICE_PAYLOAD)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        eventlet.sleep(10)"},{"line_number":395,"context_line":"        self.assertEqual(3, mocked.call_count)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"class TestRealNotificationHA(BaseRealNotification):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_d3563e5b","line":395,"updated":"2015-09-07 03:03:18.000000000","message":"is it really OK not stop the service?","commit_id":"2a0dd8515f2e5a25efbfd265730c89dc0d8eaaf0"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"ac1a740445fe21c1a1a0d7f8957a5980e2b6d897","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                      TEST_NOTICE_PAYLOAD)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        eventlet.sleep(10)"},{"line_number":395,"context_line":"        self.assertEqual(3, mocked.call_count)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"class TestRealNotificationHA(BaseRealNotification):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_f409e831","line":395,"in_reply_to":"da20952f_d3563e5b","updated":"2015-09-07 06:29:10.000000000","message":"thanks for reminding me, I think the service should be stopped, but there other tests (e.g. test_notification_pipeline_poller) also didn\u0027t stop service, not sure about the affect.","commit_id":"2a0dd8515f2e5a25efbfd265730c89dc0d8eaaf0"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"5e0b2b8f5c75e214685e596e4e18f83ff5c7e115","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.assertEqual(2, len(self.srv.listeners[0].dispatcher.endpoints))"},{"line_number":157,"context_line":"        self.assertEqual(self.fake_event_endpoint,"},{"line_number":158,"context_line":"                         self.srv.listeners[0].dispatcher.endpoints[0])"},{"line_number":159,"context_line":"        self.srv.stop()"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @mock.patch(\u0027ceilometer.pipeline.setup_pipeline\u0027, mock.MagicMock())"},{"line_number":162,"context_line":"    @mock.patch.object(oslo_messaging.MessageHandlingServer, \u0027start\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_dead90eb","line":159,"updated":"2015-09-09 02:07:10.000000000","message":"although these are not related changes, but I think they are acceptable","commit_id":"ec1d0b14cdcb1f778fe56b23d61b138f3f349888"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"5e0b2b8f5c75e214685e596e4e18f83ff5c7e115","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        notifier.info(context.RequestContext(), \u0027telemetry.ap\u0027,"},{"line_number":399,"context_line":"                      TEST_NOTICE_PAYLOAD)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        eventlet.sleep(10)"},{"line_number":402,"context_line":"        self.assertEqual(3, mocked.call_count)"},{"line_number":403,"context_line":"        self.srv.stop()"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_7e856457","line":401,"updated":"2015-09-09 02:07:10.000000000","message":"I don\u0027t like such way of sleep, but I cannot figure out a better way","commit_id":"ec1d0b14cdcb1f778fe56b23d61b138f3f349888"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e48d23ff7ec395a82ea1eb26362eb1d72e6225f8","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        notifier.info(context.RequestContext(), \u0027telemetry.ap\u0027,"},{"line_number":399,"context_line":"                      TEST_NOTICE_PAYLOAD)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        eventlet.sleep(10)"},{"line_number":402,"context_line":"        self.assertEqual(3, mocked.call_count)"},{"line_number":403,"context_line":"        self.srv.stop()"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_46dc4e74","line":401,"in_reply_to":"da20952f_7e856457","updated":"2015-09-09 08:30:32.000000000","message":"yeah, agree, I don\u0027t like this, but ... ;-)","commit_id":"ec1d0b14cdcb1f778fe56b23d61b138f3f349888"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c9460ffc3c319162f461d883865f993135827b12","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        pipeline_poller_call \u003d mock.call(1, self.srv.refresh_pipeline)"},{"line_number":279,"context_line":"        self.assertIn(pipeline_poller_call,"},{"line_number":280,"context_line":"                      self.srv.tg.add_timer.call_args_list)"},{"line_number":281,"context_line":"        self.srv.stop()"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    @mock.patch(\u0027ceilometer.publisher.test.TestPublisher\u0027)"},{"line_number":284,"context_line":"    def test_notification_reloaded_pipeline(self, fake_publisher_cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_dc48f8ce","line":281,"updated":"2015-09-10 12:14:42.000000000","message":"you should put this in def tearDown(self):","commit_id":"18f38be44fdcb75528a510a9a02497d1222da732"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"c9d30a6178d3aa5ec0220f1fce07d89e044ef39d","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        pipeline_poller_call \u003d mock.call(1, self.srv.refresh_pipeline)"},{"line_number":279,"context_line":"        self.assertIn(pipeline_poller_call,"},{"line_number":280,"context_line":"                      self.srv.tg.add_timer.call_args_list)"},{"line_number":281,"context_line":"        self.srv.stop()"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    @mock.patch(\u0027ceilometer.publisher.test.TestPublisher\u0027)"},{"line_number":284,"context_line":"    def test_notification_reloaded_pipeline(self, fake_publisher_cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_cb57c724","line":281,"in_reply_to":"da20952f_dc48f8ce","updated":"2015-09-10 14:47:36.000000000","message":"Done","commit_id":"18f38be44fdcb75528a510a9a02497d1222da732"}]}