)]}'
{"ceilometer/api/controllers/v2/meters.py":[{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"8d3b395f9271951ad17ff288a81cb14cde7aefea","unresolved":false,"context_lines":[{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def __init__(self, **kwargs):"},{"line_number":454,"context_line":"        meter_id \u003d \u0027%s+%s\u0027 % (kwargs[\u0027resource_id\u0027], kwargs[\u0027name\u0027])"},{"line_number":455,"context_line":"        meter_id \u003d base64.b64encode(meter_id.encode(\u0027utf-8\u0027))"},{"line_number":456,"context_line":"        kwargs[\u0027meter_id\u0027] \u003d meter_id"},{"line_number":457,"context_line":"        super(Meter, self).__init__(**kwargs)"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_875da417","line":455,"updated":"2015-09-08 14:52:57.000000000","message":"just question, do we still need \".encode(\u0027utf-8\u0027)\" ?","commit_id":"397af0ef4a9d321d1742f73dbec8af16eefbf5a4"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"54ebadf44b8b867295394bb1b96c7fab67af3d77","unresolved":false,"context_lines":[{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def __init__(self, **kwargs):"},{"line_number":454,"context_line":"        meter_id \u003d \u0027%s+%s\u0027 % (kwargs[\u0027resource_id\u0027], kwargs[\u0027name\u0027])"},{"line_number":455,"context_line":"        meter_id \u003d base64.b64encode(meter_id.encode(\u0027utf-8\u0027))"},{"line_number":456,"context_line":"        kwargs[\u0027meter_id\u0027] \u003d meter_id"},{"line_number":457,"context_line":"        super(Meter, self).__init__(**kwargs)"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_63baa573","line":455,"in_reply_to":"da20952f_68d1222f","updated":"2015-09-09 07:48:26.000000000","message":"I was wrong, the encode(\u0027utf-8\u0027) still need, the NOTE messaging remind us should encode the Unicode resource_id and name to string.","commit_id":"397af0ef4a9d321d1742f73dbec8af16eefbf5a4"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"aa5843c3d6ef687909d4188565b06f1a204a8c09","unresolved":false,"context_lines":[{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def __init__(self, **kwargs):"},{"line_number":454,"context_line":"        meter_id \u003d \u0027%s+%s\u0027 % (kwargs[\u0027resource_id\u0027], kwargs[\u0027name\u0027])"},{"line_number":455,"context_line":"        meter_id \u003d base64.b64encode(meter_id.encode(\u0027utf-8\u0027))"},{"line_number":456,"context_line":"        kwargs[\u0027meter_id\u0027] \u003d meter_id"},{"line_number":457,"context_line":"        super(Meter, self).__init__(**kwargs)"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_68d1222f","line":455,"in_reply_to":"da20952f_875da417","updated":"2015-09-09 07:06:55.000000000","message":"yes, the \u0027.encode(\u0027utf-8\u0027)\u0027 is not need anymore.","commit_id":"397af0ef4a9d321d1742f73dbec8af16eefbf5a4"}],"ceilometer/tests/functional/api/v2/test_list_meters_scenarios.py":[{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"aacd1d7b5a72b953dea1e11dd7f2a0e3053433b2","unresolved":false,"context_lines":[{"line_number":788,"context_line":"            expected \u003d base64.b64encode(meter_id.encode(\u0027utf-8\u0027))"},{"line_number":789,"context_line":"            if six.PY3:"},{"line_number":790,"context_line":"                expected \u003d expected.decode(\u0027ascii\u0027)"},{"line_number":791,"context_line":"            self.assertEqual(expected, i[\u0027meter_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_bccc7762","line":791,"updated":"2015-09-08 17:15:09.000000000","message":"Can we also assert for non existence of a trailing newline in meter_id?","commit_id":"397af0ef4a9d321d1742f73dbec8af16eefbf5a4"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"93dba06bb3e35a0e5ccd2308e4d5c23e3ab8db64","unresolved":false,"context_lines":[{"line_number":788,"context_line":"            expected \u003d base64.b64encode(meter_id.encode(\u0027utf-8\u0027))"},{"line_number":789,"context_line":"            if six.PY3:"},{"line_number":790,"context_line":"                expected \u003d expected.decode(\u0027ascii\u0027)"},{"line_number":791,"context_line":"            self.assertEqual(expected, i[\u0027meter_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_a3e51d39","line":791,"in_reply_to":"da20952f_2307cd19","updated":"2015-09-09 07:29:07.000000000","message":"Done","commit_id":"397af0ef4a9d321d1742f73dbec8af16eefbf5a4"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"c513e4927acdfb572455503d311e966e86b81e6a","unresolved":false,"context_lines":[{"line_number":788,"context_line":"            expected \u003d base64.b64encode(meter_id.encode(\u0027utf-8\u0027))"},{"line_number":789,"context_line":"            if six.PY3:"},{"line_number":790,"context_line":"                expected \u003d expected.decode(\u0027ascii\u0027)"},{"line_number":791,"context_line":"            self.assertEqual(expected, i[\u0027meter_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_2307cd19","line":791,"in_reply_to":"da20952f_bccc7762","updated":"2015-09-09 07:21:22.000000000","message":"Agreed. The bug https://bugs.launchpad.net/ceilometer/+bug/1271530 is about \u0027\\n\u0027 postfix so there should be a test for it","commit_id":"397af0ef4a9d321d1742f73dbec8af16eefbf5a4"}]}