)]}'
{"ceilometer/agent/discovery/endpoint.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7b3228f0b30728af852b445474fcf183b65c2b77","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            region_name\u003dcfg.CONF.service_credentials.os_region_name)"},{"line_number":41,"context_line":"        if not endpoints:"},{"line_number":42,"context_line":"            LOG.warning(_LW(\u0027No endpoints found for service %s\u0027),"},{"line_number":43,"context_line":"                        \"\u003call services\u003e\" if param is None else param)"},{"line_number":44,"context_line":"            return []"},{"line_number":45,"context_line":"        return endpoints"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_1bf53bec","side":"PARENT","line":43,"updated":"2015-09-09 16:14:02.000000000","message":"a) \u0027if param is None else param\u0027 in a format string is pretty ugly\nb) it\u0027s duplicated\n\nSo could you move it to an assignment before the conditional block just to be a bit more tidy?","commit_id":"4c4665d70de930d02169e1d9096f7a1bbf49e70e"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"cf1cdb4cba75fef656a1ef4e177143ce683efe41","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @staticmethod"},{"line_number":36,"context_line":"    def discover(manager, param\u003dNone):"},{"line_number":37,"context_line":"        if hasattr(manager.keystone, \u0027service_catalog\u0027):"},{"line_number":38,"context_line":"            endpoints \u003d manager.keystone.service_catalog.get_urls("},{"line_number":39,"context_line":"                service_type\u003dparam,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_e349d533","line":36,"updated":"2015-09-09 07:39:10.000000000","message":"Usage of\n\nif not hasattr(manager.keystone, \u0027service_catalog\u0027)\n\nwould save from additional indent level:)","commit_id":"e85bd0a8f5cfb740561aa1884298c8b6048cc6e7"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"38ba092e56a53450f9ca00dacc00e043e235d73e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @staticmethod"},{"line_number":36,"context_line":"    def discover(manager, param\u003dNone):"},{"line_number":37,"context_line":"        if hasattr(manager.keystone, \u0027service_catalog\u0027):"},{"line_number":38,"context_line":"            endpoints \u003d manager.keystone.service_catalog.get_urls("},{"line_number":39,"context_line":"                service_type\u003dparam,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_63f4e486","line":36,"in_reply_to":"da20952f_e349d533","updated":"2015-09-09 08:39:09.000000000","message":"yes, in such way seems better","commit_id":"e85bd0a8f5cfb740561aa1884298c8b6048cc6e7"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6ea7ddf07bfafd07a5bfd4871bd916eedf501462","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        service \u003d \"\u003call services\u003e\" if param is None else param"},{"line_number":38,"context_line":"        if not hasattr(manager.keystone, \u0027service_catalog\u0027):"},{"line_number":39,"context_line":"            if isinstance(manager.keystone, Exception):"},{"line_number":40,"context_line":"                LOG.error(_(\u0027Keystone error %s\u0027), manager.keystone)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"            LOG.warning(_LW(\u0027Keystone service is not ready, Skipping\u0027"},{"line_number":43,"context_line":"                            \u0027 discovery of endpoints for service %s\u0027), service)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_e783f301","line":40,"updated":"2015-09-10 05:54:38.000000000","message":"nit: should be _LE()\n\nI\u0027m wondering if there is a case that service_catalog doesn\u0027t exist but no exception raised? if answer is no, then we can simply it","commit_id":"849d30793a20a234984176a243080711622004ec"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"efd3653961c390c87d56c2bcdb00f6a2fa364777","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @staticmethod"},{"line_number":36,"context_line":"    def discover(manager, param\u003dNone):"},{"line_number":37,"context_line":"        service \u003d \"\u003call services\u003e\" if param is None else param"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        if isinstance(manager.keystone, Exception):"},{"line_number":40,"context_line":"            LOG.error(_(\u0027Keystone error %s\u0027), manager.keystone)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_7428bd86","line":37,"updated":"2015-09-16 15:28:48.000000000","message":"it seems will be better to use:\nservice \u003d param or \"\u003call service\u003e\"","commit_id":"ede11c419cbe080463fd549f55a8d0f4fb166200"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"efd3653961c390c87d56c2bcdb00f6a2fa364777","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        service \u003d \"\u003call services\u003e\" if param is None else param"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        if isinstance(manager.keystone, Exception):"},{"line_number":40,"context_line":"            LOG.error(_(\u0027Keystone error %s\u0027), manager.keystone)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"            LOG.warning(_LW(\u0027Keystone service is not ready, Skipping\u0027"},{"line_number":43,"context_line":"                            \u0027 discovery of endpoints for service %s\u0027), service)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_54b7b9f4","line":40,"updated":"2015-09-16 15:28:48.000000000","message":"if we interested to see that error message in log it should be translated with _LE option if I didn\u0027t miss something.","commit_id":"ede11c419cbe080463fd549f55a8d0f4fb166200"}],"ceilometer/agent/discovery/tenant.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6ea7ddf07bfafd07a5bfd4871bd916eedf501462","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        service \u003d \"\u003call services\u003e\" if param is None else param"},{"line_number":36,"context_line":"        if not hasattr(manager.keystone, \u0027tenants\u0027):"},{"line_number":37,"context_line":"            if isinstance(manager.keystone, Exception):"},{"line_number":38,"context_line":"                LOG.error(_(\u0027Keystone error %s\u0027), manager.keystone)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            LOG.warning(_LW(\u0027Keystone service is not ready, Skipping\u0027"},{"line_number":41,"context_line":"                            \u0027 discovery of tenants for service %s\u0027), service)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_877b1729","line":38,"updated":"2015-09-10 05:54:38.000000000","message":"ditto","commit_id":"849d30793a20a234984176a243080711622004ec"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"efd3653961c390c87d56c2bcdb00f6a2fa364777","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def discover(self, manager, param\u003dNone):"},{"line_number":35,"context_line":"        service \u003d \"\u003call services\u003e\" if param is None else param"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if isinstance(manager.keystone, Exception):"},{"line_number":38,"context_line":"            LOG.error(_(\u0027Keystone error %s\u0027), manager.keystone)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_948f9129","line":35,"updated":"2015-09-16 15:28:48.000000000","message":"ditto","commit_id":"ede11c419cbe080463fd549f55a8d0f4fb166200"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"efd3653961c390c87d56c2bcdb00f6a2fa364777","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        service \u003d \"\u003call services\u003e\" if param is None else param"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if isinstance(manager.keystone, Exception):"},{"line_number":38,"context_line":"            LOG.error(_(\u0027Keystone error %s\u0027), manager.keystone)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            LOG.warning(_LW(\u0027Keystone service is not ready, Skipping\u0027"},{"line_number":41,"context_line":"                            \u0027 discovery of tenants for service %s\u0027), service)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_348005f7","line":38,"updated":"2015-09-16 15:28:48.000000000","message":"ditto","commit_id":"ede11c419cbe080463fd549f55a8d0f4fb166200"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"efd3653961c390c87d56c2bcdb00f6a2fa364777","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                            \u0027 discovery of tenants for service %s\u0027), service)"},{"line_number":42,"context_line":"            return []"},{"line_number":43,"context_line":"        tenants \u003d manager.keystone.tenants.list()"},{"line_number":44,"context_line":"        return tenants or []"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_b44735bb","line":44,"updated":"2015-09-16 15:28:48.000000000","message":"one more question if we had already checked for keystone exceptions do we still have a possibility to get tenants \u003d\u003d  None in manager.keystone.tenants.list()??? If not return should be improved.","commit_id":"ede11c419cbe080463fd549f55a8d0f4fb166200"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"2c85e9ea39e84df61cc10d42ace673e77f73f6b1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                            \u0027 discovery of tenants for service %s\u0027), service)"},{"line_number":42,"context_line":"            return []"},{"line_number":43,"context_line":"        tenants \u003d manager.keystone.tenants.list()"},{"line_number":44,"context_line":"        return tenants or []"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_572571be","line":44,"in_reply_to":"ba15a1d1_b44735bb","updated":"2015-09-16 19:59:53.000000000","message":"I think there is still the possibility of getting None when querying for tenants.","commit_id":"ede11c419cbe080463fd549f55a8d0f4fb166200"}],"ceilometer/agent/plugin_base.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"811a7ca1dc37575c4545f42cbf4ea29ce126a05b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                    LOG.warning(_(\u0027Skipping because keystone service is not\u0027"},{"line_number":84,"context_line":"                                  \u0027 ready\u0027))"},{"line_number":85,"context_line":"                    return iter([])"},{"line_number":86,"context_line":"            return []"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"            return f(self, *args, **kwargs)"},{"line_number":89,"context_line":"        return func"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_44b45481","line":86,"updated":"2015-09-09 00:28:42.000000000","message":"I think this line is typos","commit_id":"eca7cf373ba99724b97349327129f9e2291c3036"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6ea7ddf07bfafd07a5bfd4871bd916eedf501462","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                return iter([])"},{"line_number":74,"context_line":"            elif service_type:"},{"line_number":75,"context_line":"                if not hasattr(keystone, \u0027service_catalog\u0027):"},{"line_number":76,"context_line":"                    LOG.warning(_(\u0027Skipping because keystone service is not\u0027"},{"line_number":77,"context_line":"                                  \u0027 ready\u0027))"},{"line_number":78,"context_line":"                    return iter([])"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_e79a1362","line":76,"updated":"2015-09-10 05:54:38.000000000","message":"nit: _LW()","commit_id":"849d30793a20a234984176a243080711622004ec"}]}