)]}'
{"ceilometer/api/controllers/v2/resources.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"baca9704a08f2b8d4449ad3307f71ddbf61c52fd","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            q, pecan.request.storage_conn.get_resources)"},{"line_number":146,"context_line":"        if \u0027limit\u0027 in kwargs:"},{"line_number":147,"context_line":"            raise base.ClientSideError(_("},{"line_number":148,"context_line":"                \"Limit expressed more than once in query.\"))"},{"line_number":149,"context_line":"        resources \u003d ["},{"line_number":150,"context_line":"            Resource.from_db_and_links(r,"},{"line_number":151,"context_line":"                                       self._resource_links(r.resource_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_3a95743f","line":148,"updated":"2015-09-10 12:59:30.000000000","message":"maybe we should specifically say limit should not be express as a query field or ignore it completely.","commit_id":"5a73f1ef80ce1f1e4e6346a1d3d0bff0b706b1f2"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"61eca6acb10fb8fcf05618c743a478394cf5ab74","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            q, pecan.request.storage_conn.get_resources)"},{"line_number":146,"context_line":"        if \u0027limit\u0027 in kwargs:"},{"line_number":147,"context_line":"            raise base.ClientSideError(_("},{"line_number":148,"context_line":"                \"Limit expressed more than once in query.\"))"},{"line_number":149,"context_line":"        resources \u003d ["},{"line_number":150,"context_line":"            Resource.from_db_and_links(r,"},{"line_number":151,"context_line":"                                       self._resource_links(r.resource_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_d5b8cbc9","line":148,"in_reply_to":"da20952f_1a4430b5","updated":"2015-09-10 13:40:14.000000000","message":"i think the main concern is that the message is not entirely true. it\u0027s entire possible to be expressed once but incorrectly as a query field rather than a limit filter.","commit_id":"5a73f1ef80ce1f1e4e6346a1d3d0bff0b706b1f2"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"08496ff8ca32e23cbea15ee5f634c838e85f419f","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            q, pecan.request.storage_conn.get_resources)"},{"line_number":146,"context_line":"        if \u0027limit\u0027 in kwargs:"},{"line_number":147,"context_line":"            raise base.ClientSideError(_("},{"line_number":148,"context_line":"                \"Limit expressed more than once in query.\"))"},{"line_number":149,"context_line":"        resources \u003d ["},{"line_number":150,"context_line":"            Resource.from_db_and_links(r,"},{"line_number":151,"context_line":"                                       self._resource_links(r.resource_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_1a4430b5","line":148,"in_reply_to":"da20952f_3a95743f","updated":"2015-09-10 13:04:38.000000000","message":"Yeah, I thought about that and ended up going with this solution because we want client code (whether it be the official client or not) to know that they have a query that is now wrong and the easiest way to do that is for them to get an error.\n\nWithout this fix, that is what they would get, but it is a mean and nasty 500 error so this just makes it more friendly.\n\nIf we swallow the additional \u0027limit\u0027 keyword they may never know that something is behaving differently.","commit_id":"5a73f1ef80ce1f1e4e6346a1d3d0bff0b706b1f2"}]}