)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"cc883d60930310596f9744fbe779768a8b59fb6b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is not sane to store two differents things in same attribute."},{"line_number":14,"context_line":"This change fixes that, by storing only the keystone client object and"},{"line_number":15,"context_line":"just reraise the keystoneclient exception in case of unavialability of"},{"line_number":16,"context_line":"keystone."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"So the discovery process can detect that keystone is unavialable by"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba15a1d1_8506851b","line":15,"updated":"2015-09-16 13:50:36.000000000","message":"s/exception in case of unavialability of keystone/exception when keystone is unavailable/","commit_id":"d23172a59f813afc823757ab286744ce9b29ce26"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f95978c255a9c20ef2025346d316ed8da150ebef","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is not sane to store two differents things in same attribute."},{"line_number":14,"context_line":"This change fixes that, by storing only the keystone client object and"},{"line_number":15,"context_line":"just reraise the keystoneclient exception in case of unavialability of"},{"line_number":16,"context_line":"keystone."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"So the discovery process can detect that keystone is unavialable by"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba15a1d1_a5ef09e8","line":15,"in_reply_to":"ba15a1d1_8506851b","updated":"2015-09-16 13:59:31.000000000","message":"Done","commit_id":"d23172a59f813afc823757ab286744ce9b29ce26"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"cc883d60930310596f9744fbe779768a8b59fb6b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"just reraise the keystoneclient exception in case of unavialability of"},{"line_number":16,"context_line":"keystone."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"So the discovery process can detect that keystone is unavialable by"},{"line_number":19,"context_line":"catching the base exception of the keystoneclient library and"},{"line_number":20,"context_line":"just skip discovery plugin with an appropriate message."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba15a1d1_c518fd77","line":18,"updated":"2015-09-16 13:50:36.000000000","message":"s/unavialable/unavailable/","commit_id":"d23172a59f813afc823757ab286744ce9b29ce26"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f95978c255a9c20ef2025346d316ed8da150ebef","unresolved":false,"context_lines":[{"line_number":15,"context_line":"just reraise the keystoneclient exception in case of unavialability of"},{"line_number":16,"context_line":"keystone."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"So the discovery process can detect that keystone is unavialable by"},{"line_number":19,"context_line":"catching the base exception of the keystoneclient library and"},{"line_number":20,"context_line":"just skip discovery plugin with an appropriate message."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba15a1d1_a5c62966","line":18,"in_reply_to":"ba15a1d1_c518fd77","updated":"2015-09-16 13:59:31.000000000","message":"Done","commit_id":"d23172a59f813afc823757ab286744ce9b29ce26"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"cc883d60930310596f9744fbe779768a8b59fb6b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"catching the base exception of the keystoneclient library and"},{"line_number":20,"context_line":"just skip discovery plugin with an appropriate message."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Another advantage is that we will not shallow anymore unexpected keystone"},{"line_number":23,"context_line":"client issue by a simple keystone authentication message."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The check_keystone won\u0027t work as expected too. Usage of cfg.CONF into a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba15a1d1_45238da7","line":22,"updated":"2015-09-16 13:50:36.000000000","message":"s/shallow/swallow/","commit_id":"d23172a59f813afc823757ab286744ce9b29ce26"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f95978c255a9c20ef2025346d316ed8da150ebef","unresolved":false,"context_lines":[{"line_number":19,"context_line":"catching the base exception of the keystoneclient library and"},{"line_number":20,"context_line":"just skip discovery plugin with an appropriate message."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Another advantage is that we will not shallow anymore unexpected keystone"},{"line_number":23,"context_line":"client issue by a simple keystone authentication message."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The check_keystone won\u0027t work as expected too. Usage of cfg.CONF into a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba15a1d1_c5c31d56","line":22,"in_reply_to":"ba15a1d1_45238da7","updated":"2015-09-16 13:59:31.000000000","message":"Done","commit_id":"d23172a59f813afc823757ab286744ce9b29ce26"}],"ceilometer/agent/plugin_base.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"f48e1565de052019bebf7bb0521fdedb673fa6c5","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from ceilometer import messaging"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"cfg.CONF.import_group(\u0027service_credentials\u0027, \u0027ceilometer.service\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_316a741b","line":30,"updated":"2015-09-16 00:21:11.000000000","message":"nit: I think we can remove this line because we don\u0027t use those options in this file any more. If you agree, then the import oslo.cfg may not be needed as well.","commit_id":"d23172a59f813afc823757ab286744ce9b29ce26"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f95978c255a9c20ef2025346d316ed8da150ebef","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from ceilometer import messaging"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"cfg.CONF.import_group(\u0027service_credentials\u0027, \u0027ceilometer.service\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_c5155de5","line":30,"in_reply_to":"ba15a1d1_316a741b","updated":"2015-09-16 13:59:31.000000000","message":"Done","commit_id":"d23172a59f813afc823757ab286744ce9b29ce26"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"92d99941c02aa0ded933783e49ef7ac3ca4c8d77","unresolved":false,"context_lines":[{"line_number":213,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":214,"context_line":"class DiscoveryBase(object):"},{"line_number":215,"context_line":"    REQUIRED_KEYSTONE_SERVICE \u003d None"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @abc.abstractmethod"},{"line_number":218,"context_line":"    def discover(self, manager, param\u003dNone):"},{"line_number":219,"context_line":"        \"\"\"Discover resources to monitor."}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_9ab7b0f4","line":216,"updated":"2015-09-16 20:15:27.000000000","message":"A doc string comment as to what it means will be helpful for other pollsters who want to use keystone. Also, we can rename it to KEYSTONE_REQUIRED_FOR_SERVICE","commit_id":"75998f6f1a78a969efd149fd58cbf6f4f3d6c46a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"907084a3dcc44ade9886d0ba57aa83253008e981","unresolved":false,"context_lines":[{"line_number":213,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":214,"context_line":"class DiscoveryBase(object):"},{"line_number":215,"context_line":"    REQUIRED_KEYSTONE_SERVICE \u003d None"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @abc.abstractmethod"},{"line_number":218,"context_line":"    def discover(self, manager, param\u003dNone):"},{"line_number":219,"context_line":"        \"\"\"Discover resources to monitor."}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_2a2e3d43","line":216,"in_reply_to":"ba15a1d1_9ab7b0f4","updated":"2015-09-17 10:14:46.000000000","message":"Done","commit_id":"75998f6f1a78a969efd149fd58cbf6f4f3d6c46a"}]}