)]}'
{"ceilometer/event/endpoint.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"f97aa018231d10f2b5e5afddcb916400ae252393","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        :param payload: notification payload"},{"line_number":62,"context_line":"        :param metadata: metadata about the notification"},{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # NOTE: the rpc layer currently rips out the notification"},{"line_number":66,"context_line":"        # delivery_info, which is critical to determining the"},{"line_number":67,"context_line":"        # source of the notification. This will have to get added back later."}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_7c1478f4","line":64,"updated":"2015-09-15 02:24:03.000000000","message":"we need to avoid recording these type of notification messages to events, because that will boom a plenty of \u0027telemetry.polling\u0027 events, that make it hard to know what has happened in past by events. maybe we can add check here and abandon patch[1] ?\n\n[1] https://review.openstack.org/#/c/218148/","commit_id":"f75b883e1b3898c9769cc663c503d6ad3a11dabe"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"a94017005c97d16606b5ea369043a40d9efd29ba","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        :param event_type: type of notification"},{"line_number":61,"context_line":"        :param payload: notification payload"},{"line_number":62,"context_line":"        :param metadata: metadata about the notification"},{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # NOTE: the rpc layer currently rips out the notification"},{"line_number":66,"context_line":"        # delivery_info, which is critical to determining the"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_1ab455cf","line":63,"updated":"2015-09-15 08:35:23.000000000","message":"if want to add disable/enable telemetry.* type events functionality in this patch, we can just add this:\n\n    if not cfg.CONF.event.enable_ipc_events:\n        pass\n\nbecause after this change, the telemetry.* events only in notification.sample queue (is it right ?). so we can just pass in sample() method to ignore the events.\n\nThe related process is in [1], the callback is this sample() method, in my approach, the filtering is performed in screen.match() method. In that way, a RE will be used to init a NotificationFilter, the check is RE matching check, and it will check with all priority methods (info, sample, error), so maybe that way is inefficient :\n\n[1] https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/notify/dispatcher.py#L124-L135","commit_id":"942b1a56463d9e9f1317fd2fd43a3a3e4fcebd08"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"617bf372bbf64767919a775165a9262c82514fea","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        :param event_type: type of notification"},{"line_number":61,"context_line":"        :param payload: notification payload"},{"line_number":62,"context_line":"        :param metadata: metadata about the notification"},{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # NOTE: the rpc layer currently rips out the notification"},{"line_number":66,"context_line":"        # delivery_info, which is critical to determining the"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_8c590c5d","line":63,"in_reply_to":"ba15a1d1_1ab455cf","updated":"2015-09-15 11:52:41.000000000","message":"i\u0027m wondering if we need this if we don\u0027t actually support health check events currently. the main reason i blocked liusheng\u0027s patch was that if we leave this off, we don\u0027t need his... but if we keep it, we need it.\n\nseeing as we don\u0027t actually have any healthcheck events currently, maybe it\u0027s best we leave it off?","commit_id":"942b1a56463d9e9f1317fd2fd43a3a3e4fcebd08"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"edc9f835f9d9728b15b8ee935fa5b61f5f83f990","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        :param event_type: type of notification"},{"line_number":61,"context_line":"        :param payload: notification payload"},{"line_number":62,"context_line":"        :param metadata: metadata about the notification"},{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # NOTE: the rpc layer currently rips out the notification"},{"line_number":66,"context_line":"        # delivery_info, which is critical to determining the"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_5ce4f10b","line":63,"in_reply_to":"ba15a1d1_8c590c5d","updated":"2015-09-15 16:41:24.000000000","message":"gordc, luisheng: Yes, we can remove the sample method for now, but when we need it to support health check events, we will need to add it back and can use the new conf enable_ipc_events to filter telemetry.* events.","commit_id":"942b1a56463d9e9f1317fd2fd43a3a3e4fcebd08"}]}