)]}'
{"ceilometer/tests/unit/test_coordination.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"a7311fbe22734b3df08211929f1b118c752007f7","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class MockToozCoordinator(object):"},{"line_number":28,"context_line":"    def __init__(self, member_id, shared_storage):"},{"line_number":29,"context_line":"        self._member_id \u003d member_id"},{"line_number":30,"context_line":"        self._groups \u003d shared_storage"},{"line_number":31,"context_line":"        self.is_started \u003d False"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_f71a856e","line":28,"updated":"2015-09-23 14:00:05.000000000","message":"MockToozCoordinator knows nothing about retry_count param that is used in line 159","commit_id":"09d9325ddf084173c06bc52009ffd48a92d39503"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"a5ad5cbf0dd8f8ebe11b75e1f9910742f870061b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class MockToozCoordinator(object):"},{"line_number":28,"context_line":"    def __init__(self, member_id, shared_storage):"},{"line_number":29,"context_line":"        self._member_id \u003d member_id"},{"line_number":30,"context_line":"        self._groups \u003d shared_storage"},{"line_number":31,"context_line":"        self.is_started \u003d False"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_978549d0","line":28,"in_reply_to":"ba15a1d1_f71a856e","updated":"2015-09-23 14:11:04.000000000","message":"Based on whether retry_count is available, a different set of args are passed to init, so that the correct instance is initialized.","commit_id":"09d9325ddf084173c06bc52009ffd48a92d39503"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"a7311fbe22734b3df08211929f1b118c752007f7","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                        lambda _, member_id:"},{"line_number":159,"context_line":"                        coordinator_cls(member_id, shared_storage,"},{"line_number":160,"context_line":"                                        retry_count) if retry_count else"},{"line_number":161,"context_line":"                        coordinator_cls(member_id, shared_storage)):"},{"line_number":162,"context_line":"            pc \u003d coordination.PartitionCoordinator(agent_id)"},{"line_number":163,"context_line":"            pc.start()"},{"line_number":164,"context_line":"            return pc"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_646c8535","line":161,"updated":"2015-09-23 14:00:05.000000000","message":"It seems that block 159-161 is a little bit odd, it could be written without condition at all.","commit_id":"09d9325ddf084173c06bc52009ffd48a92d39503"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"a5ad5cbf0dd8f8ebe11b75e1f9910742f870061b","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                        lambda _, member_id:"},{"line_number":159,"context_line":"                        coordinator_cls(member_id, shared_storage,"},{"line_number":160,"context_line":"                                        retry_count) if retry_count else"},{"line_number":161,"context_line":"                        coordinator_cls(member_id, shared_storage)):"},{"line_number":162,"context_line":"            pc \u003d coordination.PartitionCoordinator(agent_id)"},{"line_number":163,"context_line":"            pc.start()"},{"line_number":164,"context_line":"            return pc"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_37fa3d76","line":161,"in_reply_to":"ba15a1d1_646c8535","updated":"2015-09-23 14:11:04.000000000","message":"Yes, in that case, retry_count needs to be declared in the base coordinator_cls, i,e MockToozCoordinator where its not really needed.","commit_id":"09d9325ddf084173c06bc52009ffd48a92d39503"}]}