)]}'
{"ceilometer/meter/notifications.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"cc7eef995c4dfc7f9c21f89405a31a9c6bf225b6","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                      \" %(meter_def)s : %(err)s\")"},{"line_number":194,"context_line":"                      % dict(meter_def\u003devent_def, err\u003dme))"},{"line_number":195,"context_line":"            LOG.error(errmsg)"},{"line_number":196,"context_line":"            continue"},{"line_number":197,"context_line":"    return meter_defs"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_72f258d4","line":196,"updated":"2015-10-06 20:02:52.000000000","message":"this continue doesn\u0027t actually do anything.","commit_id":"1a3b2bea1a331e39a398a038afc763d73e0e3a44"}],"ceilometer/tests/unit/meter/test_notifications.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5e6e84c477b6464af99ab6610da6738400c6391e","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                         s1[\u0027resource_id\u0027])"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    @mock.patch(\u0027ceilometer.meter.notifications.LOG\u0027)"},{"line_number":659,"context_line":"    def test_bad_meter_definition_skip(self, LOG):"},{"line_number":660,"context_line":"        cfg \u003d yaml.dump("},{"line_number":661,"context_line":"            {\u0027metric\u0027: [dict(name\u003d\"test\","},{"line_number":662,"context_line":"                        event_type\u003d\"test.create\","}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_a205d77a","line":659,"updated":"2015-10-07 15:14:10.000000000","message":"maybe move this up to TestMeterDefinition or another class? since we arent\u0027 actually testing processing here.","commit_id":"a6a4f0f7bd752ba41c506e969f224068e0a1a17c"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"52347bc2f9173e6fcd1fae209050f6ddf5132a36","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                         s1[\u0027resource_id\u0027])"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    @mock.patch(\u0027ceilometer.meter.notifications.LOG\u0027)"},{"line_number":659,"context_line":"    def test_bad_meter_definition_skip(self, LOG):"},{"line_number":660,"context_line":"        cfg \u003d yaml.dump("},{"line_number":661,"context_line":"            {\u0027metric\u0027: [dict(name\u003d\"test\","},{"line_number":662,"context_line":"                        event_type\u003d\"test.create\","}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_98e12e01","line":659,"in_reply_to":"7a2fa921_a205d77a","updated":"2015-10-07 15:39:11.000000000","message":"hmm I feel its still part of Processing as the meter processing class is what uses the load_definitions method. Also i need to reuse the __setup_meter_def_file call so it fits well in this existing class. \n\nSo if you\u0027re not particular i prefer to leave this here. May be i can move it up in this class so it doesnt get lost with all the validation tests.","commit_id":"a6a4f0f7bd752ba41c506e969f224068e0a1a17c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5e6e84c477b6464af99ab6610da6738400c6391e","unresolved":false,"context_lines":[{"line_number":665,"context_line":"                        volume\u003d\"$.payload.volume\","},{"line_number":666,"context_line":"                        resource_id\u003d\"$.payload.resource_id\","},{"line_number":667,"context_line":"                        project_id\u003d\"$.payload.project_id\"),"},{"line_number":668,"context_line":"                        dict(name\u003d\"test2\", type\u003d\"foo\", event_type\u003d\"bar.create\","},{"line_number":669,"context_line":"                        unit\u003d\"foo\", volume\u003d\"bar\","},{"line_number":670,"context_line":"                        resource_id\u003d\"bea70e51c7340cb9d555b15cbfcaec23\")]})"},{"line_number":671,"context_line":"        data \u003d self.__setup_meter_def_file(cfg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_021dabbc","line":668,"updated":"2015-10-07 15:14:10.000000000","message":"can we explicitly mark this as \u0027bad\u0027 definition? it was somewhat hard to spot there was too.\n\nalso, can we add one more valid one after it so we can prove it didn\u0027t just quit after error (in case we remove the reverse() we have in loading code)","commit_id":"a6a4f0f7bd752ba41c506e969f224068e0a1a17c"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"52347bc2f9173e6fcd1fae209050f6ddf5132a36","unresolved":false,"context_lines":[{"line_number":665,"context_line":"                        volume\u003d\"$.payload.volume\","},{"line_number":666,"context_line":"                        resource_id\u003d\"$.payload.resource_id\","},{"line_number":667,"context_line":"                        project_id\u003d\"$.payload.project_id\"),"},{"line_number":668,"context_line":"                        dict(name\u003d\"test2\", type\u003d\"foo\", event_type\u003d\"bar.create\","},{"line_number":669,"context_line":"                        unit\u003d\"foo\", volume\u003d\"bar\","},{"line_number":670,"context_line":"                        resource_id\u003d\"bea70e51c7340cb9d555b15cbfcaec23\")]})"},{"line_number":671,"context_line":"        data \u003d self.__setup_meter_def_file(cfg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_58e4f60b","line":668,"in_reply_to":"7a2fa921_021dabbc","updated":"2015-10-07 15:39:11.000000000","message":"sure, will do","commit_id":"a6a4f0f7bd752ba41c506e969f224068e0a1a17c"}]}