)]}'
{"ceilometer/hardware/pollsters/generic.py":[{"author":{"_account_id":18137,"name":"Xia Linjuan","email":"ljxiash@cn.ibm.com","username":"xialinjuan"},"change_message_id":"dc0336cb2777271dc2ea8173d2720d5dbbc6561b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        try:"},{"line_number":262,"context_line":"            meter \u003d MeterDefinition(meter_def)"},{"line_number":263,"context_line":"            mappings[meter.name] \u003d meter"},{"line_number":264,"context_line":"        except MeterDefinitionException as me:"},{"line_number":265,"context_line":"            errmsg \u003d (_LE(\"Error loading meter definition : %(err)s\")"},{"line_number":266,"context_line":"                      % dict(err\u003dme.message))"},{"line_number":267,"context_line":"            LOG.error(errmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_b3b6c1da","line":264,"updated":"2015-10-14 09:44:53.000000000","message":"For every meter you should follow the definition of it. for the meter, \"unit\" is a required field. If you miss it, it causes an error.","commit_id":"51550e68274ae302a56514dd5512349816076a18"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"d561ca7e1a9f405f97134ea69b1c98ff5695ff31","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        try:"},{"line_number":262,"context_line":"            meter \u003d MeterDefinition(meter_def)"},{"line_number":263,"context_line":"            mappings[meter.name] \u003d meter"},{"line_number":264,"context_line":"        except MeterDefinitionException as me:"},{"line_number":265,"context_line":"            errmsg \u003d (_LE(\"Error loading meter definition : %(err)s\")"},{"line_number":266,"context_line":"                      % dict(err\u003dme.message))"},{"line_number":267,"context_line":"            LOG.error(errmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_8df3670a","line":264,"updated":"2015-10-14 06:27:52.000000000","message":"This exception is raised by design in the class MeterDefinition. Not sure whether it is valid bug or just by design.","commit_id":"51550e68274ae302a56514dd5512349816076a18"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"675b370fcc521d95616b31ea460e9663c643dc49","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        try:"},{"line_number":262,"context_line":"            meter \u003d MeterDefinition(meter_def)"},{"line_number":263,"context_line":"            mappings[meter.name] \u003d meter"},{"line_number":264,"context_line":"        except MeterDefinitionException as me:"},{"line_number":265,"context_line":"            errmsg \u003d (_LE(\"Error loading meter definition : %(err)s\")"},{"line_number":266,"context_line":"                      % dict(err\u003dme.message))"},{"line_number":267,"context_line":"            LOG.error(errmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_e12f5af4","line":264,"in_reply_to":"5a2ca52d_b14c7043","updated":"2015-10-15 02:43:55.000000000","message":"Hi Rohit\n\nhttps://github.com/openstack/ceilometer/blob/master/ceilometer/hardware/pollsters/generic.py#L69\n\nI think if we don\u0027t want the exceptions to block the process. Could we just remove the raise exception code?\n\nJust a suggestion.\n\nThanks","commit_id":"51550e68274ae302a56514dd5512349816076a18"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"cb3efe060ede7bf4c5d275304d1db09808cdf81d","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        try:"},{"line_number":262,"context_line":"            meter \u003d MeterDefinition(meter_def)"},{"line_number":263,"context_line":"            mappings[meter.name] \u003d meter"},{"line_number":264,"context_line":"        except MeterDefinitionException as me:"},{"line_number":265,"context_line":"            errmsg \u003d (_LE(\"Error loading meter definition : %(err)s\")"},{"line_number":266,"context_line":"                      % dict(err\u003dme.message))"},{"line_number":267,"context_line":"            LOG.error(errmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_b14c7043","line":264,"in_reply_to":"5a2ca52d_b3b6c1da","updated":"2015-10-14 13:37:30.000000000","message":"I think it makes sense to log an error for an incomplete metric and continue processing others.","commit_id":"51550e68274ae302a56514dd5512349816076a18"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"4fbec68be49b40561515a4cefc38f844f06ac16e","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        try:"},{"line_number":262,"context_line":"            meter \u003d MeterDefinition(meter_def)"},{"line_number":263,"context_line":"            mappings[meter.name] \u003d meter"},{"line_number":264,"context_line":"        except MeterDefinitionException as me:"},{"line_number":265,"context_line":"            errmsg \u003d (_LE(\"Error loading meter definition : %(err)s\")"},{"line_number":266,"context_line":"                      % dict(err\u003dme.message))"},{"line_number":267,"context_line":"            LOG.error(errmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_27a0e742","line":264,"in_reply_to":"5a2ca52d_e12f5af4","updated":"2015-10-15 14:29:23.000000000","message":"we still need to catch invalid meters if any and log the error. So i dont see any benefit of removing the exceptions.","commit_id":"51550e68274ae302a56514dd5512349816076a18"}]}