)]}'
{"ceilometer/event/storage/impl_sqlalchemy.py":[{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"f061ac8014287b2b69e7d7374e8c35dad013540d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        # in failure case and db reconnection has already been implemented"},{"line_number":131,"context_line":"        # in storage.__init__.get_connection_from_config function"},{"line_number":132,"context_line":"        options \u003d dict(cfg.CONF.database.items())"},{"line_number":133,"context_line":"        options[\u0027max_retries\u0027] \u003d 0"},{"line_number":134,"context_line":"        # oslo.db doesn\u0027t support options defined by Ceilometer"},{"line_number":135,"context_line":"        for opt in storage.OPTS:"},{"line_number":136,"context_line":"            options.pop(opt.name, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_c5069c1b","line":133,"updated":"2015-11-18 20:13:51.000000000","message":"maybe replace above 2 lines with options \u003d dict(max_retries\u003d0), then no need to pop.","commit_id":"71c0904e1b926fb62f1ecd3ae9904df947193b68"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"7535f8ca8fb503bca81211e7752a921a528382d4","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        # in failure case and db reconnection has already been implemented"},{"line_number":131,"context_line":"        # in storage.__init__.get_connection_from_config function"},{"line_number":132,"context_line":"        options \u003d dict(cfg.CONF.database.items())"},{"line_number":133,"context_line":"        options[\u0027max_retries\u0027] \u003d 0"},{"line_number":134,"context_line":"        # oslo.db doesn\u0027t support options defined by Ceilometer"},{"line_number":135,"context_line":"        for opt in storage.OPTS:"},{"line_number":136,"context_line":"            options.pop(opt.name, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_d4271ec8","line":133,"in_reply_to":"ba8a016a_71bd24b6","updated":"2015-11-19 05:19:13.000000000","message":"Thanks, [1] is where that is done..I didnt realize it earlier.. \n\n[1] https://github.com/openstack/ceilometer/blob/master/ceilometer/storage/__init__.py#L93","commit_id":"71c0904e1b926fb62f1ecd3ae9904df947193b68"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"48ce09e7e8bc13a6f316bc7ac47e33a3584b0639","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        # in failure case and db reconnection has already been implemented"},{"line_number":131,"context_line":"        # in storage.__init__.get_connection_from_config function"},{"line_number":132,"context_line":"        options \u003d dict(cfg.CONF.database.items())"},{"line_number":133,"context_line":"        options[\u0027max_retries\u0027] \u003d 0"},{"line_number":134,"context_line":"        # oslo.db doesn\u0027t support options defined by Ceilometer"},{"line_number":135,"context_line":"        for opt in storage.OPTS:"},{"line_number":136,"context_line":"            options.pop(opt.name, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_71bd24b6","line":133,"in_reply_to":"ba8a016a_c5069c1b","updated":"2015-11-19 03:59:48.000000000","message":"we cannot, because oslo.db registers all the options it required in cfg.CONF.database","commit_id":"71c0904e1b926fb62f1ecd3ae9904df947193b68"}],"ceilometer/storage/impl_sqlalchemy.py":[{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"f061ac8014287b2b69e7d7374e8c35dad013540d","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # in failure case and db reconnection has already been implemented"},{"line_number":223,"context_line":"        # in storage.__init__.get_connection_from_config function"},{"line_number":224,"context_line":"        options \u003d dict(cfg.CONF.database.items())"},{"line_number":225,"context_line":"        options[\u0027max_retries\u0027] \u003d 0"},{"line_number":226,"context_line":"        # oslo.db doesn\u0027t support options defined by Ceilometer"},{"line_number":227,"context_line":"        for opt in storage.OPTS:"},{"line_number":228,"context_line":"            options.pop(opt.name, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_054fc46b","line":225,"updated":"2015-11-18 20:13:51.000000000","message":"ditto.","commit_id":"71c0904e1b926fb62f1ecd3ae9904df947193b68"}]}