)]}'
{"id":"openstack%2Fceilometer~247021","triplet_id":"openstack%2Fceilometer~master~I8313b96ee51fa9c0b4e301bc8d6e6e058655b4ed","project":"openstack/ceilometer","branch":"master","hashtags":[],"change_id":"I8313b96ee51fa9c0b4e301bc8d6e6e058655b4ed","subject":"Reduced complexity of get_meter_statistics method","status":"ABANDONED","created":"2015-11-18 16:34:25.000000000","updated":"2015-11-24 16:41:56.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9a337df158ec97157dd87f186057dc1e10ed1ea7","_number":247021,"virtual_id_number":247021,"owner":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-11-18 18:23:19.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-11-18 16:54:25.000000000","_account_id":15843,"name":"Intel Hardware-Meters CI","email":"ipmi-ci@intel.com","username":"ipmici"},{"date":"2015-11-24 10:16:17.000000000","_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":19271,"name":"Biswajeeban Mishra","email":"mishra@inf.u-szeged.hu","username":"biswajeeban"},{"_account_id":18599,"name":"Péter Hegedűs","email":"hpeter@inf.u-szeged.hu","username":"hpeter"},{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},{"date":"2015-11-18 18:15:06.000000000","_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15843,"name":"Intel Hardware-Meters CI","email":"ipmi-ci@intel.com","username":"ipmici"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":-2,"date":"2015-11-18 17:26:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":19271,"name":"Biswajeeban Mishra","email":"mishra@inf.u-szeged.hu","username":"biswajeeban"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18599,"name":"Péter Hegedűs","email":"hpeter@inf.u-szeged.hu","username":"hpeter"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":15843,"name":"Intel Hardware-Meters CI","email":"ipmi-ci@intel.com","username":"ipmici"},{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"date":"2015-11-18 16:36:11.000000000","_account_id":19271,"name":"Biswajeeban Mishra","email":"mishra@inf.u-szeged.hu","username":"biswajeeban"},{"date":"2015-11-18 16:36:01.000000000","_account_id":18599,"name":"Péter Hegedűs","email":"hpeter@inf.u-szeged.hu","username":"hpeter"},{"date":"2015-11-18 16:36:27.000000000","_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},{"date":"2015-11-18 16:36:37.000000000","_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},{"date":"2015-11-18 16:36:20.000000000","_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},{"date":"2015-11-18 16:36:46.000000000","_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":15843,"name":"Intel Hardware-Meters CI","email":"ipmi-ci@intel.com","username":"ipmici"},{"_account_id":18599,"name":"Péter Hegedűs","email":"hpeter@inf.u-szeged.hu","username":"hpeter"},{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},{"_account_id":19271,"name":"Biswajeeban Mishra","email":"mishra@inf.u-szeged.hu","username":"biswajeeban"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-18 16:36:01.000000000","updated_by":{"_account_id":18599,"name":"Péter Hegedűs","email":"hpeter@inf.u-szeged.hu","username":"hpeter"},"reviewer":{"_account_id":18599,"name":"Péter Hegedűs","email":"hpeter@inf.u-szeged.hu","username":"hpeter"},"state":"REVIEWER"},{"updated":"2015-11-18 16:36:11.000000000","updated_by":{"_account_id":19271,"name":"Biswajeeban Mishra","email":"mishra@inf.u-szeged.hu","username":"biswajeeban"},"reviewer":{"_account_id":19271,"name":"Biswajeeban Mishra","email":"mishra@inf.u-szeged.hu","username":"biswajeeban"},"state":"REVIEWER"},{"updated":"2015-11-18 16:36:20.000000000","updated_by":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"reviewer":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"state":"REVIEWER"},{"updated":"2015-11-18 16:36:27.000000000","updated_by":{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},"reviewer":{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},"state":"REVIEWER"},{"updated":"2015-11-18 16:36:37.000000000","updated_by":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"reviewer":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"state":"REVIEWER"},{"updated":"2015-11-18 16:36:46.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2015-11-18 16:54:25.000000000","updated_by":{"_account_id":15843,"name":"Intel Hardware-Meters CI","email":"ipmi-ci@intel.com","username":"ipmici"},"reviewer":{"_account_id":15843,"name":"Intel Hardware-Meters CI","email":"ipmi-ci@intel.com","username":"ipmici"},"state":"REVIEWER"},{"updated":"2015-11-18 17:26:20.000000000","updated_by":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"reviewer":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"state":"REVIEWER"},{"updated":"2015-11-18 18:23:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-11-24 10:16:17.000000000","updated_by":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"reviewer":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"state":"REVIEWER"}],"messages":[{"id":"25ef7e4c934526cee9eb8b05086ae0e31fe80ab6","author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"date":"2015-11-18 16:34:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"742db828a499f3372e7c3303c2079f5a15bf29ee","author":{"_account_id":15843,"name":"Intel Hardware-Meters CI","email":"ipmi-ci@intel.com","username":"ipmici"},"date":"2015-11-18 16:54:25.000000000","message":"Patch Set 1:\n\n* ipmi-test http://52.27.155.124/ipmi/247021/1 : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"9b25bbcded88a8f0b3ae776429ce640db18f0b8c","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2015-11-18 17:26:20.000000000","message":"Patch Set 1: Code-Review-2\n\nThis is useless code churn.  Moving things around does not simplify anything when you\u0027re just creating function used once in the whole code base.","accounts_in_message":[],"_revision_number":1},{"id":"8a8a74d666328349d38b33e24f72c427130f00bb","author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"date":"2015-11-18 18:15:06.000000000","message":"Patch Set 1:\n\nHi!\n\nOk! I thought that the -get_meter_statistics- function is too large. (Thus the smaller logical parts are separated)","accounts_in_message":[],"_revision_number":1},{"id":"d032bee359edae0640c69a3a4b61b890bafd4db1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-18 18:23:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ceilometer-pep8 http://logs.openstack.org/21/247021/1/check/gate-ceilometer-pep8/2a1dd96/ : SUCCESS in 3m 11s\n- gate-ceilometer-docs http://docs-draft.openstack.org/21/247021/1/check/gate-ceilometer-docs/3e47d3a//doc/build/html/ : SUCCESS in 7m 47s\n- gate-ceilometer-python27 http://logs.openstack.org/21/247021/1/check/gate-ceilometer-python27/52a824e/ : SUCCESS in 4m 56s\n- gate-ceilometer-python34 http://logs.openstack.org/21/247021/1/check/gate-ceilometer-python34/eaee989/ : SUCCESS in 5m 17s\n- gate-tempest-dsvm-ceilometer-mongodb-full http://logs.openstack.org/21/247021/1/check/gate-tempest-dsvm-ceilometer-mongodb-full/ad036b2/ : SUCCESS in 58m 43s (non-voting)\n- gate-tempest-dsvm-ceilometer-mysql-neutron-full http://logs.openstack.org/21/247021/1/check/gate-tempest-dsvm-ceilometer-mysql-neutron-full/c5c4ed0/ : SUCCESS in 1h 11m 05s\n- gate-tempest-dsvm-ceilometer-mysql-full http://logs.openstack.org/21/247021/1/check/gate-tempest-dsvm-ceilometer-mysql-full/fb7f5cc/ : SUCCESS in 56m 29s\n- gate-tempest-dsvm-ceilometer-postgresql-full http://logs.openstack.org/21/247021/1/check/gate-tempest-dsvm-ceilometer-postgresql-full/2087c67/ : SUCCESS in 1h 05m 26s\n- gate-ceilometer-dsvm-functional-mongodb http://logs.openstack.org/21/247021/1/check/gate-ceilometer-dsvm-functional-mongodb/7487852/ : SUCCESS in 45m 46s\n- gate-ceilometer-dsvm-functional-mysql http://logs.openstack.org/21/247021/1/check/gate-ceilometer-dsvm-functional-mysql/78a5732/ : SUCCESS in 55m 30s\n- gate-ceilometer-dsvm-functional-postgresql http://logs.openstack.org/21/247021/1/check/gate-ceilometer-dsvm-functional-postgresql/c99fd8d/ : SUCCESS in 55m 34s\n- gate-grenade-dsvm-ceilometer http://logs.openstack.org/21/247021/1/check/gate-grenade-dsvm-ceilometer/ab65833/ : SUCCESS in 51m 27s\n- gate-ceilometer-dsvm-integration http://logs.openstack.org/21/247021/1/check/gate-ceilometer-dsvm-integration/6edf27e/ : SUCCESS in 45m 50s","accounts_in_message":[],"_revision_number":1},{"id":"e5f2637237d550022297b39ba2a41393e231a59c","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2015-11-24 10:16:17.000000000","message":"Patch Set 1:\n\nnot worth to do it, there are other things need your help, for example, performance!!","accounts_in_message":[],"_revision_number":1},{"id":"9a337df158ec97157dd87f186057dc1e10ed1ea7","author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"date":"2015-11-24 16:41:56.000000000","message":"Abandoned\n\n\"This is useless code churn\"","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"784c772bd899a051488f64eb05a91006f72aa31b","revisions":{"784c772bd899a051488f64eb05a91006f72aa31b":{"kind":"REWORK","_number":1,"created":"2015-11-18 16:34:25.000000000","uploader":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"ref":"refs/changes/21/247021/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/21/247021/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/21/247021/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/21/247021/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/21/247021/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/21/247021/1"}}},"commit":{"parents":[{"commit":"e5ded45e49376d150dee8d75b3cf2e81fffeecc7","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/e5ded45e49376d150dee8d75b3cf2e81fffeecc7"}]}],"author":{"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","date":"2015-11-18 16:32:46.000000000","tz":60},"committer":{"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","date":"2015-11-18 16:34:23.000000000","tz":60},"subject":"Reduced complexity of get_meter_statistics method","message":"Reduced complexity of get_meter_statistics method\n\nThe get_meter_statistics method is very large - almost 100 lines\n(in ceilometer/storage/impl_hbase.py).\nI extracted some of the functionalities into helper functions\nto reduce the length and complexity of get_meter_statistics.\nAdditionally it became more readable as well, without\nchanging its functionality.\n\nChange-Id: I8313b96ee51fa9c0b4e301bc8d6e6e058655b4ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/784c772bd899a051488f64eb05a91006f72aa31b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/784c772bd899a051488f64eb05a91006f72aa31b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
