)]}'
{"ceilometer/alarm/storage/impl_sqlalchemy.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"2f4c7d047d83155563d22e5b48f393e29b695ad4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        options \u003d dict(cfg.CONF.database.items())"},{"line_number":88,"context_line":"        options[\u0027max_retries\u0027] \u003d 0"},{"line_number":89,"context_line":"        # oslo.db doesn\u0027t support options defined by Ceilometer"},{"line_number":90,"context_line":"        for opt in storage.OPTS:"},{"line_number":91,"context_line":"            options.pop(opt.name, None)"},{"line_number":92,"context_line":"        self._engine_facade \u003d db_session.EngineFacade(url, **options)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_63aad81b","line":90,"updated":"2015-12-22 21:47:47.000000000","message":"We have similar situation with oslo_dp options that are registered in storage.__init__ and are not used by other drivers, that is why my suggestion is to register oslo_db options only in sqlalchemy drivers to avoid same pop operations for unused params in other drivers","commit_id":"40c5ceefa96d93cf9b12fa189787ed3f26e853cc"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"8e5496cfe6663f1a0436ea7a7c8cb746f258c99e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        options \u003d dict(cfg.CONF.database.items())"},{"line_number":88,"context_line":"        options[\u0027max_retries\u0027] \u003d 0"},{"line_number":89,"context_line":"        # oslo.db doesn\u0027t support options defined by Ceilometer"},{"line_number":90,"context_line":"        for opt in storage.OPTS:"},{"line_number":91,"context_line":"            options.pop(opt.name, None)"},{"line_number":92,"context_line":"        self._engine_facade \u003d db_session.EngineFacade(url, **options)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_9f694c8e","line":90,"in_reply_to":"1a7b0d38_63aad81b","updated":"2015-12-23 03:27:25.000000000","message":"the problem is not where those option is registered, is which section the option belongs to. oslo_db registers its options under database section, but doesn\u0027t accept options not defined by it, so if we want to avoid the pop and the warnings, we need to register options to another section","commit_id":"40c5ceefa96d93cf9b12fa189787ed3f26e853cc"}]}