)]}'
{"ceilometer/storage/impl_mongodb.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a97e188a8723c42201b65b965b5e83ba0a06007c","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                # Singleton"},{"line_number":261,"context_line":"                if Connection._mim_instance is None:"},{"line_number":262,"context_line":"                    LOG.debug(\u0027Creating a new MIM Connection object\u0027)"},{"line_number":263,"context_line":"                    from ming import mim"},{"line_number":264,"context_line":"                    Connection._mim_instance \u003d mim.Connection()"},{"line_number":265,"context_line":"                self.conn \u003d Connection._mim_instance"},{"line_number":266,"context_line":"                LOG.debug(\u0027Using MIM for test connection\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F19I%3D","line":263,"updated":"2013-03-25 13:23:43.000000000","message":"imports should be at the top of the file. oslo provides a util: importutils. would importutils.import_module help in this case?","commit_id":"f675896e57f0c6d723e12ee8821d3e31cdf81c83"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"fbb73f1197cddd038f240b6502036aa947e8a4df","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                # Singleton"},{"line_number":261,"context_line":"                if Connection._mim_instance is None:"},{"line_number":262,"context_line":"                    LOG.debug(\u0027Creating a new MIM Connection object\u0027)"},{"line_number":263,"context_line":"                    from ming import mim"},{"line_number":264,"context_line":"                    Connection._mim_instance \u003d mim.Connection()"},{"line_number":265,"context_line":"                self.conn \u003d Connection._mim_instance"},{"line_number":266,"context_line":"                LOG.debug(\u0027Using MIM for test connection\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F1sE%3D","line":263,"in_reply_to":"AAAAOH%2F%2F10g%3D","updated":"2013-03-25 15:57:04.000000000","message":"If the tests are configured to want mim, but the import fails, then we want the error message from the import to be reported. If we use importutils.import_module(), the error message will not be reported.","commit_id":"f675896e57f0c6d723e12ee8821d3e31cdf81c83"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"e447ac646bb36e50df77951acd64bcedb120ddf8","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                # Singleton"},{"line_number":261,"context_line":"                if Connection._mim_instance is None:"},{"line_number":262,"context_line":"                    LOG.debug(\u0027Creating a new MIM Connection object\u0027)"},{"line_number":263,"context_line":"                    from ming import mim"},{"line_number":264,"context_line":"                    Connection._mim_instance \u003d mim.Connection()"},{"line_number":265,"context_line":"                self.conn \u003d Connection._mim_instance"},{"line_number":266,"context_line":"                LOG.debug(\u0027Using MIM for test connection\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F10g%3D","line":263,"in_reply_to":"AAAAOH%2F%2F17U%3D","updated":"2013-03-25 14:54:33.000000000","message":"apologies, i worded that poorly. what i meant was there is an utility provided in oslo. at the top, you would import importutils and here you would put something similar to:\n\nmim \u003d importutils.import_module(\u0027ming.mim\u0027)\n\nhaven\u0027t used this method before so i could be wrong here","commit_id":"f675896e57f0c6d723e12ee8821d3e31cdf81c83"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"1417fc52572317d8a0ee07811aee2d1e99a4a21b","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                # Singleton"},{"line_number":261,"context_line":"                if Connection._mim_instance is None:"},{"line_number":262,"context_line":"                    LOG.debug(\u0027Creating a new MIM Connection object\u0027)"},{"line_number":263,"context_line":"                    from ming import mim"},{"line_number":264,"context_line":"                    Connection._mim_instance \u003d mim.Connection()"},{"line_number":265,"context_line":"                self.conn \u003d Connection._mim_instance"},{"line_number":266,"context_line":"                LOG.debug(\u0027Using MIM for test connection\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F17U%3D","line":263,"in_reply_to":"AAAAOH%2F%2F19I%3D","updated":"2013-03-25 13:35:53.000000000","message":"Yeah, but this is a special case for tests only, and shouldn\u0027t be used at runtime. Therefore it\u0027s not listed in pip-requires, and won\u0027t be available, so important at top of the file doesn\u0027t sound like the best idea.","commit_id":"f675896e57f0c6d723e12ee8821d3e31cdf81c83"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a8f8eba8cf24390d7d80a302ac86d08d0f11f5ca","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                # Singleton"},{"line_number":261,"context_line":"                if Connection._mim_instance is None:"},{"line_number":262,"context_line":"                    LOG.debug(\u0027Creating a new MIM Connection object\u0027)"},{"line_number":263,"context_line":"                    from ming import mim"},{"line_number":264,"context_line":"                    Connection._mim_instance \u003d mim.Connection()"},{"line_number":265,"context_line":"                self.conn \u003d Connection._mim_instance"},{"line_number":266,"context_line":"                LOG.debug(\u0027Using MIM for test connection\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F0Pk%3D","line":263,"in_reply_to":"AAAAOH%2F%2F1kM%3D","updated":"2013-03-26 14:07:00.000000000","message":"OK, I\u0027ve looked at importutils. That function is meant for cases where the module to be loaded is not known when the source is written (i.e., the name is coming from a configuration file). That isn\u0027t the case here.","commit_id":"f675896e57f0c6d723e12ee8821d3e31cdf81c83"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"43d7fee32163dd890bf94ce62e3f1a19af1a20c0","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                # Singleton"},{"line_number":261,"context_line":"                if Connection._mim_instance is None:"},{"line_number":262,"context_line":"                    LOG.debug(\u0027Creating a new MIM Connection object\u0027)"},{"line_number":263,"context_line":"                    from ming import mim"},{"line_number":264,"context_line":"                    Connection._mim_instance \u003d mim.Connection()"},{"line_number":265,"context_line":"                self.conn \u003d Connection._mim_instance"},{"line_number":266,"context_line":"                LOG.debug(\u0027Using MIM for test connection\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F1kM%3D","line":263,"in_reply_to":"AAAAOH%2F%2F1sE%3D","updated":"2013-03-25 16:51:34.000000000","message":"might not understand correctly but were we expecting an error message different than this: http://pastie.org/7112911? i tried passing in importutils.import_module(\u0027mim\u0027) which does throw an ImportError.","commit_id":"f675896e57f0c6d723e12ee8821d3e31cdf81c83"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"fbb73f1197cddd038f240b6502036aa947e8a4df","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        pass"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def clear(self):"},{"line_number":300,"context_line":"        if self._mim_instance is not None:"},{"line_number":301,"context_line":"            # Don\u0027t want to use drop_database() because"},{"line_number":302,"context_line":"            # may end up running out of spidermonkey instances."},{"line_number":303,"context_line":"            # http://davisp.lighthouseapp.com/projects/26898/tickets/22"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F1sc%3D","line":300,"updated":"2013-03-25 15:57:04.000000000","message":"Maybe we should subclass the mim.Connection() class to replace drop_database() with a call to clear() so we don\u0027t need this method to know whether it is using MIM or Mongo?","commit_id":"f675896e57f0c6d723e12ee8821d3e31cdf81c83"}]}