)]}'
{"ceilometer/pipeline.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"e356063061bdc75982140771f14e122cf2fe215e","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        try:"},{"line_number":424,"context_line":"            for transformer in self.transformers:"},{"line_number":425,"context_line":"                event \u003d transformer.handle_sample(ctxt, event)"},{"line_number":426,"context_line":"                return event"},{"line_number":427,"context_line":"        except Exception as err:"},{"line_number":428,"context_line":"            LOG.exception(err)"},{"line_number":429,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_e5833e01","line":426,"updated":"2016-02-24 15:36:27.000000000","message":"this is wrong. you are returning in the middle of a loop. i imagine you want to finish all the transformers first.","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"1542d5583c37cd43e0eb8dd51ca9b078c9a69f92","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        try:"},{"line_number":424,"context_line":"            for transformer in self.transformers:"},{"line_number":425,"context_line":"                event \u003d transformer.handle_sample(ctxt, event)"},{"line_number":426,"context_line":"                return event"},{"line_number":427,"context_line":"        except Exception as err:"},{"line_number":428,"context_line":"            LOG.exception(err)"},{"line_number":429,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_946226ac","line":426,"in_reply_to":"bae84128_e5833e01","updated":"2016-02-25 13:39:05.000000000","message":"Done","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"}],"ceilometer/transformer/event_bracketer.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"e356063061bdc75982140771f14e122cf2fe215e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        and optional conditions for other events fields"},{"line_number":76,"context_line":"        :param target: dict containing target event type and trait definitions"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        self.events \u003d events or []"},{"line_number":79,"context_line":"        self.target \u003d target or {}"},{"line_number":80,"context_line":"        self.sequence \u003d ([ev[\u0027event_type\u0027] for ev in events]"},{"line_number":81,"context_line":"                         if events else [])"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_90b8ae2b","line":78,"updated":"2016-02-24 15:36:27.000000000","message":"this is never used","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"1542d5583c37cd43e0eb8dd51ca9b078c9a69f92","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        and optional conditions for other events fields"},{"line_number":76,"context_line":"        :param target: dict containing target event type and trait definitions"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        self.events \u003d events or []"},{"line_number":79,"context_line":"        self.target \u003d target or {}"},{"line_number":80,"context_line":"        self.sequence \u003d ([ev[\u0027event_type\u0027] for ev in events]"},{"line_number":81,"context_line":"                         if events else [])"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_d45caeef","line":78,"in_reply_to":"bae84128_90b8ae2b","updated":"2016-02-25 13:39:05.000000000","message":"Done","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"e356063061bdc75982140771f14e122cf2fe215e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        self.events \u003d events or []"},{"line_number":79,"context_line":"        self.target \u003d target or {}"},{"line_number":80,"context_line":"        self.sequence \u003d ([ev[\u0027event_type\u0027] for ev in events]"},{"line_number":81,"context_line":"                         if events else [])"},{"line_number":82,"context_line":"        self.target_event_params \u003d self._required_params(target)"},{"line_number":83,"context_line":"        self.cache \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_f042da0d","line":80,"updated":"2016-02-24 15:36:27.000000000","message":"either events should be required or this should match all if not required. it doesn\u0027t make sense to let transformer survive and match nothing","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"1542d5583c37cd43e0eb8dd51ca9b078c9a69f92","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        self.events \u003d events or []"},{"line_number":79,"context_line":"        self.target \u003d target or {}"},{"line_number":80,"context_line":"        self.sequence \u003d ([ev[\u0027event_type\u0027] for ev in events]"},{"line_number":81,"context_line":"                         if events else [])"},{"line_number":82,"context_line":"        self.target_event_params \u003d self._required_params(target)"},{"line_number":83,"context_line":"        self.cache \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_28413d3a","line":80,"in_reply_to":"bae84128_f042da0d","updated":"2016-02-25 13:39:05.000000000","message":"Done","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"e356063061bdc75982140771f14e122cf2fe215e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        return [None for i in self.sequence]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _create_target_dict(self):"},{"line_number":110,"context_line":"        return dict()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def _fill_cache_params(self, event\u003dNone):"},{"line_number":113,"context_line":"        params_cached \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_e584ded3","line":110,"updated":"2016-02-24 15:36:27.000000000","message":"this seems unnecessary","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"1542d5583c37cd43e0eb8dd51ca9b078c9a69f92","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        return [None for i in self.sequence]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _create_target_dict(self):"},{"line_number":110,"context_line":"        return dict()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def _fill_cache_params(self, event\u003dNone):"},{"line_number":113,"context_line":"        params_cached \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_a85d4dee","line":110,"in_reply_to":"bae84128_e584ded3","updated":"2016-02-25 13:39:05.000000000","message":"cache get_or_create method requires function as a parameter that is used if key is not in cache.","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"e356063061bdc75982140771f14e122cf2fe215e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                            generated\u003ddatetime.datetime.utcnow(),"},{"line_number":145,"context_line":"                            message_id\u003duuid.uuid4(),"},{"line_number":146,"context_line":"                            traits\u003dtraits,"},{"line_number":147,"context_line":"                            raw\u003dself.target.get(\u0027raw\u0027, {}))"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def handle_sample(self, context, event):"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_30f722d4","line":147,"updated":"2016-02-24 15:36:27.000000000","message":"why would we let raw be configurable?","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"1542d5583c37cd43e0eb8dd51ca9b078c9a69f92","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                            generated\u003ddatetime.datetime.utcnow(),"},{"line_number":145,"context_line":"                            message_id\u003duuid.uuid4(),"},{"line_number":146,"context_line":"                            traits\u003dtraits,"},{"line_number":147,"context_line":"                            raw\u003dself.target.get(\u0027raw\u0027, {}))"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def handle_sample(self, context, event):"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_686ce59c","line":147,"in_reply_to":"bae84128_30f722d4","updated":"2016-02-25 13:39:05.000000000","message":"Done","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"e356063061bdc75982140771f14e122cf2fe215e","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        if event.event_type not in self.sequence:"},{"line_number":152,"context_line":"            # TODO(idegtiarov): add optional conditions checking"},{"line_number":153,"context_line":"            return"},{"line_number":154,"context_line":"        resource \u003d self._event_resource(\u0027instance_id\u0027, event.traits)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        mkr_key \u003d \u0027brt_marker_\u0027 + resource"},{"line_number":157,"context_line":"        tgt_key \u003d \u0027brk_tgt_\u0027 + resource"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_253886d2","line":154,"updated":"2016-02-24 15:36:27.000000000","message":"this only works for compute?","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"1542d5583c37cd43e0eb8dd51ca9b078c9a69f92","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        if event.event_type not in self.sequence:"},{"line_number":152,"context_line":"            # TODO(idegtiarov): add optional conditions checking"},{"line_number":153,"context_line":"            return"},{"line_number":154,"context_line":"        resource \u003d self._event_resource(\u0027instance_id\u0027, event.traits)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        mkr_key \u003d \u0027brt_marker_\u0027 + resource"},{"line_number":157,"context_line":"        tgt_key \u003d \u0027brk_tgt_\u0027 + resource"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_08cb9973","line":154,"in_reply_to":"bae84128_253886d2","updated":"2016-02-25 13:39:05.000000000","message":"As I wrote in patch commit message yes, now we support bracketer transformer for compute only, that is because of absent general event resource definition in event traits.","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"e356063061bdc75982140771f14e122cf2fe215e","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        resource \u003d self._event_resource(\u0027instance_id\u0027, event.traits)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        mkr_key \u003d \u0027brt_marker_\u0027 + resource"},{"line_number":157,"context_line":"        tgt_key \u003d \u0027brk_tgt_\u0027 + resource"},{"line_number":158,"context_line":"        marker \u003d self.cache.get_or_create(mkr_key, self._create_marker)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        ev_position \u003d self.sequence.index(event.event_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_056d82cb","line":157,"updated":"2016-02-24 15:36:27.000000000","message":"is tgt \u003d\u003d target and mkr \u003d\u003d marker? let\u0027s use the real word since these aren\u0027t common/normal acronyms.","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"1542d5583c37cd43e0eb8dd51ca9b078c9a69f92","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        resource \u003d self._event_resource(\u0027instance_id\u0027, event.traits)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        mkr_key \u003d \u0027brt_marker_\u0027 + resource"},{"line_number":157,"context_line":"        tgt_key \u003d \u0027brk_tgt_\u0027 + resource"},{"line_number":158,"context_line":"        marker \u003d self.cache.get_or_create(mkr_key, self._create_marker)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        ev_position \u003d self.sequence.index(event.event_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_c8aff192","line":157,"in_reply_to":"bae84128_056d82cb","updated":"2016-02-25 13:39:05.000000000","message":"Done","commit_id":"01c4a9260a7e6eb6c0edfd9b927bb71ae6914c6a"}]}