)]}'
{"ceilometer/coordination.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"082e674c068f7c82056d10f6f18343ff57f555a4","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            LOG.debug(\u0027My subset: %s\u0027, [str(f) for f in filtered])"},{"line_number":177,"context_line":"            return filtered"},{"line_number":178,"context_line":"        except tooz.coordination.MemberNotJoined:"},{"line_number":179,"context_line":"            if attempt \u003e\u003d 5:"},{"line_number":180,"context_line":"                raise"},{"line_number":181,"context_line":"            LOG.warning(_LW(\u0027Cannot extract tasks because agent failed to \u0027"},{"line_number":182,"context_line":"                            \u0027join group properly. Rejoining group.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_e0ce9782","line":179,"range":{"start_line":179,"start_character":27,"end_line":179,"end_character":28},"updated":"2016-01-28 01:47:49.000000000","message":"Is possible to avoid this hard code magic number? To be configurable?","commit_id":"8f257d0c21c17eefc7847c421beff8b338f78609"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"432178a382c7be41ff173dbf69bd3c8805f6cd47","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            LOG.debug(\u0027My subset: %s\u0027, [str(f) for f in filtered])"},{"line_number":177,"context_line":"            return filtered"},{"line_number":178,"context_line":"        except tooz.coordination.MemberNotJoined:"},{"line_number":179,"context_line":"            if attempt \u003e\u003d 5:"},{"line_number":180,"context_line":"                raise"},{"line_number":181,"context_line":"            LOG.warning(_LW(\u0027Cannot extract tasks because agent failed to \u0027"},{"line_number":182,"context_line":"                            \u0027join group properly. Rejoining group.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_eb12de61","line":179,"range":{"start_line":179,"start_character":27,"end_line":179,"end_character":28},"in_reply_to":"7a5de9d1_e0ce9782","updated":"2016-01-28 14:29:44.000000000","message":"i personally don\u0027t think we need to be configurable. i really just added this as a weak attempt to save service.","commit_id":"8f257d0c21c17eefc7847c421beff8b338f78609"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"082e674c068f7c82056d10f6f18343ff57f555a4","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                raise"},{"line_number":181,"context_line":"            LOG.warning(_LW(\u0027Cannot extract tasks because agent failed to \u0027"},{"line_number":182,"context_line":"                            \u0027join group properly. Rejoining group.\u0027))"},{"line_number":183,"context_line":"            self.join_group(group_id)"},{"line_number":184,"context_line":"            return self.extract_my_subset(group_id, iterable, attempt + 1)"},{"line_number":185,"context_line":"        except tooz.coordination.ToozError:"},{"line_number":186,"context_line":"            LOG.exception(_LE(\u0027Error getting group membership info from \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_20ab4f8b","line":183,"range":{"start_line":183,"start_character":36,"end_line":183,"end_character":37},"updated":"2016-01-28 01:47:49.000000000","message":"Why need to join group here again explicitly? I think the recursive call into extract_my_subset() will join_group at Ln 167.","commit_id":"8f257d0c21c17eefc7847c421beff8b338f78609"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"432178a382c7be41ff173dbf69bd3c8805f6cd47","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                raise"},{"line_number":181,"context_line":"            LOG.warning(_LW(\u0027Cannot extract tasks because agent failed to \u0027"},{"line_number":182,"context_line":"                            \u0027join group properly. Rejoining group.\u0027))"},{"line_number":183,"context_line":"            self.join_group(group_id)"},{"line_number":184,"context_line":"            return self.extract_my_subset(group_id, iterable, attempt + 1)"},{"line_number":185,"context_line":"        except tooz.coordination.ToozError:"},{"line_number":186,"context_line":"            LOG.exception(_LE(\u0027Error getting group membership info from \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_6bf26ed4","line":183,"range":{"start_line":183,"start_character":36,"end_line":183,"end_character":37},"in_reply_to":"7a5de9d1_20ab4f8b","updated":"2016-01-28 14:29:44.000000000","message":"167 will skip. locally, it does appear we joined and thus the id will be in _groups... but in the membership server, it will not be joined. therefore we need to join again.","commit_id":"8f257d0c21c17eefc7847c421beff8b338f78609"}]}