)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"5487714ff669a3e05cdfb6b6d0d6ab8dbeb425e5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"make even-alarm supported in default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Alarming function in ceilometer code base is deprecated in liberty,"},{"line_number":10,"context_line":"and Aodh, which has event-alarm feature, should be enabled in default"},{"line_number":11,"context_line":"configuration. So, we can set CEILOMETER_EVENT_ALARM\u003dTrue ."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_86812ac6","line":9,"range":{"start_line":9,"start_character":45,"end_line":9,"end_character":66},"updated":"2016-02-02 09:14:01.000000000","message":"I think this should be \"removed in Mitaka\" here.","commit_id":"773b6364694d28d24c4bbd6ae9e6ae1b06d34f0e"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"56b5c993ea372cbd17e4100bf6ae4e0722e40b52","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"make even-alarm supported in default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Alarming function in ceilometer code base is deprecated in liberty,"},{"line_number":10,"context_line":"and Aodh, which has event-alarm feature, should be enabled in default"},{"line_number":11,"context_line":"configuration. So, we can set CEILOMETER_EVENT_ALARM\u003dTrue ."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a5ae5dd_cf725111","line":9,"range":{"start_line":9,"start_character":45,"end_line":9,"end_character":66},"in_reply_to":"7a5de9d1_86812ac6","updated":"2016-02-05 05:29:41.000000000","message":"Done","commit_id":"773b6364694d28d24c4bbd6ae9e6ae1b06d34f0e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"5487714ff669a3e05cdfb6b6d0d6ab8dbeb425e5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Alarming function in ceilometer code base is deprecated in liberty,"},{"line_number":10,"context_line":"and Aodh, which has event-alarm feature, should be enabled in default"},{"line_number":11,"context_line":"configuration. So, we can set CEILOMETER_EVENT_ALARM\u003dTrue ."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This can reduce complexity of packaging."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_064d3ac4","line":11,"range":{"start_line":11,"start_character":58,"end_line":11,"end_character":59},"updated":"2016-02-02 09:14:01.000000000","message":"... and add the required configuration to \u0027event_pipeline.yaml\u0027.","commit_id":"773b6364694d28d24c4bbd6ae9e6ae1b06d34f0e"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"56b5c993ea372cbd17e4100bf6ae4e0722e40b52","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Alarming function in ceilometer code base is deprecated in liberty,"},{"line_number":10,"context_line":"and Aodh, which has event-alarm feature, should be enabled in default"},{"line_number":11,"context_line":"configuration. So, we can set CEILOMETER_EVENT_ALARM\u003dTrue ."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This can reduce complexity of packaging."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a5ae5dd_6f623d40","line":11,"range":{"start_line":11,"start_character":58,"end_line":11,"end_character":59},"in_reply_to":"7a5de9d1_064d3ac4","updated":"2016-02-05 05:29:41.000000000","message":"Done","commit_id":"773b6364694d28d24c4bbd6ae9e6ae1b06d34f0e"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"ac53a723ea5b1d7eeebb4c2f198cced8b18b12f8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2016-01-28 19:03:58 +0900"},{"line_number":4,"context_line":"Commit:     Ryota MIBU \u003cr-mibu@cq.jp.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-05 14:29:52 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"make even-alarm supported in default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Alarming function in ceilometer code base will be removed in Mitaka,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a5ae5dd_75027db6","line":6,"updated":"2016-02-09 09:40:13.000000000","message":"evenT-alarm","commit_id":"0ff5de72a04035e1346e2ec359fb649e98ddf959"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"912d37c80575fe08d7537dae863ee53c7bd2c300","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2016-01-28 19:03:58 +0900"},{"line_number":4,"context_line":"Commit:     Ryota MIBU \u003cr-mibu@cq.jp.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-05 14:29:52 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"make even-alarm supported in default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Alarming function in ceilometer code base will be removed in Mitaka,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dae33548_f465c244","line":6,"in_reply_to":"5a5ae5dd_75027db6","updated":"2016-02-18 15:25:18.000000000","message":"Done","commit_id":"0ff5de72a04035e1346e2ec359fb649e98ddf959"}],"devstack/plugin.sh":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"43da2a62bad4e9781451a1feb04fc41179e7ec9b","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    if [ \"$CEILOMETER_PIPELINE_INTERVAL\" ]; then"},{"line_number":309,"context_line":"        sed -i \"s/interval:.*/interval: ${CEILOMETER_PIPELINE_INTERVAL}/\" $CEILOMETER_CONF_DIR/pipeline.yaml"},{"line_number":310,"context_line":"    fi"},{"line_number":311,"context_line":"    if [ \"$CEILOMETER_EVENT_ALARM\" \u003d\u003d \"False\" ]; then"},{"line_number":312,"context_line":"        deprecated \"CEILOMETER_EVENT_ALARM\""},{"line_number":313,"context_line":"        sed -i \u0027/^ *- notifier:\\/\\/?topic\u003dalarm.all$/d\u0027 $CEILOMETER_CONF_DIR/event_pipeline.yaml"},{"line_number":314,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5a5ae5dd_1d3c872e","line":311,"updated":"2016-02-09 12:40:03.000000000","message":"we should try to detect if aodh is enabled. if aodh is not, this will just end up flooding MQ with no consumer","commit_id":"0ff5de72a04035e1346e2ec359fb649e98ddf959"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"931cb261a2a524008fe72476b1d644e7333d7df4","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    if [ \"$CEILOMETER_PIPELINE_INTERVAL\" ]; then"},{"line_number":309,"context_line":"        sed -i \"s/interval:.*/interval: ${CEILOMETER_PIPELINE_INTERVAL}/\" $CEILOMETER_CONF_DIR/pipeline.yaml"},{"line_number":310,"context_line":"    fi"},{"line_number":311,"context_line":"    if [ \"$CEILOMETER_EVENT_ALARM\" \u003d\u003d \"False\" ]; then"},{"line_number":312,"context_line":"        deprecated \"CEILOMETER_EVENT_ALARM\""},{"line_number":313,"context_line":"        sed -i \u0027/^ *- notifier:\\/\\/?topic\u003dalarm.all$/d\u0027 $CEILOMETER_CONF_DIR/event_pipeline.yaml"},{"line_number":314,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5a5ae5dd_bda9b326","line":311,"in_reply_to":"5a5ae5dd_1d3c872e","updated":"2016-02-09 12:43:31.000000000","message":"Can we just detect as opposed to have this variable which indicates we still have alarming functionality in Ceilometer although it is finally removed?","commit_id":"0ff5de72a04035e1346e2ec359fb649e98ddf959"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"912d37c80575fe08d7537dae863ee53c7bd2c300","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    if [ \"$CEILOMETER_PIPELINE_INTERVAL\" ]; then"},{"line_number":309,"context_line":"        sed -i \"s/interval:.*/interval: ${CEILOMETER_PIPELINE_INTERVAL}/\" $CEILOMETER_CONF_DIR/pipeline.yaml"},{"line_number":310,"context_line":"    fi"},{"line_number":311,"context_line":"    if [ \"$CEILOMETER_EVENT_ALARM\" \u003d\u003d \"False\" ]; then"},{"line_number":312,"context_line":"        deprecated \"CEILOMETER_EVENT_ALARM\""},{"line_number":313,"context_line":"        sed -i \u0027/^ *- notifier:\\/\\/?topic\u003dalarm.all$/d\u0027 $CEILOMETER_CONF_DIR/event_pipeline.yaml"},{"line_number":314,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dae33548_bf1af3c3","line":311,"in_reply_to":"5a5ae5dd_bda9b326","updated":"2016-02-18 15:25:18.000000000","message":"OK, then let\u0027s take this approach, although i have concern that the service detection with \u0027is_service_enabled\u0027 (which is the solution only i know) works only for single node deployment. So, deployer, who wants to run aodh and ceilometer in different hosts, needs a workaround... This shouldn\u0027t be common case though.","commit_id":"0ff5de72a04035e1346e2ec359fb649e98ddf959"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c713781f21a90ba5b1e76ba44177207db9bc8964","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    if [ \"$CEILOMETER_PIPELINE_INTERVAL\" ]; then"},{"line_number":308,"context_line":"        sed -i \"s/interval:.*/interval: ${CEILOMETER_PIPELINE_INTERVAL}/\" $CEILOMETER_CONF_DIR/pipeline.yaml"},{"line_number":309,"context_line":"    fi"},{"line_number":310,"context_line":"    if ! is_service_enabled aodh-listener || [ \"$CEILOMETER_EVENT_ALARM\" \u003d\u003d \"False\" ]; then"},{"line_number":311,"context_line":"        if [ -v CEILOMETER_EVENT_ALARM ]; then"},{"line_number":312,"context_line":"            deprecated \"CEILOMETER_EVENT_ALARM\""},{"line_number":313,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"dae33548_331e160c","line":310,"updated":"2016-02-18 16:59:54.000000000","message":"why do we reference CEILOMETER_EVENT_ALARM here but we removed it from settings?","commit_id":"a8ef661b3be3f0a8d5a87542da9fe4b2d49e44fc"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"c691e0594a435d6a23ba118db53c2cc5ea00801a","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    if [ \"$CEILOMETER_PIPELINE_INTERVAL\" ]; then"},{"line_number":308,"context_line":"        sed -i \"s/interval:.*/interval: ${CEILOMETER_PIPELINE_INTERVAL}/\" $CEILOMETER_CONF_DIR/pipeline.yaml"},{"line_number":309,"context_line":"    fi"},{"line_number":310,"context_line":"    if ! is_service_enabled aodh-listener || [ \"$CEILOMETER_EVENT_ALARM\" \u003d\u003d \"False\" ]; then"},{"line_number":311,"context_line":"        if [ -v CEILOMETER_EVENT_ALARM ]; then"},{"line_number":312,"context_line":"            deprecated \"CEILOMETER_EVENT_ALARM\""},{"line_number":313,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bae84128_e02bc5e9","line":310,"in_reply_to":"dae33548_331e160c","updated":"2016-02-22 10:51:52.000000000","message":"just for backward compatibility to support old local.conf, but i can delete this check.","commit_id":"a8ef661b3be3f0a8d5a87542da9fe4b2d49e44fc"}],"etc/ceilometer/event_pipeline.yaml":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c713781f21a90ba5b1e76ba44177207db9bc8964","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      triggers:"},{"line_number":12,"context_line":"      publishers:"},{"line_number":13,"context_line":"          - notifier://"},{"line_number":14,"context_line":"          - notifier://?topic\u003dalarm.all"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dae33548_d38a4a1a","line":14,"updated":"2016-02-18 16:59:54.000000000","message":"i\u0027m not a fan of this blindly sending to queue by default.\n\nceilometer should really be self-contained","commit_id":"a8ef661b3be3f0a8d5a87542da9fe4b2d49e44fc"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"c691e0594a435d6a23ba118db53c2cc5ea00801a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      triggers:"},{"line_number":12,"context_line":"      publishers:"},{"line_number":13,"context_line":"          - notifier://"},{"line_number":14,"context_line":"          - notifier://?topic\u003dalarm.all"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bae84128_093ecdb7","line":14,"in_reply_to":"dae33548_d38a4a1a","updated":"2016-02-22 10:51:52.000000000","message":"Yeah, this could be arguable. TBH, this is the main motivation of this patch, so that we can enable event-alarm by default, although that can be enabled by integration tools.\n\nIn nova, the default of the similar config is also False (CONF.notify_on_state_change \u003d None).","commit_id":"a8ef661b3be3f0a8d5a87542da9fe4b2d49e44fc"}]}