)]}'
{"ceilometer/meter/notifications.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"9e955652b918a8a4d669ea6ba238ffbfa3b193fe","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        for meter_cfg in reversed(meters_cfg[\u0027metric\u0027]):"},{"line_number":187,"context_line":"            if meter_cfg.get(\u0027name\u0027) in definitions:"},{"line_number":188,"context_line":"                # skip duplicate meters"},{"line_number":189,"context_line":"                LOG.warning(\"Skipping duplicate meter definition %s\""},{"line_number":190,"context_line":"                            % meter_cfg)"},{"line_number":191,"context_line":"                continue"},{"line_number":192,"context_line":"            if (meter_cfg.get(\u0027volume\u0027) !\u003d 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_0babcf75","line":189,"updated":"2016-02-03 19:41:40.000000000","message":"_LW","commit_id":"d612e6865c7833eded9799facaa44fe5a343ea97"}],"ceilometer/tests/unit/meter/test_notifications.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"b8e8eecb3c32ecdd0436ecfd6ac9baedd98620fd","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        self._load_meter_def_file(cfg)"},{"line_number":352,"context_line":"        c \u003d list(self.handler.process_notification(NOTIFICATION))"},{"line_number":353,"context_line":"        self.assertEqual(2, len(c))"},{"line_number":354,"context_line":"        s1 \u003d c[0].as_dict()"},{"line_number":355,"context_line":"        self.assertEqual(\u0027test1\u0027, s1[\u0027name\u0027])"},{"line_number":356,"context_line":"        s2 \u003d c[1].as_dict()"},{"line_number":357,"context_line":"        self.assertEqual(\u0027test2\u0027, s2[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_cfaab570","line":354,"updated":"2016-02-03 14:11:14.000000000","message":"Now this assert fails. I guess, the main reason is that now you cannot guarantee the order of metrics because you use set. I don\u0027t think it\u0027s a problem. So, you need to change this test to\n\nself.assertIn(\u0027test1\u0027, s1)\nself.assertIn(\u0027test2\u0027, s1)","commit_id":"2295c8573706aec5d7febd738ff02c2818ed9e2d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"9e955652b918a8a4d669ea6ba238ffbfa3b193fe","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                             resource_id\u003d\"$.payload.resource_id\","},{"line_number":350,"context_line":"                             project_id\u003d\"$.payload.project_id\")]})"},{"line_number":351,"context_line":"        self._load_meter_def_file(cfg)"},{"line_number":352,"context_line":"        mtrs \u003d list(self.handler.process_notification(NOTIFICATION))"},{"line_number":353,"context_line":"        self.assertEqual(2, len(mtrs))"},{"line_number":354,"context_line":"        expected_mtrs \u003d [\u0027test1\u0027, \u0027test2\u0027]"},{"line_number":355,"context_line":"        for mtr in mtrs:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_0bf0af8f","line":352,"updated":"2016-02-03 19:41:40.000000000","message":"we should probably just add the vowels back in.","commit_id":"d612e6865c7833eded9799facaa44fe5a343ea97"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"b6ebba27d159c8e639128d60830f7489ac96d5e9","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        cfg \u003d yaml.dump("},{"line_number":679,"context_line":"            {\u0027metric\u0027: [dict(name\u003d\"test1\","},{"line_number":680,"context_line":"                        event_type\u003d\"test.create\","},{"line_number":681,"context_line":"                        type\u003d\"delta\","},{"line_number":682,"context_line":"                             unit\u003d\"B\","},{"line_number":683,"context_line":"                             volume\u003d\"$.payload.volume\","},{"line_number":684,"context_line":"                             resource_id\u003d\"$.payload.resource_id\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_611e1665","line":681,"range":{"start_line":681,"start_character":35,"end_line":681,"end_character":37},"updated":"2016-02-04 02:17:19.000000000","message":"nits, while you fixing other nits, would be nicer if you fix these indentations too.","commit_id":"d612e6865c7833eded9799facaa44fe5a343ea97"}],"releasenotes/notes/skip-duplicate-meter-def-0420164f6a95c50c.yaml":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"69dcf803ecba3520713571efef12a577b347d519","unresolved":false,"context_lines":[{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - \u003e"},{"line_number":6,"context_line":"    [`bug 1536498 \u003chttps://bugs.launchpad.net/ceilometer/+bug/1536498\u003e`_]"},{"line_number":7,"context_line":"    Patch to fix duplicate meter definitions causing duplicate samples."},{"line_number":8,"context_line":"    If a duplicate is found, log a warning and skip the meter definition."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a5de9d1_acea07ab","line":7,"updated":"2016-02-02 09:45:05.000000000","message":"It would be better to add that the first occurrence of meter definition will be taken as a rule","commit_id":"bda6ab54ddc511b970fcdaed56d6c77523e049c1"}]}