)]}'
{"ceilometer/notification.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"dc90b2b6d759be0c0fdc7d5f7f2f3c7053ac2357","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                    [pipe_endpoint(self.ctxt, pipe)],"},{"line_number":289,"context_line":"                    batch_size\u003dcfg.CONF.notification.batch_size,"},{"line_number":290,"context_line":"                    batch_timeout\u003dcfg.CONF.notification.batch_timeout)"},{"line_number":291,"context_line":"                # NOTE(gordc): set single thread to process data sequentially"},{"line_number":292,"context_line":"                listener.start(override_pool_size\u003d1)"},{"line_number":293,"context_line":"                self.pipeline_listeners.append(listener)"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_27864765","line":291,"updated":"2016-02-28 15:48:55.000000000","message":"+100 to this. Let me describe what I see during testing.\nIf we use default value\u003d64 (or even 16) cpu is gonna die and message processing takes very long time (context switching?). I understand that production envs should be much more powerful that my test env, but I think it\u0027s better to increase workers (\u003dcpu_number) amount instead of using multithreading in one listener.","commit_id":"9ecccd7d51fac0d98e2625a2e20e7007c2ae6f0e"},{"author":{"_account_id":20150,"name":"Qichen Hao","email":"adsl123gg2008@gmail.com","username":"adsl123gg2008"},"change_message_id":"7d2d2ab93cfb75985630afce28ca31cf131bca35","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                pipe_endpoint \u003d (pipeline.EventPipelineEndpoint"},{"line_number":283,"context_line":"                                 if isinstance(pipe, pipeline.EventPipeline)"},{"line_number":284,"context_line":"                                 else pipeline.SamplePipelineEndpoint)"},{"line_number":285,"context_line":"                listener \u003d messaging.get_batch_notification_listener("},{"line_number":286,"context_line":"                    transport,"},{"line_number":287,"context_line":"                    [oslo_messaging.Target(topic\u003dtopic)],"},{"line_number":288,"context_line":"                    [pipe_endpoint(self.ctxt, pipe)],"},{"line_number":289,"context_line":"                    batch_size\u003dcfg.CONF.notification.batch_size,"},{"line_number":290,"context_line":"                    batch_timeout\u003dcfg.CONF.notification.batch_timeout)"},{"line_number":291,"context_line":"                # NOTE(gordc): set single thread to process data sequentially"},{"line_number":292,"context_line":"                listener.start(override_pool_size\u003d1)"},{"line_number":293,"context_line":"                self.pipeline_listeners.append(listener)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_818463d4","line":290,"range":{"start_line":285,"start_character":15,"end_line":290,"end_character":70},"updated":"2016-03-17 10:37:03.000000000","message":"Why don\u0027t you  ignores batching just like the listener in fucntion _configure_main_queue_listeners(line 240)","commit_id":"23ed5c0f67e83ca4825ea247b5f6b3e84f25e4ff"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"95f8c2bf794ca01dea766f5ec20c7f3ba493ecea","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                pipe_endpoint \u003d (pipeline.EventPipelineEndpoint"},{"line_number":283,"context_line":"                                 if isinstance(pipe, pipeline.EventPipeline)"},{"line_number":284,"context_line":"                                 else pipeline.SamplePipelineEndpoint)"},{"line_number":285,"context_line":"                listener \u003d messaging.get_batch_notification_listener("},{"line_number":286,"context_line":"                    transport,"},{"line_number":287,"context_line":"                    [oslo_messaging.Target(topic\u003dtopic)],"},{"line_number":288,"context_line":"                    [pipe_endpoint(self.ctxt, pipe)],"},{"line_number":289,"context_line":"                    batch_size\u003dcfg.CONF.notification.batch_size,"},{"line_number":290,"context_line":"                    batch_timeout\u003dcfg.CONF.notification.batch_timeout)"},{"line_number":291,"context_line":"                # NOTE(gordc): set single thread to process data sequentially"},{"line_number":292,"context_line":"                listener.start(override_pool_size\u003d1)"},{"line_number":293,"context_line":"                self.pipeline_listeners.append(listener)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_54cdb783","line":290,"range":{"start_line":285,"start_character":15,"end_line":290,"end_character":70},"in_reply_to":"1af94dfe_818463d4","updated":"2016-03-18 11:30:18.000000000","message":"Because this part will do the batching on storage next, while the main_queue only passed messages from one messaging queue to another.","commit_id":"23ed5c0f67e83ca4825ea247b5f6b3e84f25e4ff"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"e536697865047fe273d7631444d3bd084471f805","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                    batch_size\u003dcfg.CONF.notification.batch_size,"},{"line_number":290,"context_line":"                    batch_timeout\u003dcfg.CONF.notification.batch_timeout)"},{"line_number":291,"context_line":"                # NOTE(gordc): set single thread to process data sequentially"},{"line_number":292,"context_line":"                listener.start(override_pool_size\u003d1)"},{"line_number":293,"context_line":"                self.pipeline_listeners.append(listener)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def stop(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afc51ec_1e2729cb","line":292,"updated":"2016-03-14 15:46:44.000000000","message":"This should be done only if batch is enabled.","commit_id":"23ed5c0f67e83ca4825ea247b5f6b3e84f25e4ff"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"95f8c2bf794ca01dea766f5ec20c7f3ba493ecea","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                    batch_size\u003dcfg.CONF.notification.batch_size,"},{"line_number":290,"context_line":"                    batch_timeout\u003dcfg.CONF.notification.batch_timeout)"},{"line_number":291,"context_line":"                # NOTE(gordc): set single thread to process data sequentially"},{"line_number":292,"context_line":"                listener.start(override_pool_size\u003d1)"},{"line_number":293,"context_line":"                self.pipeline_listeners.append(listener)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def stop(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_f40683cc","line":292,"in_reply_to":"3afc51ec_1e2729cb","updated":"2016-03-18 11:30:18.000000000","message":"Forget my comment, thank make sense to me.","commit_id":"23ed5c0f67e83ca4825ea247b5f6b3e84f25e4ff"}],"ceilometer/pipeline.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b417d53c4f6399267dddb80c7a5ee9bdb30429f9","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        ]"},{"line_number":129,"context_line":"        try:"},{"line_number":130,"context_line":"            with self.publish_context as p:"},{"line_number":131,"context_line":"                p(events)"},{"line_number":132,"context_line":"        except Exception:"},{"line_number":133,"context_line":"            if not cfg.CONF.notification.ack_on_event_error:"},{"line_number":134,"context_line":"                return oslo_messaging.NotificationResult.REQUEUE"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_a9916a49","line":131,"range":{"start_line":131,"start_character":16,"end_line":131,"end_character":25},"updated":"2016-03-17 17:49:54.000000000","message":"nit: I think events order is important as well, especially we have event alarms","commit_id":"23ed5c0f67e83ca4825ea247b5f6b3e84f25e4ff"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"34dbd09c49944d5c9153d1a11bdfaa4aeecfc232","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        ]"},{"line_number":129,"context_line":"        try:"},{"line_number":130,"context_line":"            with self.publish_context as p:"},{"line_number":131,"context_line":"                p(events)"},{"line_number":132,"context_line":"        except Exception:"},{"line_number":133,"context_line":"            if not cfg.CONF.notification.ack_on_event_error:"},{"line_number":134,"context_line":"                return oslo_messaging.NotificationResult.REQUEUE"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba0121b8_b21d0275","line":131,"range":{"start_line":131,"start_character":16,"end_line":131,"end_character":25},"in_reply_to":"1af94dfe_a9916a49","updated":"2016-04-01 15:03:00.000000000","message":"will do in followup","commit_id":"23ed5c0f67e83ca4825ea247b5f6b3e84f25e4ff"}],"releasenotes/notes/single-thread-pipelines-f9e6ac4b062747fe.yaml":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"35aad94db3caafaa0511b13d1cb27be05fe16b4f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Batching is enabled by default now when coordinated workers are enabled."},{"line_number":4,"context_line":"    Depending on load, it is recommended to scale out the number of"},{"line_number":5,"context_line":"    `pipeline_processing_queues` to improve distribution. `batch_size` should"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa7ab95a_8349a733","line":2,"updated":"2016-09-15 19:47:50.000000000","message":"This is cool, but this is not documentation. You can expect people deploying Ceilometer to read the whole list of changes in 2 years to understand the config options :)","commit_id":"fa217b9a86f1469b0ac0987eb10b4ce64698b429"}]}