)]}'
{"ceilometer/network/floatingip.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"a14a2b941fae33ae7930ead633331679de01bfce","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            # FIXME (flwang) Now Nova API /os-floating-ips can\u0027t provide those"},{"line_number":43,"context_line":"            # attributes were used by Ceilometer, such as project id, host."},{"line_number":44,"context_line":"            # In this fix, those attributes usage will be removed temporarily."},{"line_number":45,"context_line":"            # And they will be back after fix the Nova bug 1174802."},{"line_number":46,"context_line":"            yield counter.Counter("},{"line_number":47,"context_line":"                name\u003d\u0027ip.floating\u0027,"},{"line_number":48,"context_line":"                type\u003dcounter.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FmcE%3D","line":45,"updated":"2013-05-02 09:40:03.000000000","message":"Would it make sense to also log a warning here?","commit_id":"9e252b41ecdcb9c96f95d6b1bc3044f1215e51d4"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"bde9340186b9a264d85564744595928a77d5f387","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            # FIXME (flwang) Now Nova API /os-floating-ips can\u0027t provide those"},{"line_number":43,"context_line":"            # attributes were used by Ceilometer, such as project id, host."},{"line_number":44,"context_line":"            # In this fix, those attributes usage will be removed temporarily."},{"line_number":45,"context_line":"            # And they will be back after fix the Nova bug 1174802."},{"line_number":46,"context_line":"            yield counter.Counter("},{"line_number":47,"context_line":"                name\u003d\u0027ip.floating\u0027,"},{"line_number":48,"context_line":"                type\u003dcounter.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2Fl%2Fc%3D","line":45,"in_reply_to":"AAAAOn%2F%2FmNU%3D","updated":"2013-05-02 15:18:23.000000000","message":"Fair enough, though I guess it could be glommed onto the existing log message, e.g.:\n\n  self.LOG.info(\"FLOATING IP USAGE (anonymously metered due to lack of \"\n                \"user/project ID in nova notification) : %s\" % ip.ip)","commit_id":"9e252b41ecdcb9c96f95d6b1bc3044f1215e51d4"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"4bab293054b3d7cce3802e8f085bd3e447c510b6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            # FIXME (flwang) Now Nova API /os-floating-ips can\u0027t provide those"},{"line_number":43,"context_line":"            # attributes were used by Ceilometer, such as project id, host."},{"line_number":44,"context_line":"            # In this fix, those attributes usage will be removed temporarily."},{"line_number":45,"context_line":"            # And they will be back after fix the Nova bug 1174802."},{"line_number":46,"context_line":"            yield counter.Counter("},{"line_number":47,"context_line":"                name\u003d\u0027ip.floating\u0027,"},{"line_number":48,"context_line":"                type\u003dcounter.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FmNU%3D","line":45,"in_reply_to":"AAAAOn%2F%2FmcE%3D","updated":"2013-05-02 13:25:27.000000000","message":"Not sure it\u0027s worth flooding the log with something nobody can do something about.","commit_id":"9e252b41ecdcb9c96f95d6b1bc3044f1215e51d4"}],"tests/network/test_floatingip.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"a14a2b941fae33ae7930ead633331679de01bfce","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            ip \u003d mock.MagicMock()"},{"line_number":48,"context_line":"            ip.id \u003d i"},{"line_number":49,"context_line":"            ip.ip \u003d \u00271.1.1.%d\u0027 % i"},{"line_number":50,"context_line":"            ip.pool \u003d \"public\""},{"line_number":51,"context_line":"            ips.append(ip)"},{"line_number":52,"context_line":"        return ips"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2Fmbk%3D","line":50,"updated":"2013-05-02 09:40:03.000000000","message":"Total nitpick: probably an idea to standardize here on either single or double quotes (\u0027, \") for strings.","commit_id":"9e252b41ecdcb9c96f95d6b1bc3044f1215e51d4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"21da6c2ba7bb569b4ca89f00b61489124812fdf5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            ip \u003d mock.MagicMock()"},{"line_number":48,"context_line":"            ip.id \u003d i"},{"line_number":49,"context_line":"            ip.ip \u003d \u00271.1.1.%d\u0027 % i"},{"line_number":50,"context_line":"            ip.pool \u003d \"public\""},{"line_number":51,"context_line":"            ips.append(ip)"},{"line_number":52,"context_line":"        return ips"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FmJE%3D","line":50,"in_reply_to":"AAAAOn%2F%2FmNQ%3D","updated":"2013-05-02 14:09:28.000000000","message":"i don\u0027t believe pep8 warns about single vs double quotes. i\u0027ve seen both used in ceilometer. probably worth defining a preference -- the cleanup may be a nightmare though.\n\nbut yes, not a blocker.","commit_id":"9e252b41ecdcb9c96f95d6b1bc3044f1215e51d4"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"4bab293054b3d7cce3802e8f085bd3e447c510b6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            ip \u003d mock.MagicMock()"},{"line_number":48,"context_line":"            ip.id \u003d i"},{"line_number":49,"context_line":"            ip.ip \u003d \u00271.1.1.%d\u0027 % i"},{"line_number":50,"context_line":"            ip.pool \u003d \"public\""},{"line_number":51,"context_line":"            ips.append(ip)"},{"line_number":52,"context_line":"        return ips"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FmNQ%3D","line":50,"in_reply_to":"AAAAOn%2F%2Fmbk%3D","updated":"2013-05-02 13:25:27.000000000","message":"I though pep8 handled that. I think we use \"\" everywhere, let\u0027s stick with it (though it\u0027s not a blocker for me :)","commit_id":"9e252b41ecdcb9c96f95d6b1bc3044f1215e51d4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"21da6c2ba7bb569b4ca89f00b61489124812fdf5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    #     else:"},{"line_number":65,"context_line":"    #         assert False, \u0027Should have seen an error\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_get_counters__not_empty(self):"},{"line_number":68,"context_line":"        counters \u003d list(self.pollster.get_counters(self.manager))"},{"line_number":69,"context_line":"        self.assertEqual(len(counters), 3)"},{"line_number":70,"context_line":"        # It\u0027s necessary to verify all the attributes extracted by Nova"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FmJA%3D","line":67,"updated":"2013-05-02 14:09:28.000000000","message":"why the double underscore?","commit_id":"9e252b41ecdcb9c96f95d6b1bc3044f1215e51d4"}]}