)]}'
{"ceilometer/dispatcher/gnocchi.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"bc94ed73a8ed5c481fe2e4adc2c931fdeaa17baf","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class ResourcesDefinitionException(Exception):"},{"line_number":85,"context_line":"    def __init__(self, message, definition_cfg):"},{"line_number":86,"context_line":"        super(ResourcesDefinitionException, self).__init__(message)"},{"line_number":87,"context_line":"        self.definition_cfg \u003d definition_cfg"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def __str__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_d14ffe31","line":86,"updated":"2016-02-18 10:19:05.000000000","message":"Just use message here to build the string directly. as a super arg, that\u0027s all.","commit_id":"51aec331b01c9c4938ed78830e9503514f44264c"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"45eac812b5038d159d09aed82b4ee106a63759c4","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class ResourcesDefinitionException(Exception):"},{"line_number":85,"context_line":"    def __init__(self, message, definition_cfg):"},{"line_number":86,"context_line":"        super(ResourcesDefinitionException, self).__init__(message)"},{"line_number":87,"context_line":"        self.definition_cfg \u003d definition_cfg"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def __str__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_6a9b9066","line":86,"in_reply_to":"dae33548_d14ffe31","updated":"2016-02-18 12:40:13.000000000","message":"Done","commit_id":"51aec331b01c9c4938ed78830e9503514f44264c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d16957b899827d98a41a58582661ffdc0406f158","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def __init__(self, message, definition_cfg):"},{"line_number":86,"context_line":"        msg \u003d \u0027%s %s: %s\u0027 % (self.__class__.__name__, definition_cfg, message)"},{"line_number":87,"context_line":"        super(ResourcesDefinitionException, self).__init__(msg)"},{"line_number":88,"context_line":"        self.definition_cfg \u003d definition_cfg"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class ResourcesDefinition(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_e87e87e2","line":88,"updated":"2016-02-18 13:25:41.000000000","message":"do we still need this then?","commit_id":"8793561be7b2dfb941a9060484514d6122f7ee02"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3556cbf430644ab6b0d32df76ec22f0e54dc1c92","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def __init__(self, message, definition_cfg):"},{"line_number":86,"context_line":"        msg \u003d \u0027%s %s: %s\u0027 % (self.__class__.__name__, definition_cfg, message)"},{"line_number":87,"context_line":"        super(ResourcesDefinitionException, self).__init__(msg)"},{"line_number":88,"context_line":"        self.definition_cfg \u003d definition_cfg"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class ResourcesDefinition(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_32056745","line":88,"in_reply_to":"dae33548_1fccac87","updated":"2016-02-18 20:46:59.000000000","message":"darn, i did such a good job not being rude :P","commit_id":"8793561be7b2dfb941a9060484514d6122f7ee02"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"02153eab939bdb0099c405968b3919ac95878f95","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def __init__(self, message, definition_cfg):"},{"line_number":86,"context_line":"        msg \u003d \u0027%s %s: %s\u0027 % (self.__class__.__name__, definition_cfg, message)"},{"line_number":87,"context_line":"        super(ResourcesDefinitionException, self).__init__(msg)"},{"line_number":88,"context_line":"        self.definition_cfg \u003d definition_cfg"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class ResourcesDefinition(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_1fccac87","line":88,"in_reply_to":"dae33548_6bcf1156","updated":"2016-02-18 20:44:39.000000000","message":"Maybe we should keep the exception message simple and not include the definition content (it is long), and when we want the content then we can retrieve it?\n\n\nFor example: https://github.com/openstack/ceilometer/blob/master/ceilometer/declarative.py#L30 . (The attribute is not used anywhere neither.)\n\n\nThere is a similar exception in hardware/pollster/generic.py, it stores the message and has __str__ as well, so e.message and str(e) will get two different results (odd to me). e.message can be used for a shorter/simpler string, and there is an use case: https://github.com/openstack/ceilometer/blob/master/ceilometer/hardware/pollsters/generic.py#L226","commit_id":"8793561be7b2dfb941a9060484514d6122f7ee02"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"020d4d78131d257d146db60b7324364fd99cb33f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def __init__(self, message, definition_cfg):"},{"line_number":86,"context_line":"        msg \u003d \u0027%s %s: %s\u0027 % (self.__class__.__name__, definition_cfg, message)"},{"line_number":87,"context_line":"        super(ResourcesDefinitionException, self).__init__(msg)"},{"line_number":88,"context_line":"        self.definition_cfg \u003d definition_cfg"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class ResourcesDefinition(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_6bcf1156","line":88,"in_reply_to":"dae33548_e87e87e2","updated":"2016-02-18 13:38:24.000000000","message":"Don\u0027t ask a question with a -1, it\u0027s rude.\n\nBut I think we can keep it since if you catch this exception, having the ability to retrieve the def can be useful (or not, whatever).","commit_id":"8793561be7b2dfb941a9060484514d6122f7ee02"}]}