)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"110d08d5ea927b23226760e0e783489fcfe89e82","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable the Load Balancer v2 for events"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In this changeset, add new event definitions of loadbalancer, listener, and"},{"line_number":10,"context_line":"healthmonitor."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6db28a934bac4a1d83cc1b61d879dc2b16989b3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9aed3d3a_14018138","line":9,"updated":"2016-02-29 16:49:07.000000000","message":"I think follow message will be more clean:\n\"Next event definitions have been added in this change request:\n- loadbalancer\n- listener \n- healthmonitor\"  \n\nBut it\u0027s discussable and only my opinion.\nAnyway, please format commit messages lines to 72 characters maximum length according to the https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"ae26183bd837d4396494dfa3d9cea51644521333"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"e3165da4be9a15c814f77df7bb9425424caa7567","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable the Load Balancer v2 for events"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In this changeset, add new event definitions of loadbalancer, listener, and"},{"line_number":10,"context_line":"healthmonitor."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6db28a934bac4a1d83cc1b61d879dc2b16989b3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9aed3d3a_5a62ecd8","line":9,"in_reply_to":"9aed3d3a_14018138","updated":"2016-03-01 07:24:48.000000000","message":"Hi llya\n\nThanks for your review. For linjuan needs to take one week training. I will update it.\n\nThanks","commit_id":"ae26183bd837d4396494dfa3d9cea51644521333"}],"ceilometer/network/notifications.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"2e08d4104f1c041d7f1b99f652aa868bc45d404b","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    from neutron."},{"line_number":195,"context_line":"    \"\"\""},{"line_number":196,"context_line":"    resource_name \u003d \u0027healthmonitor\u0027"},{"line_number":197,"context_line":"    counter_name \u003d \u0027network.services.lb.healthmonitor\u0027"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"class Listener(NetworkNotificationBase, plugin_base.NonMetricNotificationBase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_76c49b5e","line":197,"range":{"start_line":197,"start_character":53,"end_line":197,"end_character":54},"updated":"2016-02-22 07:36:16.000000000","message":"why this counter_name is different than the registered entry_point name? This requires users to set network.services.lb.healthmonitor instead of network.services.lb.health_monitor_v2 in pipeline to make it work.","commit_id":"2479d9dafb4758f8679bf523f208afa48fc13fc5"},{"author":{"_account_id":18137,"name":"Xia Linjuan","email":"ljxiash@cn.ibm.com","username":"xialinjuan"},"change_message_id":"5e0020d13b9f659258ca2a21ed6cebeffb38b8fd","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    from neutron."},{"line_number":195,"context_line":"    \"\"\""},{"line_number":196,"context_line":"    resource_name \u003d \u0027healthmonitor\u0027"},{"line_number":197,"context_line":"    counter_name \u003d \u0027network.services.lb.healthmonitor\u0027"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"class Listener(NetworkNotificationBase, plugin_base.NonMetricNotificationBase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_37c5ee5a","line":197,"range":{"start_line":197,"start_character":53,"end_line":197,"end_character":54},"in_reply_to":"bae84128_76c49b5e","updated":"2016-02-22 08:41:11.000000000","message":"Thanks for your review! I will modify them and make the counter_name and registered entry_point name keep consistent.","commit_id":"2479d9dafb4758f8679bf523f208afa48fc13fc5"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ff0d46bfa247ed18bf38f7473bd874c3ac9ca37d","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    from neutron."},{"line_number":215,"context_line":"    \"\"\""},{"line_number":216,"context_line":"    resource_name \u003d \u0027loadbalancer\u0027"},{"line_number":217,"context_line":"    counter_name \u003d \u0027network.services.lb.loadbalancer\u0027"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"class Firewall(NetworkNotificationBase, plugin_base.NonMetricNotificationBase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_13c99759","line":217,"updated":"2016-02-23 13:34:06.000000000","message":"what exactly is the use case here? what are you trying to measure? volume is hardcoded to 1 so mean/median don\u0027t mean anything. count/sum probably don\u0027t mean anything either so why do we need this a metric.","commit_id":"f92b58b1573bb154f6952c0d539edda0cdb85891"}],"ceilometer/tests/unit/network/test_notifications.py":[{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"2f1b9a265889af59ca16001821fea7547aebc75d","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"        self.assertEqual(2, len(samples))"},{"line_number":1278,"context_line":"        self.assertEqual(\"network.services.lb.pool\", samples[0].name)"},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"    def test_vip_create(self):"},{"line_number":1281,"context_line":"        v \u003d notifications.Vip(mock.Mock())"},{"line_number":1282,"context_line":"        samples \u003d list(v.process_notification(NOTIFICATION_VIP_CREATE))"},{"line_number":1283,"context_line":"        self.assertEqual(2, len(samples))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_6a47a14b","side":"PARENT","line":1280,"range":{"start_line":1280,"start_character":4,"end_line":1280,"end_character":30},"updated":"2016-02-21 14:44:35.000000000","message":"Hi Lin Juan\n\nWe should not remove the lbaas v1 support in this release. So we can not remove the corresponding test code.","commit_id":"d3c485c0eea992d56fe59a47d923b442785d2d5c"}],"etc/ceilometer/event_definitions.yaml":[{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"35eb85c620c394b41b3892189c4ae14e8a67ebe2","unresolved":false,"context_lines":[{"line_number":243,"context_line":"      fields: _context_user_id"},{"line_number":244,"context_line":"    project_id:"},{"line_number":245,"context_line":"      fields: _context_tenant"},{"line_number":246,"context_line":"- event_type: [\u0027network.*\u0027, \u0027subnet.*\u0027, \u0027port.*\u0027, \u0027router.*\u0027, \u0027floatingip.*\u0027, \u0027pool.*\u0027, \u0027vip.*\u0027, \u0027member.*\u0027, \u0027healthmonitor.*\u0027, \u0027listener.*\u0027, \u0027loadbalancer.*\u0027, \u0027firewall.*\u0027, \u0027firewall_policy.*\u0027, \u0027firewall_rule.*\u0027, \u0027vpnservice.*\u0027, \u0027ipsecpolicy.*\u0027, \u0027ikepolicy.*\u0027, \u0027ipsec_site_connection.*\u0027]"},{"line_number":247,"context_line":"  traits: \u0026network_traits"},{"line_number":248,"context_line":"    user_id:"},{"line_number":249,"context_line":"      fields: _context_user_id"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bae84128_e3396c43","line":246,"range":{"start_line":246,"start_character":2,"end_line":246,"end_character":12},"updated":"2016-02-19 09:08:32.000000000","message":"Hi Lin Juan\n\nI think we also need to support the LBaaS v1 in this release.\n\nThanks","commit_id":"06228c7a0437aedae95ad5d43cc2d800555aa92b"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"110d08d5ea927b23226760e0e783489fcfe89e82","unresolved":false,"context_lines":[{"line_number":298,"context_line":"  traits:"},{"line_number":299,"context_line":"    \u003c\u003c: *network_traits"},{"line_number":300,"context_line":"    resource_id:"},{"line_number":301,"context_line":"      fields: [\u0027payload.healthmonitor.id\u0027, \u0027payload.id\u0027]"},{"line_number":302,"context_line":"- event_type: listener.*"},{"line_number":303,"context_line":"  traits:"},{"line_number":304,"context_line":"    \u003c\u003c: *network_traits"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9aed3d3a_942c719a","line":301,"updated":"2016-02-29 16:49:07.000000000","message":"Are both types of events generated: `health_monitor.*` and `healthmonitor.*` ?","commit_id":"ae26183bd837d4396494dfa3d9cea51644521333"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"e3165da4be9a15c814f77df7bb9425424caa7567","unresolved":false,"context_lines":[{"line_number":298,"context_line":"  traits:"},{"line_number":299,"context_line":"    \u003c\u003c: *network_traits"},{"line_number":300,"context_line":"    resource_id:"},{"line_number":301,"context_line":"      fields: [\u0027payload.healthmonitor.id\u0027, \u0027payload.id\u0027]"},{"line_number":302,"context_line":"- event_type: listener.*"},{"line_number":303,"context_line":"  traits:"},{"line_number":304,"context_line":"    \u003c\u003c: *network_traits"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9aed3d3a_faadc0e9","line":301,"in_reply_to":"9aed3d3a_942c719a","updated":"2016-03-01 07:24:48.000000000","message":"Hi llya\n\nYes, health_monitor is for LBaaS v1 and healthmonitor is for LBaaS v2.\n\nThanks","commit_id":"ae26183bd837d4396494dfa3d9cea51644521333"}],"setup.cfg":[{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"35eb85c620c394b41b3892189c4ae14e8a67ebe2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    network.services.lb.vip \u003d ceilometer.network.notifications:Vip"},{"line_number":45,"context_line":"    network.services.lb.member \u003d ceilometer.network.notifications:Member"},{"line_number":46,"context_line":"    network.services.lb.health_monitor \u003d ceilometer.network.notifications:HealthMonitor"},{"line_number":47,"context_line":"    network.services.lb.listener \u003d ceilometer.network.notifications:Listener"},{"line_number":48,"context_line":"    network.services.lb.loadbalancer \u003d ceilometer.network.notifications:LoadBalancer"},{"line_number":49,"context_line":"    network.services.firewall \u003d ceilometer.network.notifications:Firewall"},{"line_number":50,"context_line":"    network.services.firewall.policy \u003d ceilometer.network.notifications:FirewallPolicy"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"bae84128_c378a8fb","line":47,"updated":"2016-02-19 09:08:32.000000000","message":"Hi Lin Juan\n\nI think we need to support the LBaaS v1 in this release.\n\nThanks","commit_id":"06228c7a0437aedae95ad5d43cc2d800555aa92b"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"2e08d4104f1c041d7f1b99f652aa868bc45d404b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    network.services.lb.vip \u003d ceilometer.network.notifications:Vip"},{"line_number":45,"context_line":"    network.services.lb.member \u003d ceilometer.network.notifications:Member"},{"line_number":46,"context_line":"    network.services.lb.health_monitor \u003d ceilometer.network.notifications:HealthMonitor"},{"line_number":47,"context_line":"    network.services.lb.health_monitor_v2 \u003d ceilometer.network.notifications:HealthMonitorV2"},{"line_number":48,"context_line":"    network.services.lb.listener \u003d ceilometer.network.notifications:Listener"},{"line_number":49,"context_line":"    network.services.lb.loadbalancer \u003d ceilometer.network.notifications:LoadBalancer"},{"line_number":50,"context_line":"    network.services.firewall \u003d ceilometer.network.notifications:Firewall"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"bae84128_b6d62325","line":47,"range":{"start_line":47,"start_character":77,"end_line":47,"end_character":92},"updated":"2016-02-22 07:36:16.000000000","message":"Though for notifications, we only check the sample name against pipeline configuration when publishing, it would be nice to have the final sample name match with the entry_points name here.","commit_id":"2479d9dafb4758f8679bf523f208afa48fc13fc5"}]}