)]}'
{"tests/test_bin.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"fd8c29bb27c3bd17e79bd925ba174a45fdb40fec","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            try:"},{"line_number":100,"context_line":"                r, c \u003d self.http.request(url, \u0027GET\u0027)"},{"line_number":101,"context_line":"            except socket.error:"},{"line_number":102,"context_line":"                time.sleep(.5)"},{"line_number":103,"context_line":"                self.assertEqual(self.subp.poll(), None)"},{"line_number":104,"context_line":"            else:"},{"line_number":105,"context_line":"                return r, c"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2Fgo%3D","line":102,"updated":"2013-05-15 11:42:25.000000000","message":"Would it be better to increase the number of iterations (from say 10 to 15), instead of extending the individual sleeps?","commit_id":"dc835ed35ea972194f5d63dea82cf521056bbdd1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"030022d72ac81f19842d587438ada0266a96f187","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            try:"},{"line_number":100,"context_line":"                r, c \u003d self.http.request(url, \u0027GET\u0027)"},{"line_number":101,"context_line":"            except socket.error:"},{"line_number":102,"context_line":"                time.sleep(.5)"},{"line_number":103,"context_line":"                self.assertEqual(self.subp.poll(), None)"},{"line_number":104,"context_line":"            else:"},{"line_number":105,"context_line":"                return r, c"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2FPo%3D","line":102,"in_reply_to":"AAAAO3%2F%2F%2Fgo%3D","updated":"2013-05-15 14:00:54.000000000","message":"I agree. A longer loop with a shorter sleep should make the test run faster.","commit_id":"dc835ed35ea972194f5d63dea82cf521056bbdd1"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"480cc420726f1000dffb96b3e5b49dafea77e778","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                self.assertEqual(self.subp.poll(), None)"},{"line_number":104,"context_line":"            else:"},{"line_number":105,"context_line":"                return r, c"},{"line_number":106,"context_line":"        return (None, None)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_v1(self):"},{"line_number":109,"context_line":"        response, content \u003d self.get_response(\u0027v1/meters\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FUu4%3D","line":106,"updated":"2013-05-14 17:51:32.000000000","message":"is this return to handle timeout clause? should we just assert something here instead (unless this is useful in another test)","commit_id":"dc835ed35ea972194f5d63dea82cf521056bbdd1"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a81138121c539dd8390bd06461f485a5f27390d7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                self.assertEqual(self.subp.poll(), None)"},{"line_number":104,"context_line":"            else:"},{"line_number":105,"context_line":"                return r, c"},{"line_number":106,"context_line":"        return (None, None)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_v1(self):"},{"line_number":109,"context_line":"        response, content \u003d self.get_response(\u0027v1/meters\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2FBI%3D","line":106,"in_reply_to":"AAAAO3%2F%2F%2FP0%3D","updated":"2013-05-15 15:19:00.000000000","message":"agreed. brought it up because if tests don\u0027t check \u0027r\u0027 explicitly, it may seem like a response.  that said, it doesn\u0027t affect the tests that use it so works for me.","commit_id":"dc835ed35ea972194f5d63dea82cf521056bbdd1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"030022d72ac81f19842d587438ada0266a96f187","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                self.assertEqual(self.subp.poll(), None)"},{"line_number":104,"context_line":"            else:"},{"line_number":105,"context_line":"                return r, c"},{"line_number":106,"context_line":"        return (None, None)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_v1(self):"},{"line_number":109,"context_line":"        response, content \u003d self.get_response(\u0027v1/meters\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2FP0%3D","line":106,"in_reply_to":"AAAAOn%2F%2FUu4%3D","updated":"2013-05-15 14:00:54.000000000","message":"Deciding if lack of a response is an error should be up to the test, not this code, so I think it\u0027s fine to return a sentinel value.","commit_id":"dc835ed35ea972194f5d63dea82cf521056bbdd1"}]}