)]}'
{"ceilometer/event/storage/impl_mongodb.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3f78d7b40dce6c342f48b4ea458d2154d49c5893","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                                   name\u003d\u0027dft_message_id_idx\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        ttl \u003d cfg.CONF.database.event_time_to_live"},{"line_number":75,"context_line":"        impl_mongodb.Connection.update_ttl(\u0027event_ttl\u0027, \u0027timestamp\u0027,"},{"line_number":76,"context_line":"                                           self.db.event, ttl)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def clear(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_9b50750c","line":75,"updated":"2016-03-15 13:40:57.000000000","message":"why are we changing the method definition?","commit_id":"24ccb7ea25fdad1b992dde2fe628ee8fcc020db0"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"b5eafc6972ed7328eccb0b917f4305f187c72584","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                                   name\u003d\u0027dft_message_id_idx\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        ttl \u003d cfg.CONF.database.event_time_to_live"},{"line_number":75,"context_line":"        impl_mongodb.Connection.update_ttl(\u0027event_ttl\u0027, \u0027timestamp\u0027,"},{"line_number":76,"context_line":"                                           self.db.event, ttl)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def clear(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_cfd8ac20","line":75,"in_reply_to":"3afc51ec_9b50750c","updated":"2016-03-21 15:09:29.000000000","message":"we change it because now we will use update_ttl not only for using ttl feature but also to indexes timestamp field if ttl was not set in configure file.","commit_id":"24ccb7ea25fdad1b992dde2fe628ee8fcc020db0"}],"ceilometer/event/storage/pymongo_base.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3f78d7b40dce6c342f48b4ea458d2154d49c5893","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        q \u003d pymongo_utils.make_events_query_from_filter(event_filter)"},{"line_number":84,"context_line":"        if limit is not None:"},{"line_number":85,"context_line":"            results \u003d self.db.event.find("},{"line_number":86,"context_line":"                q, limit\u003dlimit, sort\u003d[(\u0027timestamp\u0027, pymongo.ASCENDING)]"},{"line_number":87,"context_line":"            )"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            results \u003d self.db.event.find("}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_db0cbd3d","line":86,"updated":"2016-03-15 13:40:57.000000000","message":"what does this change have to do with indices?","commit_id":"24ccb7ea25fdad1b992dde2fe628ee8fcc020db0"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"b5eafc6972ed7328eccb0b917f4305f187c72584","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        q \u003d pymongo_utils.make_events_query_from_filter(event_filter)"},{"line_number":84,"context_line":"        if limit is not None:"},{"line_number":85,"context_line":"            results \u003d self.db.event.find("},{"line_number":86,"context_line":"                q, limit\u003dlimit, sort\u003d[(\u0027timestamp\u0027, pymongo.ASCENDING)]"},{"line_number":87,"context_line":"            )"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            results \u003d self.db.event.find("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_0fcc6434","line":86,"in_reply_to":"3afc51ec_db0cbd3d","updated":"2016-03-21 15:09:29.000000000","message":"this change have to reuse existence behavior of find method for get_events method with default DESCENDING order of timestamp field in ttl_update method","commit_id":"24ccb7ea25fdad1b992dde2fe628ee8fcc020db0"}],"ceilometer/storage/impl_mongodb.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3f78d7b40dce6c342f48b4ea458d2154d49c5893","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        self.db.meter.create_index([(\u0027counter_name\u0027, pymongo.ASCENDING)],"},{"line_number":224,"context_line":"                                   name\u003d\u0027dft_meter_idx\u0027)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        self.db.meter.create_index([(\u0027timestamp\u0027, pymongo.DESCENDING)],"},{"line_number":227,"context_line":"                                   name\u003d\u0027timestamp_idx\u0027)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        # NOTE(ityaptin) This indexes covers get_resource requests sorting"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_90db821b","side":"PARENT","line":226,"updated":"2016-03-15 13:40:57.000000000","message":"you need to remove it from existing environments","commit_id":"bbc3a9ea65ca44de2884534d233c64a0c83742ce"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"b5eafc6972ed7328eccb0b917f4305f187c72584","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        self.db.meter.create_index([(\u0027counter_name\u0027, pymongo.ASCENDING)],"},{"line_number":224,"context_line":"                                   name\u003d\u0027dft_meter_idx\u0027)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        self.db.meter.create_index([(\u0027timestamp\u0027, pymongo.DESCENDING)],"},{"line_number":227,"context_line":"                                   name\u003d\u0027timestamp_idx\u0027)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        # NOTE(ityaptin) This indexes covers get_resource requests sorting"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_f2b91730","side":"PARENT","line":226,"in_reply_to":"1af94dfe_90db821b","updated":"2016-03-21 15:09:29.000000000","message":"Done","commit_id":"bbc3a9ea65ca44de2884534d233c64a0c83742ce"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3f78d7b40dce6c342f48b4ea458d2154d49c5893","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                                      name\u003d\u0027dft_resource_user_idx\u0027)"},{"line_number":234,"context_line":"        self.db.resource.create_index([(\u0027project_id\u0027, pymongo.DESCENDING)],"},{"line_number":235,"context_line":"                                      name\u003d\u0027dft_resource_project_idx\u0027)"},{"line_number":236,"context_line":"        self.db.resource.create_index([(\u0027last_sample_timestamp\u0027,"},{"line_number":237,"context_line":"                                        pymongo.DESCENDING)],"},{"line_number":238,"context_line":"                                      name\u003d\u0027timestamp_idx\u0027)"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_d0034a75","side":"PARENT","line":236,"updated":"2016-03-15 13:40:57.000000000","message":"same","commit_id":"bbc3a9ea65ca44de2884534d233c64a0c83742ce"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"b5eafc6972ed7328eccb0b917f4305f187c72584","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                                      name\u003d\u0027dft_resource_user_idx\u0027)"},{"line_number":234,"context_line":"        self.db.resource.create_index([(\u0027project_id\u0027, pymongo.DESCENDING)],"},{"line_number":235,"context_line":"                                      name\u003d\u0027dft_resource_project_idx\u0027)"},{"line_number":236,"context_line":"        self.db.resource.create_index([(\u0027last_sample_timestamp\u0027,"},{"line_number":237,"context_line":"                                        pymongo.DESCENDING)],"},{"line_number":238,"context_line":"                                      name\u003d\u0027timestamp_idx\u0027)"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_d2b6933c","side":"PARENT","line":236,"in_reply_to":"1af94dfe_d0034a75","updated":"2016-03-21 15:09:29.000000000","message":"Done","commit_id":"bbc3a9ea65ca44de2884534d233c64a0c83742ce"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3f78d7b40dce6c342f48b4ea458d2154d49c5893","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        if ttl is None:"},{"line_number":177,"context_line":"            if ttl_index_name in indexes:"},{"line_number":178,"context_line":"                return"},{"line_number":179,"context_line":"            return coll.create_index([(index_field, pymongo.DESCENDING)],"},{"line_number":180,"context_line":"                                     name\u003dttl_index_name)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        if ttl_index_name in indexes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_b0cb1e1e","line":179,"updated":"2016-03-15 13:40:57.000000000","message":"i don\u0027t understand this part. why would a ttl\u003dNone result in index with ttl_index_name?","commit_id":"24ccb7ea25fdad1b992dde2fe628ee8fcc020db0"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"b5eafc6972ed7328eccb0b917f4305f187c72584","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        if ttl is None:"},{"line_number":177,"context_line":"            if ttl_index_name in indexes:"},{"line_number":178,"context_line":"                return"},{"line_number":179,"context_line":"            return coll.create_index([(index_field, pymongo.DESCENDING)],"},{"line_number":180,"context_line":"                                     name\u003dttl_index_name)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        if ttl_index_name in indexes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_0f4f4493","line":179,"in_reply_to":"1af94dfe_b0cb1e1e","updated":"2016-03-21 15:09:29.000000000","message":"in MongoDB we cannot indexing one field twice, but we do with different sorting order. With this change we will have only one index for timestamp field and ttl feature will be add for that index only if ttl parameter was set in config file","commit_id":"24ccb7ea25fdad1b992dde2fe628ee8fcc020db0"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3f78d7b40dce6c342f48b4ea458d2154d49c5893","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                pass"},{"line_number":195,"context_line":"            coll.drop_index(ttl_index_name)"},{"line_number":196,"context_line":"        if ttl \u003c\u003d 0:"},{"line_number":197,"context_line":"            return coll.create_index([(index_field, pymongo.DESCENDING)],"},{"line_number":198,"context_line":"                                     name\u003dttl_index_name)"},{"line_number":199,"context_line":"        coll.create_index([(index_field, pymongo.DESCENDING)],"},{"line_number":200,"context_line":"                          expireAfterSeconds\u003dttl,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_4492df58","line":197,"updated":"2016-03-15 13:40:57.000000000","message":"this seems to do something very similar to \u0027ttl is None\u0027. why is it a separate condition?","commit_id":"24ccb7ea25fdad1b992dde2fe628ee8fcc020db0"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"b5eafc6972ed7328eccb0b917f4305f187c72584","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                pass"},{"line_number":195,"context_line":"            coll.drop_index(ttl_index_name)"},{"line_number":196,"context_line":"        if ttl \u003c\u003d 0:"},{"line_number":197,"context_line":"            return coll.create_index([(index_field, pymongo.DESCENDING)],"},{"line_number":198,"context_line":"                                     name\u003dttl_index_name)"},{"line_number":199,"context_line":"        coll.create_index([(index_field, pymongo.DESCENDING)],"},{"line_number":200,"context_line":"                          expireAfterSeconds\u003dttl,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_329b8fcb","line":197,"in_reply_to":"1af94dfe_4492df58","updated":"2016-03-21 15:09:29.000000000","message":"it is, but this condition is need to be add if config file set ttl \u003d 0 or -1 and ttl feature was not set earlier. Without this condition we will set expireAfterSeconds to 0 or -1 and all our data will be erased immediately after inserting","commit_id":"24ccb7ea25fdad1b992dde2fe628ee8fcc020db0"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"fcfcb7180bd7a52c7b59bb2af23c9ef56bdbb515","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.upgrade()"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @staticmethod"},{"line_number":167,"context_line":"    def update_ttl(ttl_index_name, index_field, coll, ttl\u003dNone):"},{"line_number":168,"context_line":"        \"\"\"Update or create time_to_live indexes."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        :param ttl_index_name: name of the index we want to update or create."}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_ebcf037d","line":167,"range":{"start_line":167,"start_character":8,"end_line":167,"end_character":64},"updated":"2016-04-19 08:04:05.000000000","message":"this function sometimes returns None sometimes return the result of create_index. But we never use the return value, can we just remove return value, or keep it consistent, which means add a return in line 199?","commit_id":"9b57fe354dada9bbdaeb5786f0313850a597b803"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"fefe39cffcd8daa465fd58c24cd9bfce5e83a8c5","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.upgrade()"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @staticmethod"},{"line_number":167,"context_line":"    def update_ttl(ttl_index_name, index_field, coll, ttl\u003dNone):"},{"line_number":168,"context_line":"        \"\"\"Update or create time_to_live indexes."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        :param ttl_index_name: name of the index we want to update or create."}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_c96f3e90","line":167,"range":{"start_line":167,"start_character":8,"end_line":167,"end_character":64},"in_reply_to":"1a122d0e_ebcf037d","updated":"2016-05-17 12:30:40.000000000","message":"Done","commit_id":"9b57fe354dada9bbdaeb5786f0313850a597b803"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"fcfcb7180bd7a52c7b59bb2af23c9ef56bdbb515","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                        \u0027collMod\u0027, coll.name,"},{"line_number":192,"context_line":"                        index\u003d{\u0027keyPattern\u0027: {index_field: pymongo.DESCENDING},"},{"line_number":193,"context_line":"                               \u0027expireAfterSeconds\u0027: ttl})"},{"line_number":194,"context_line":"                pass"},{"line_number":195,"context_line":"            coll.drop_index(ttl_index_name)"},{"line_number":196,"context_line":"        if ttl \u003c\u003d 0:"},{"line_number":197,"context_line":"            return coll.create_index([(index_field, pymongo.DESCENDING)],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_eb42633d","line":194,"range":{"start_line":194,"start_character":16,"end_line":194,"end_character":20},"updated":"2016-04-19 08:04:05.000000000","message":"the two branches of third level (!) if both return so the pass is not needed, or you can use else at second level to make it more readable","commit_id":"9b57fe354dada9bbdaeb5786f0313850a597b803"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"fefe39cffcd8daa465fd58c24cd9bfce5e83a8c5","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                        \u0027collMod\u0027, coll.name,"},{"line_number":192,"context_line":"                        index\u003d{\u0027keyPattern\u0027: {index_field: pymongo.DESCENDING},"},{"line_number":193,"context_line":"                               \u0027expireAfterSeconds\u0027: ttl})"},{"line_number":194,"context_line":"                pass"},{"line_number":195,"context_line":"            coll.drop_index(ttl_index_name)"},{"line_number":196,"context_line":"        if ttl \u003c\u003d 0:"},{"line_number":197,"context_line":"            return coll.create_index([(index_field, pymongo.DESCENDING)],"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_a9563acb","line":194,"range":{"start_line":194,"start_character":16,"end_line":194,"end_character":20},"in_reply_to":"1a122d0e_eb42633d","updated":"2016-05-17 12:30:40.000000000","message":"It was something odd, removed.","commit_id":"9b57fe354dada9bbdaeb5786f0313850a597b803"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"a1a39644264cb817d84ab4806463aa3a670cbf39","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.upgrade()"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @staticmethod"},{"line_number":167,"context_line":"    def update_ttl(ttl_index_name, index_field, coll, ttl\u003dNone):"},{"line_number":168,"context_line":"        \"\"\"Update or create time_to_live indexes."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        :param ttl_index_name: name of the index we want to update or create."}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_2a6409b7","line":167,"range":{"start_line":167,"start_character":54,"end_line":167,"end_character":62},"updated":"2016-05-23 02:57:35.000000000","message":"I know ttl can be None, but is there anywhere call this method without ttl? I couldn\u0027t find one.\n\nso actually it is a positional argument instead of optional.\n\nand if in future there is a case without ttl, then the method name is some kind of misleading","commit_id":"67cbcc6ac838448749ff38b69af1c29d61ed365f"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"d5bf746dc4f1e322e5c1b534471b73f2b3f51fd3","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.upgrade()"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @staticmethod"},{"line_number":167,"context_line":"    def update_ttl(ttl_index_name, index_field, coll, ttl\u003dNone):"},{"line_number":168,"context_line":"        \"\"\"Update or create time_to_live indexes."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        :param ttl_index_name: name of the index we want to update or create."}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_b9a24eac","line":167,"range":{"start_line":167,"start_character":54,"end_line":167,"end_character":62},"in_reply_to":"bab6814e_2a6409b7","updated":"2016-05-26 08:58:00.000000000","message":"Your are right update_ttl method is not used without ttl parameter. will do a little improvement","commit_id":"67cbcc6ac838448749ff38b69af1c29d61ed365f"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"819dbbae5f58c1c2a5ec6c67923eed1246681827","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                    return coll.create_index([(index_field,"},{"line_number":188,"context_line":"                                               pymongo.DESCENDING)],"},{"line_number":189,"context_line":"                                             name\u003dttl_index_name)"},{"line_number":190,"context_line":"                elif indexes[ttl_index_name][\u0027key\u0027][0][1] \u003d\u003d -1:"},{"line_number":191,"context_line":"                    return coll.database.command("},{"line_number":192,"context_line":"                        \u0027collMod\u0027, coll.name,"},{"line_number":193,"context_line":"                        index\u003d{\u0027keyPattern\u0027: {index_field: pymongo.DESCENDING},"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_bab9a37b","line":190,"range":{"start_line":190,"start_character":21,"end_line":190,"end_character":57},"updated":"2016-05-31 13:56:08.000000000","message":"maybe add a note or doc link to explain what is it?","commit_id":"817e9626998580de303abdd7dca138ed7a7e6ca3"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4691e4de1a5971552ca9fa1e3f92df2dcb6301a3","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        self.upgrade()"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @staticmethod"},{"line_number":168,"context_line":"    def update_ttl(ttl_index_name, index_field, coll, ttl):"},{"line_number":169,"context_line":"        \"\"\"Update or create time_to_live indexes."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        :param ttl_index_name: name of the index we want to update or create."}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_6880a38c","line":168,"updated":"2016-08-02 12:29:59.000000000","message":"i imagine this def change was unnecessary","commit_id":"3a7d8d1180f0cc9122775aeb02b845a41b3e3c22"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4691e4de1a5971552ca9fa1e3f92df2dcb6301a3","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            if indexes[ttl_index_name].get(\u0027expireAfterSeconds\u0027):"},{"line_number":185,"context_line":"                if ttl \u003c\u003d 0:"},{"line_number":186,"context_line":"                    coll.drop_index(ttl_index_name)"},{"line_number":187,"context_line":"                    return coll.create_index([(index_field,"},{"line_number":188,"context_line":"                                               pymongo.DESCENDING)],"},{"line_number":189,"context_line":"                                             name\u003dttl_index_name)"},{"line_number":190,"context_line":"                elif indexes[ttl_index_name][\u0027key\u0027][0][1] \u003d\u003d -1:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_cbea69ac","line":187,"updated":"2016-08-02 12:29:59.000000000","message":"this part could just be done above no?","commit_id":"3a7d8d1180f0cc9122775aeb02b845a41b3e3c22"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4691e4de1a5971552ca9fa1e3f92df2dcb6301a3","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                               \u0027expireAfterSeconds\u0027: ttl})"},{"line_number":195,"context_line":"            coll.drop_index(ttl_index_name)"},{"line_number":196,"context_line":"        if ttl \u003c\u003d 0:"},{"line_number":197,"context_line":"            return coll.create_index([(index_field, pymongo.DESCENDING)],"},{"line_number":198,"context_line":"                                     name\u003dttl_index_name)"},{"line_number":199,"context_line":"        return coll.create_index([(index_field, pymongo.DESCENDING)],"},{"line_number":200,"context_line":"                                 expireAfterSeconds\u003dttl,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_ab2a952d","line":197,"updated":"2016-08-02 12:29:59.000000000","message":"this could be part of if not ttl: code no?","commit_id":"3a7d8d1180f0cc9122775aeb02b845a41b3e3c22"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4691e4de1a5971552ca9fa1e3f92df2dcb6301a3","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        if ttl \u003c\u003d 0:"},{"line_number":197,"context_line":"            return coll.create_index([(index_field, pymongo.DESCENDING)],"},{"line_number":198,"context_line":"                                     name\u003dttl_index_name)"},{"line_number":199,"context_line":"        return coll.create_index([(index_field, pymongo.DESCENDING)],"},{"line_number":200,"context_line":"                                 expireAfterSeconds\u003dttl,"},{"line_number":201,"context_line":"                                 name\u003dttl_index_name)"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_2b4a2528","line":199,"updated":"2016-08-02 12:29:59.000000000","message":"why are we returning something?","commit_id":"3a7d8d1180f0cc9122775aeb02b845a41b3e3c22"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"820cfcd176ab2cfa99c0565f73a0ec13afa35b50","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        for index_name in resource_idxs:"},{"line_number":227,"context_line":"            if index_name in (\u0027resource_user_project_timestamp\u0027,"},{"line_number":228,"context_line":"                              \u0027timestamp_idx\u0027):"},{"line_number":229,"context_line":"                self.db.resource.drop_index(index_name)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        self.db.meter.create_index([(\u0027resource_id\u0027, pymongo.ASCENDING)],"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_3f57bb03","line":228,"range":{"start_line":228,"start_character":31,"end_line":228,"end_character":44},"updated":"2016-08-03 13:35:00.000000000","message":"I think this should be \u0027last_sample_timestamp_idx\u0027, see comment in the previous patch.","commit_id":"3a7d8d1180f0cc9122775aeb02b845a41b3e3c22"}]}