)]}'
{"ceilometer/compute/pollsters.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"4281430fe06e1618cb034b215b9c30f5e1c23f64","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        if vnic_data.fref is not None:"},{"line_number":217,"context_line":"            rid \u003d vnic_data.fref"},{"line_number":218,"context_line":"        else:"},{"line_number":219,"context_line":"            rid \u003d \"%s-%s-%s\" % (instance_name, instance.id, vnic_data.name)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        return counter.Counter("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F0KU%3D","line":218,"updated":"2013-05-22 13:18:19.000000000","message":"You could move instance_name computing here.","commit_id":"9722df11c829106fbb74cdb553a230ae4d5b8ca7"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"6d7beded6612075ee176f9b9d48069c84fc002c4","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        if vnic_data.fref is not None:"},{"line_number":217,"context_line":"            rid \u003d vnic_data.fref"},{"line_number":218,"context_line":"        else:"},{"line_number":219,"context_line":"            rid \u003d \"%s-%s-%s\" % (instance_name, instance.id, vnic_data.name)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        return counter.Counter("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F0Dk%3D","line":218,"in_reply_to":"AAAAPH%2F%2F0Fo%3D","updated":"2013-05-22 14:01:51.000000000","message":"ha ok, it\u0027s better indeed!","commit_id":"9722df11c829106fbb74cdb553a230ae4d5b8ca7"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"9c62f6f5741725a8a7b285ab849d57553824c5ee","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        if vnic_data.fref is not None:"},{"line_number":217,"context_line":"            rid \u003d vnic_data.fref"},{"line_number":218,"context_line":"        else:"},{"line_number":219,"context_line":"            rid \u003d \"%s-%s-%s\" % (instance_name, instance.id, vnic_data.name)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        return counter.Counter("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F0Fo%3D","line":218,"in_reply_to":"AAAAPH%2F%2F0Gs%3D","updated":"2013-05-22 13:50:48.000000000","message":"No, I mean moving instance_name \u003d from the first line of this function to this else, since this seems the only place this variable is used.","commit_id":"9722df11c829106fbb74cdb553a230ae4d5b8ca7"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"1f6a2f335a58638f40108cdcd8127aff796e4aeb","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        if vnic_data.fref is not None:"},{"line_number":217,"context_line":"            rid \u003d vnic_data.fref"},{"line_number":218,"context_line":"        else:"},{"line_number":219,"context_line":"            rid \u003d \"%s-%s-%s\" % (instance_name, instance.id, vnic_data.name)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        return counter.Counter("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F0Gs%3D","line":218,"in_reply_to":"AAAAPH%2F%2F0KU%3D","updated":"2013-05-22 13:43:45.000000000","message":"do you mean remove instance_name ?","commit_id":"9722df11c829106fbb74cdb553a230ae4d5b8ca7"}],"tests/compute/test_pollsters.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"347425c4ac1c85545aa1892fee85b3f01663a9c3","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            self.assertEquals(match[0].type, \u0027cumulative\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        for rid in [c.resource_id for c in counters]:"},{"line_number":158,"context_line":"            self.assertIsNotNone(rid)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        _verify_vnic_metering(\u0027network.incoming.bytes\u0027, \u002710.0.0.2\u0027, 1L)"},{"line_number":161,"context_line":"        _verify_vnic_metering(\u0027network.incoming.bytes\u0027, \u0027192.168.0.3\u0027, 5L)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F214%3D","line":158,"updated":"2013-05-21 15:39:16.000000000","message":"Could you expand this test to look for the actual expected values?","commit_id":"fb0a82232a6b79a14621a6c0c64ac027c1679049"}]}