)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"6e234ca433e4c1e57fe21810cc2e0891677af6ee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\u0027ceilometer-polling\u0027 should fail with no valid pollsters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The command \u0027ceilometer-polling --pollster-list\u0027 should fail with"},{"line_number":10,"context_line":"no invalid pollsters."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When executing the command \u0027ceilometer-polling --pollster-list\u0027 with"},{"line_number":13,"context_line":"the wrong pollster like aaa, it still executes and no error will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_06ec57c6","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":10},"updated":"2016-03-21 08:29:55.000000000","message":"invalid","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"c9c46e6aabe56a93b7e1d7186e79bea8a0ffda0f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\u0027ceilometer-polling\u0027 should fail with no valid pollsters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The command \u0027ceilometer-polling --pollster-list\u0027 should fail with"},{"line_number":10,"context_line":"no invalid pollsters."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When executing the command \u0027ceilometer-polling --pollster-list\u0027 with"},{"line_number":13,"context_line":"the wrong pollster like aaa, it still executes and no error will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_ad7999ca","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":10},"in_reply_to":"fa0719c6_06ec57c6","updated":"2016-03-23 06:39:36.000000000","message":"Done","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"6e234ca433e4c1e57fe21810cc2e0891677af6ee","unresolved":false,"context_lines":[{"line_number":10,"context_line":"no invalid pollsters."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When executing the command \u0027ceilometer-polling --pollster-list\u0027 with"},{"line_number":13,"context_line":"the wrong pollster like aaa, it still executes and no error will"},{"line_number":14,"context_line":"be shown. It occupies the system resources and shows no errors."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If1f9f9fdbba1832e66d89d6b61f749790df5c2b6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_86d8671f","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":3},"updated":"2016-03-21 08:29:55.000000000","message":"a","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"c9c46e6aabe56a93b7e1d7186e79bea8a0ffda0f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"no invalid pollsters."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When executing the command \u0027ceilometer-polling --pollster-list\u0027 with"},{"line_number":13,"context_line":"the wrong pollster like aaa, it still executes and no error will"},{"line_number":14,"context_line":"be shown. It occupies the system resources and shows no errors."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If1f9f9fdbba1832e66d89d6b61f749790df5c2b6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_ed7f11a9","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":3},"in_reply_to":"fa0719c6_86d8671f","updated":"2016-03-23 06:39:36.000000000","message":"Done","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"}],"ceilometer/agent/manager.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"c565f14ea18eddad3b7af7d1e188aa9308135e97","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        super(PollsterListForbidden, self).__init__(msg)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class InvalidPollstersException(Exception):"},{"line_number":92,"context_line":"    def __init__(self):"},{"line_number":93,"context_line":"        msg \u003d (\u0027It has no valid pollster in the list. The ceilometer-polling \u0027"},{"line_number":94,"context_line":"               \u0027program will exit.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_b7eddf27","line":91,"range":{"start_line":91,"start_character":6,"end_line":91,"end_character":31},"updated":"2016-03-21 03:05:52.000000000","message":"Hmm, I think EmptyPollstersList may be more readable,\nthe message would better be:\nNo valid pollster can be loaded according to the startup parameter polling-namespaces/pollster-list.","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"c9c46e6aabe56a93b7e1d7186e79bea8a0ffda0f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        super(PollsterListForbidden, self).__init__(msg)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class InvalidPollstersException(Exception):"},{"line_number":92,"context_line":"    def __init__(self):"},{"line_number":93,"context_line":"        msg \u003d (\u0027It has no valid pollster in the list. The ceilometer-polling \u0027"},{"line_number":94,"context_line":"               \u0027program will exit.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_7a9cce69","line":91,"range":{"start_line":91,"start_character":6,"end_line":91,"end_character":31},"in_reply_to":"fa0719c6_b7eddf27","updated":"2016-03-23 06:39:36.000000000","message":"Hi Liu Sheng\n\nokey, I will update it.\n\nThanks","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"c565f14ea18eddad3b7af7d1e188aa9308135e97","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            itertools.chain(*list(extensions_fb)))"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        if self.extensions \u003d\u003d []:"},{"line_number":273,"context_line":"            LOG.error(\u0027No valid pollsters are loaded.\u0027)"},{"line_number":274,"context_line":"            raise InvalidPollstersException()"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        self.discovery_manager \u003d self._extensions(\u0027discover\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_37370fe5","line":273,"range":{"start_line":273,"start_character":12,"end_line":273,"end_character":55},"updated":"2016-03-21 03:05:52.000000000","message":"it is don\u0027t need a log message if we raise an exception.","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"c9c46e6aabe56a93b7e1d7186e79bea8a0ffda0f","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            itertools.chain(*list(extensions_fb)))"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        if self.extensions \u003d\u003d []:"},{"line_number":273,"context_line":"            LOG.error(\u0027No valid pollsters are loaded.\u0027)"},{"line_number":274,"context_line":"            raise InvalidPollstersException()"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        self.discovery_manager \u003d self._extensions(\u0027discover\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_da36bab3","line":273,"range":{"start_line":273,"start_character":12,"end_line":273,"end_character":55},"in_reply_to":"fa0719c6_37370fe5","updated":"2016-03-23 06:39:36.000000000","message":"Hi Liu Sheng\n\nOkey, will remove it.\n\nThanks","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"}],"ceilometer/tests/unit/agent/test_manager.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"6e234ca433e4c1e57fe21810cc2e0891677af6ee","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def test_load_invalid_plugins_pollster_list(self):"},{"line_number":69,"context_line":"        # if no valid pollsters have been loaded, the ceilometer"},{"line_number":70,"context_line":"        # polling program should exit"},{"line_number":71,"context_line":"        try:"},{"line_number":72,"context_line":"            manager.AgentManager(pollster_list\u003d[\u0027aaa\u0027])"},{"line_number":73,"context_line":"        except manager.InvalidPollstersException as e:"},{"line_number":74,"context_line":"            err_buff \u003d str(e)"},{"line_number":75,"context_line":"            self.assertEqual(\u0027It has no valid pollster in the list.\u0027"},{"line_number":76,"context_line":"                             \u0027 The ceilometer-polling \u0027"},{"line_number":77,"context_line":"                             \u0027program will exit.\u0027,"},{"line_number":78,"context_line":"                             err_buff)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_load_plugins_no_intersection(self):"},{"line_number":81,"context_line":"        # Let\u0027s test nothing will be polled if namespace and pollsters"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_869067ee","line":78,"range":{"start_line":71,"start_character":8,"end_line":78,"end_character":38},"updated":"2016-03-21 08:29:55.000000000","message":"ditto","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"c9c46e6aabe56a93b7e1d7186e79bea8a0ffda0f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def test_load_invalid_plugins_pollster_list(self):"},{"line_number":69,"context_line":"        # if no valid pollsters have been loaded, the ceilometer"},{"line_number":70,"context_line":"        # polling program should exit"},{"line_number":71,"context_line":"        try:"},{"line_number":72,"context_line":"            manager.AgentManager(pollster_list\u003d[\u0027aaa\u0027])"},{"line_number":73,"context_line":"        except manager.InvalidPollstersException as e:"},{"line_number":74,"context_line":"            err_buff \u003d str(e)"},{"line_number":75,"context_line":"            self.assertEqual(\u0027It has no valid pollster in the list.\u0027"},{"line_number":76,"context_line":"                             \u0027 The ceilometer-polling \u0027"},{"line_number":77,"context_line":"                             \u0027program will exit.\u0027,"},{"line_number":78,"context_line":"                             err_buff)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_load_plugins_no_intersection(self):"},{"line_number":81,"context_line":"        # Let\u0027s test nothing will be polled if namespace and pollsters"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_ad607902","line":78,"range":{"start_line":71,"start_character":8,"end_line":78,"end_character":38},"in_reply_to":"fa0719c6_869067ee","updated":"2016-03-23 06:39:36.000000000","message":"Hi Julien\n\nThanks for your review. I will do it.","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"6e234ca433e4c1e57fe21810cc2e0891677af6ee","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def test_load_plugins_no_intersection(self):"},{"line_number":81,"context_line":"        # Let\u0027s test nothing will be polled if namespace and pollsters"},{"line_number":82,"context_line":"        # list have no intersection."},{"line_number":83,"context_line":"        try:"},{"line_number":84,"context_line":"            manager.AgentManager(namespaces\u003d[\u0027compute\u0027],"},{"line_number":85,"context_line":"                                 pollster_list\u003d[\u0027storage.*\u0027])"},{"line_number":86,"context_line":"        except manager.InvalidPollstersException as e:"},{"line_number":87,"context_line":"            err_buff \u003d str(e)"},{"line_number":88,"context_line":"            self.assertEqual(\u0027It has no valid pollster in the list.\u0027"},{"line_number":89,"context_line":"                             \u0027 The ceilometer-polling \u0027"},{"line_number":90,"context_line":"                             \u0027program will exit.\u0027,"},{"line_number":91,"context_line":"                             err_buff)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # Test plugin load behavior based on Node Manager pollsters."},{"line_number":94,"context_line":"    # pollster_list is just a filter, so sensor pollsters under \u0027ipmi\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_6689d3ca","line":91,"range":{"start_line":83,"start_character":8,"end_line":91,"end_character":38},"updated":"2016-03-21 08:29:55.000000000","message":"ditto","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"c9c46e6aabe56a93b7e1d7186e79bea8a0ffda0f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def test_load_plugins_no_intersection(self):"},{"line_number":81,"context_line":"        # Let\u0027s test nothing will be polled if namespace and pollsters"},{"line_number":82,"context_line":"        # list have no intersection."},{"line_number":83,"context_line":"        try:"},{"line_number":84,"context_line":"            manager.AgentManager(namespaces\u003d[\u0027compute\u0027],"},{"line_number":85,"context_line":"                                 pollster_list\u003d[\u0027storage.*\u0027])"},{"line_number":86,"context_line":"        except manager.InvalidPollstersException as e:"},{"line_number":87,"context_line":"            err_buff \u003d str(e)"},{"line_number":88,"context_line":"            self.assertEqual(\u0027It has no valid pollster in the list.\u0027"},{"line_number":89,"context_line":"                             \u0027 The ceilometer-polling \u0027"},{"line_number":90,"context_line":"                             \u0027program will exit.\u0027,"},{"line_number":91,"context_line":"                             err_buff)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # Test plugin load behavior based on Node Manager pollsters."},{"line_number":94,"context_line":"    # pollster_list is just a filter, so sensor pollsters under \u0027ipmi\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_8d5db549","line":91,"range":{"start_line":83,"start_character":8,"end_line":91,"end_character":38},"in_reply_to":"fa0719c6_6689d3ca","updated":"2016-03-23 06:39:36.000000000","message":"Hi Julien\n\nThanks for your review. I will do it.","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"6e234ca433e4c1e57fe21810cc2e0891677af6ee","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def test_load_failed_plugins(self, LOG):"},{"line_number":113,"context_line":"        # Here we additionally check that namespaces will be converted to the"},{"line_number":114,"context_line":"        # list if param was not set as a list."},{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            manager.AgentManager(namespaces\u003d\u0027ipmi\u0027,"},{"line_number":117,"context_line":"                                 pollster_list\u003d[\u0027hardware.ipmi.node.*\u0027])"},{"line_number":118,"context_line":"        except manager.InvalidPollstersException as e:"},{"line_number":119,"context_line":"            err_buff \u003d str(e)"},{"line_number":120,"context_line":"            self.assertEqual(\u0027It has no valid pollster in the list.\u0027"},{"line_number":121,"context_line":"                             \u0027 The ceilometer-polling \u0027"},{"line_number":122,"context_line":"                             \u0027program will exit.\u0027,"},{"line_number":123,"context_line":"                             err_buff)"},{"line_number":124,"context_line":"        err_msg \u003d \u0027Skip loading extension for hardware.ipmi.node.%s\u0027"},{"line_number":125,"context_line":"        pollster_names \u003d ["},{"line_number":126,"context_line":"            \u0027power\u0027, \u0027temperature\u0027, \u0027outlet_temperature\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_c699bf21","line":123,"range":{"start_line":115,"start_character":8,"end_line":123,"end_character":38},"updated":"2016-03-21 08:29:55.000000000","message":"self.assertRaisesRegexp","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"c9c46e6aabe56a93b7e1d7186e79bea8a0ffda0f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def test_load_failed_plugins(self, LOG):"},{"line_number":113,"context_line":"        # Here we additionally check that namespaces will be converted to the"},{"line_number":114,"context_line":"        # list if param was not set as a list."},{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            manager.AgentManager(namespaces\u003d\u0027ipmi\u0027,"},{"line_number":117,"context_line":"                                 pollster_list\u003d[\u0027hardware.ipmi.node.*\u0027])"},{"line_number":118,"context_line":"        except manager.InvalidPollstersException as e:"},{"line_number":119,"context_line":"            err_buff \u003d str(e)"},{"line_number":120,"context_line":"            self.assertEqual(\u0027It has no valid pollster in the list.\u0027"},{"line_number":121,"context_line":"                             \u0027 The ceilometer-polling \u0027"},{"line_number":122,"context_line":"                             \u0027program will exit.\u0027,"},{"line_number":123,"context_line":"                             err_buff)"},{"line_number":124,"context_line":"        err_msg \u003d \u0027Skip loading extension for hardware.ipmi.node.%s\u0027"},{"line_number":125,"context_line":"        pollster_names \u003d ["},{"line_number":126,"context_line":"            \u0027power\u0027, \u0027temperature\u0027, \u0027outlet_temperature\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_ed56f128","line":123,"range":{"start_line":115,"start_character":8,"end_line":123,"end_character":38},"in_reply_to":"fa0719c6_c699bf21","updated":"2016-03-23 06:39:36.000000000","message":"Hi Julien\n\nThanks for your review. I will do it.","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"6e234ca433e4c1e57fe21810cc2e0891677af6ee","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    @mock.patch(\u0027ceilometer.ipmi.pollsters.sensor.SensorPollster.__init__\u0027,"},{"line_number":135,"context_line":"                mock.Mock(return_value\u003dNone))"},{"line_number":136,"context_line":"    def test_import_error_in_plugin(self):"},{"line_number":137,"context_line":"        try:"},{"line_number":138,"context_line":"            manager.AgentManager("},{"line_number":139,"context_line":"                namespaces\u003d[\u0027ipmi\u0027],"},{"line_number":140,"context_line":"                pollster_list\u003d[\u0027hardware.ipmi.node.*\u0027])"},{"line_number":141,"context_line":"        except manager.InvalidPollstersException as e:"},{"line_number":142,"context_line":"            err_buff \u003d str(e)"},{"line_number":143,"context_line":"            self.assertEqual(\u0027It has no valid pollster in the list.\u0027"},{"line_number":144,"context_line":"                             \u0027 The ceilometer-polling \u0027"},{"line_number":145,"context_line":"                             \u0027program will exit.\u0027,"},{"line_number":146,"context_line":"                             err_buff)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    # Exceptions other than ExtensionLoadError are propagated"},{"line_number":149,"context_line":"    @mock.patch(\u0027ceilometer.ipmi.pollsters.node._Base.__init__\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_06a45755","line":146,"range":{"start_line":137,"start_character":8,"end_line":146,"end_character":38},"updated":"2016-03-21 08:29:55.000000000","message":"ditto","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"c9c46e6aabe56a93b7e1d7186e79bea8a0ffda0f","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    @mock.patch(\u0027ceilometer.ipmi.pollsters.sensor.SensorPollster.__init__\u0027,"},{"line_number":135,"context_line":"                mock.Mock(return_value\u003dNone))"},{"line_number":136,"context_line":"    def test_import_error_in_plugin(self):"},{"line_number":137,"context_line":"        try:"},{"line_number":138,"context_line":"            manager.AgentManager("},{"line_number":139,"context_line":"                namespaces\u003d[\u0027ipmi\u0027],"},{"line_number":140,"context_line":"                pollster_list\u003d[\u0027hardware.ipmi.node.*\u0027])"},{"line_number":141,"context_line":"        except manager.InvalidPollstersException as e:"},{"line_number":142,"context_line":"            err_buff \u003d str(e)"},{"line_number":143,"context_line":"            self.assertEqual(\u0027It has no valid pollster in the list.\u0027"},{"line_number":144,"context_line":"                             \u0027 The ceilometer-polling \u0027"},{"line_number":145,"context_line":"                             \u0027program will exit.\u0027,"},{"line_number":146,"context_line":"                             err_buff)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    # Exceptions other than ExtensionLoadError are propagated"},{"line_number":149,"context_line":"    @mock.patch(\u0027ceilometer.ipmi.pollsters.node._Base.__init__\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_6d3941f2","line":146,"range":{"start_line":137,"start_character":8,"end_line":146,"end_character":38},"in_reply_to":"fa0719c6_06a45755","updated":"2016-03-23 06:39:36.000000000","message":"Hi Julien\n\nThanks for your review. I will do it.","commit_id":"4582d3541bc85bd47f2488080abbca6feb9d30e6"},{"author":{"_account_id":18137,"name":"Xia Linjuan","email":"ljxiash@cn.ibm.com","username":"xialinjuan"},"change_message_id":"606694ef3919157a28cbad769ff17a3948d1cd69","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        # polling program should exit"},{"line_number":71,"context_line":"        self.assertRaisesRegexp("},{"line_number":72,"context_line":"            manager.EmptyPollstersList,"},{"line_number":73,"context_line":"            \u0027No valid pollsters can be loaded with the startup parameters\u0027"},{"line_number":74,"context_line":"            \u0027polling-namespaces and pollster-list.\u0027,"},{"line_number":75,"context_line":"            manager.AgentManager,"},{"line_number":76,"context_line":"            pollster_list\u003d[\u0027aaa\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_6a5bdcf6","line":73,"updated":"2016-03-23 09:51:15.000000000","message":"Hi Zilian, there should be a blank space between the last word and the word in the next line.","commit_id":"464af7f9c1b0ea385c3a2816a3185800723185ce"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"0c311ecfd1aea128c5a2b6bd43c7fccd10e2b385","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            manager.AgentManager(namespaces\u003d\u0027ipmi\u0027,"},{"line_number":114,"context_line":"                                 pollster_list\u003d[\u0027hardware.ipmi.node.*\u0027])"},{"line_number":115,"context_line":"        except manager.EmptyPollstersList:"},{"line_number":116,"context_line":"            pass"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        err_msg \u003d \u0027Skip loading extension for hardware.ipmi.node.%s\u0027"},{"line_number":119,"context_line":"        pollster_names \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_44463d24","line":116,"range":{"start_line":116,"start_character":12,"end_line":116,"end_character":16},"updated":"2016-03-25 08:32:21.000000000","message":"Let\u0027s use assertRaisesRegexp here too.","commit_id":"98839d98737eaf642057ea895f4dcb65ea2eb426"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"bcfcbd89f8fc4bec9dcffd8d066c264de02cdba0","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            manager.AgentManager(namespaces\u003d\u0027ipmi\u0027,"},{"line_number":114,"context_line":"                                 pollster_list\u003d[\u0027hardware.ipmi.node.*\u0027])"},{"line_number":115,"context_line":"        except manager.EmptyPollstersList:"},{"line_number":116,"context_line":"            pass"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        err_msg \u003d \u0027Skip loading extension for hardware.ipmi.node.%s\u0027"},{"line_number":119,"context_line":"        pollster_names \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_fd5a4429","line":116,"range":{"start_line":116,"start_character":12,"end_line":116,"end_character":16},"in_reply_to":"da0c15f0_44463d24","updated":"2016-03-28 07:30:14.000000000","message":"Hello Lian Hao\n\nThe case mentioned in the comments has already been tested in the method test_import_error_in_plugin.\n\nI think we need to test the log method is called correctly in this test case.\n\nDo you have any suggestions?\n\nThanks","commit_id":"98839d98737eaf642057ea895f4dcb65ea2eb426"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"a1f34d99d8c92df8b383e1162665b75de35b628b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            manager.AgentManager(namespaces\u003d\u0027ipmi\u0027,"},{"line_number":114,"context_line":"                                 pollster_list\u003d[\u0027hardware.ipmi.node.*\u0027])"},{"line_number":115,"context_line":"        except manager.EmptyPollstersList:"},{"line_number":116,"context_line":"            pass"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        err_msg \u003d \u0027Skip loading extension for hardware.ipmi.node.%s\u0027"},{"line_number":119,"context_line":"        pollster_names \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_1a4ade83","line":116,"range":{"start_line":116,"start_character":12,"end_line":116,"end_character":16},"in_reply_to":"da0c15f0_44463d24","updated":"2016-03-28 02:32:30.000000000","message":"Hi Lian Hao\n\nokey, thanks","commit_id":"98839d98737eaf642057ea895f4dcb65ea2eb426"}],"devstack/upgrade/upgrade.sh":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"55ae17fc26dc3ffff83e31f58160bfd5f7a7795e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"start_ceilometer"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Note these are process names, not service names"},{"line_number":77,"context_line":"# Note(liamji): Disable the test for"},{"line_number":78,"context_line":"# \"ceilometer-polling --polling-namespaces ipmi\". In the test environment,"},{"line_number":79,"context_line":"# the impi is not ready. The ceilometer-polling should fail."},{"line_number":80,"context_line":"ensure_services_started \"ceilometer-polling --polling-namespaces compute\" \\"},{"line_number":81,"context_line":"                        \"ceilometer-polling --polling-namespaces central\" \\"},{"line_number":82,"context_line":"                        ceilometer-agent-notification \\"}],"source_content_type":"text/x-sh","patch_set":6,"id":"da0c15f0_33bc356c","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":60},"updated":"2016-03-25 07:40:09.000000000","message":"I am not very sure this change will make the grenade test missing coverage of ipmi cases.","commit_id":"98839d98737eaf642057ea895f4dcb65ea2eb426"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"0c311ecfd1aea128c5a2b6bd43c7fccd10e2b385","unresolved":false,"context_lines":[{"line_number":74,"context_line":"start_ceilometer"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Note these are process names, not service names"},{"line_number":77,"context_line":"# Note(liamji): Disable the test for"},{"line_number":78,"context_line":"# \"ceilometer-polling --polling-namespaces ipmi\". In the test environment,"},{"line_number":79,"context_line":"# the impi is not ready. The ceilometer-polling should fail."},{"line_number":80,"context_line":"ensure_services_started \"ceilometer-polling --polling-namespaces compute\" \\"},{"line_number":81,"context_line":"                        \"ceilometer-polling --polling-namespaces central\" \\"},{"line_number":82,"context_line":"                        ceilometer-agent-notification \\"}],"source_content_type":"text/x-sh","patch_set":6,"id":"da0c15f0_a472b97a","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":60},"in_reply_to":"da0c15f0_33bc356c","updated":"2016-03-25 08:32:21.000000000","message":"I\u0027m ok with this change now. Checked the failure log in patch set 1, it\u0027s confirmed that the failure is due to the test machine doesn\u0027t have ipmi support. I think we should move this kind of test into Intel ipmi 3rd party CI in the future.","commit_id":"98839d98737eaf642057ea895f4dcb65ea2eb426"}]}