)]}'
{"ceilometer/storage/__init__.py":[{"author":{"_account_id":7302,"name":"xingzhou","email":"xingzhou@cn.ibm.com","username":"xingzhou"},"change_message_id":"a1ee1597314dea814c2ff093f9efb4901a146f26","unresolved":false,"context_lines":[{"line_number":44,"context_line":"cfg.CONF.register_opts(STORAGE_OPTS)"},{"line_number":45,"context_line":"cfg.CONF.import_opt(\u0027connection\u0027,"},{"line_number":46,"context_line":"                    \u0027ceilometer.openstack.common.db.sqlalchemy.session\u0027,"},{"line_number":47,"context_line":"                    group\u003d\u0027database\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2Fh%2Fg%3D","line":47,"updated":"2013-05-31 05:05:38.000000000","message":"is it better to use oslo deprecated_name \u0026 deprecated_group for the old database_connection?","commit_id":"61a4a867ed40ef004e337f8d4d8037918e132a88"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"0981c77b8407a3e95f2d2f1cf1a4c6e8a60201a4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"cfg.CONF.register_opts(STORAGE_OPTS)"},{"line_number":45,"context_line":"cfg.CONF.import_opt(\u0027connection\u0027,"},{"line_number":46,"context_line":"                    \u0027ceilometer.openstack.common.db.sqlalchemy.session\u0027,"},{"line_number":47,"context_line":"                    group\u003d\u0027database\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2FhQ8%3D","line":47,"in_reply_to":"AAAAPH%2F%2Fh%2Fg%3D","updated":"2013-05-31 11:57:46.000000000","message":"It would be, but I\u0027m not sure it\u0027s possible here since that would need to do it when [database]connection is declared, and we can\u0027t do that I imagine.","commit_id":"61a4a867ed40ef004e337f8d4d8037918e132a88"}],"ceilometer/storage/impl_sqlalchemy.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"88363d5d26f9abfd5ce44ddee81a6fe50eace56d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        if url \u003d\u003d \u0027sqlite://\u0027:"},{"line_number":137,"context_line":"            url \u003d os.environ.get(\u0027CEILOMETER_TEST_SQL_URL\u0027, url)"},{"line_number":138,"context_line":"        LOG.info(\u0027connecting to %s\u0027, url)"},{"line_number":139,"context_line":"        sqlalchemy_session.set_defaults(url, None)"},{"line_number":140,"context_line":"        self.session \u003d sqlalchemy_session.get_session()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def upgrade(self, version\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FoYA%3D","line":139,"updated":"2013-05-28 22:23:04.000000000","message":"Is there really no other way to pass this value into the library without having to set the global default each time we create a connection?","commit_id":"622b30d56b701295a1c5acf62db91f0c2964e6a4"},{"author":{"_account_id":7302,"name":"xingzhou","email":"xingzhou@cn.ibm.com","username":"xingzhou"},"change_message_id":"311968389050f9ff21fd481e7cba949bc9cfb384","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        if url \u003d\u003d \u0027sqlite://\u0027:"},{"line_number":137,"context_line":"            url \u003d os.environ.get(\u0027CEILOMETER_TEST_SQL_URL\u0027, url)"},{"line_number":138,"context_line":"        LOG.info(\u0027connecting to %s\u0027, url)"},{"line_number":139,"context_line":"        sqlalchemy_session.set_defaults(url, None)"},{"line_number":140,"context_line":"        self.session \u003d sqlalchemy_session.get_session()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def upgrade(self, version\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fnns%3D","line":139,"in_reply_to":"AAAAPH%2F%2Fn9s%3D","updated":"2013-05-29 06:35:08.000000000","message":"the create_engine in session.py accepts a sql_connection as input, while I think there needs one new get_session method which accepts the connection url and pass it to create_engine","commit_id":"622b30d56b701295a1c5acf62db91f0c2964e6a4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b512f6331ecf4b5103741185019f9aee58280290","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        if url \u003d\u003d \u0027sqlite://\u0027:"},{"line_number":137,"context_line":"            url \u003d os.environ.get(\u0027CEILOMETER_TEST_SQL_URL\u0027, url)"},{"line_number":138,"context_line":"        LOG.info(\u0027connecting to %s\u0027, url)"},{"line_number":139,"context_line":"        sqlalchemy_session.set_defaults(url, None)"},{"line_number":140,"context_line":"        self.session \u003d sqlalchemy_session.get_session()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def upgrade(self, version\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fl80%3D","line":139,"in_reply_to":"AAAAPH%2F%2Fnns%3D","updated":"2013-05-29 18:58:43.000000000","message":"we can\u0027t use create_engine(). create_engine code still references CONF.database.connection regardless of what you pass in.  this is the only way i can see short of completely integrating openstack.common.db - which requires quite a bit of effort.","commit_id":"622b30d56b701295a1c5acf62db91f0c2964e6a4"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"19ff9e3f93719fbfa7b09a463e6f9abd8001e64d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        if url \u003d\u003d \u0027sqlite://\u0027:"},{"line_number":137,"context_line":"            url \u003d os.environ.get(\u0027CEILOMETER_TEST_SQL_URL\u0027, url)"},{"line_number":138,"context_line":"        LOG.info(\u0027connecting to %s\u0027, url)"},{"line_number":139,"context_line":"        sqlalchemy_session.set_defaults(url, None)"},{"line_number":140,"context_line":"        self.session \u003d sqlalchemy_session.get_session()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def upgrade(self, version\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fn9s%3D","line":139,"in_reply_to":"AAAAPH%2F%2FoNQ%3D","updated":"2013-05-29 01:16:11.000000000","message":"That would still set a global value. I would prefer that we use an API that sets the connection string only for the connection being opened, I\u0027d there is one.","commit_id":"622b30d56b701295a1c5acf62db91f0c2964e6a4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"af5c179f5bc2d0a1a2df81df5d9ecac1aefa9d21","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        if url \u003d\u003d \u0027sqlite://\u0027:"},{"line_number":137,"context_line":"            url \u003d os.environ.get(\u0027CEILOMETER_TEST_SQL_URL\u0027, url)"},{"line_number":138,"context_line":"        LOG.info(\u0027connecting to %s\u0027, url)"},{"line_number":139,"context_line":"        sqlalchemy_session.set_defaults(url, None)"},{"line_number":140,"context_line":"        self.session \u003d sqlalchemy_session.get_session()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def upgrade(self, version\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FoNQ%3D","line":139,"in_reply_to":"AAAAPH%2F%2FoYA%3D","updated":"2013-05-28 23:32:56.000000000","message":"too be honest, not super familiar with it. just saw set_defaults used in config.py of nova and this was smallest change.  we could probably set it in register_opts() above.","commit_id":"622b30d56b701295a1c5acf62db91f0c2964e6a4"}]}