)]}'
{"ceilometer/service_base.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"56ce6c5f502e60e13c0e6d5f159bd47fdd5e0161","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def start(self):"},{"line_number":35,"context_line":"        self.started \u003d True"},{"line_number":36,"context_line":"        super(ServiceBase, self).start()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_669aae63","line":36,"updated":"2016-04-28 15:44:28.000000000","message":"do we need to set stop as well?","commit_id":"0d905b323b6b57a78d0e5f230ab5df517643d769"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"ef85c46232de4fd10c5881b1603e2acccfb94044","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def start(self):"},{"line_number":35,"context_line":"        self.started \u003d True"},{"line_number":36,"context_line":"        super(ServiceBase, self).start()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_464cd29d","line":36,"in_reply_to":"1a122d0e_669aae63","updated":"2016-04-28 15:52:28.000000000","message":"not needed, oslo.service uses stop() when child process received SIGTERM and then exit the process.\n\nThe oslo.service API have also a restart, but because this lib code is mostly broken by design, it\u0027s never used, instead the parent just SIGTERM on child (so stop() is used here too) and then start new and fresh children processes.","commit_id":"0d905b323b6b57a78d0e5f230ab5df517643d769"}]}