)]}'
{"ceilometer/dispatcher/file.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"4775c51a72df2af64cf34a2c060bcccbd9ab417e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"OPTS \u003d ["},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027file_path\u0027,"},{"line_number":27,"context_line":"               help\u003d\u0027Name and the location of the file to record \u0027"},{"line_number":28,"context_line":"                    \u0027meters.\u0027),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027max_bytes\u0027,"},{"line_number":30,"context_line":"               default\u003d0,"},{"line_number":31,"context_line":"               help\u003d\u0027The max size of the file.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_a86ee093","line":28,"updated":"2016-06-09 22:41:13.000000000","message":"Please also update the help text. It is unclear and should indicate this is required when the file dispatcher is enabled.\n\nIt would be even more helpful to provide a sample_default","commit_id":"df98e8afb7f30333be513cb2b55fe4d1131c358a"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"84e40d0ea4e8442cf981b604d3d9b3463f556407","unresolved":false,"context_lines":[{"line_number":25,"context_line":"OPTS \u003d ["},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027file_path\u0027,"},{"line_number":27,"context_line":"               help\u003d\u0027Name and the location of the file to record \u0027"},{"line_number":28,"context_line":"                    \u0027meters.\u0027),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027max_bytes\u0027,"},{"line_number":30,"context_line":"               default\u003d0,"},{"line_number":31,"context_line":"               help\u003d\u0027The max size of the file.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_33e57ba7","line":28,"in_reply_to":"7aa08908_a86ee093","updated":"2016-09-08 01:54:32.000000000","message":"we need to provide a default path in that case","commit_id":"df98e8afb7f30333be513cb2b55fe4d1131c358a"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"f94359e74596bb0fb52ae3a95c6f5456b15bf211","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            LOG.warning(_LW(\u0027file dispatcher is enabled but \u0027"},{"line_number":85,"context_line":"                            \u0027dispatcher_file.file_path is not set, all data \u0027"},{"line_number":86,"context_line":"                            \u0027will be ignored\u0027))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def record_metering_data(self, data):"},{"line_number":89,"context_line":"        if self.log:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_5e4a8fc6","line":86,"updated":"2016-05-06 20:17:06.000000000","message":"would it make sense to have a default path instead of ignoring the meters?","commit_id":"df98e8afb7f30333be513cb2b55fe4d1131c358a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"161a264253c99698aa1f5aaf2ae1555834aa2e93","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            LOG.warning(_LW(\u0027file dispatcher is enabled but \u0027"},{"line_number":85,"context_line":"                            \u0027dispatcher_file.file_path is not set, all data \u0027"},{"line_number":86,"context_line":"                            \u0027will be ignored\u0027))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def record_metering_data(self, data):"},{"line_number":89,"context_line":"        if self.log:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_368f5ccd","line":86,"in_reply_to":"dab17558_5e4a8fc6","updated":"2016-09-07 09:19:02.000000000","message":"Agreed something like /var/lib/ceilometer/meters","commit_id":"df98e8afb7f30333be513cb2b55fe4d1131c358a"}]}