)]}'
{"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"a936fcad8dedc879422b8b8a02c97ba6a7ccbe90","unresolved":false,"context_lines":[{"line_number":466,"context_line":"    def get_all(self, q\u003d[], limit\u003dNone):"},{"line_number":467,"context_line":"        \"\"\"Return samples for the meter."},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        :param q: Filter rules for the data to be returned."},{"line_number":470,"context_line":"        \"\"\""},{"line_number":471,"context_line":"        kwargs \u003d _query_to_kwargs(q, storage.SampleFilter.__init__)"},{"line_number":472,"context_line":"        kwargs[\u0027meter\u0027] \u003d self._id"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FePc%3D","line":469,"updated":"2013-06-03 01:42:00.000000000","message":"might need comment of param limit here for documentation.","commit_id":"d23c62d3d4ca13a8c8228323319d880536272def"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"a9608b02c3abdefdc7c909d068893898d965a15f","unresolved":false,"context_lines":[{"line_number":466,"context_line":"    def get_all(self, q\u003d[], limit\u003dNone):"},{"line_number":467,"context_line":"        \"\"\"Return samples for the meter."},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        :param q: Filter rules for the data to be returned."},{"line_number":470,"context_line":"        \"\"\""},{"line_number":471,"context_line":"        kwargs \u003d _query_to_kwargs(q, storage.SampleFilter.__init__)"},{"line_number":472,"context_line":"        kwargs[\u0027meter\u0027] \u003d self._id"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fd5Q%3D","line":469,"in_reply_to":"AAAAPH%2F%2FePc%3D","updated":"2013-06-03 09:54:53.000000000","message":"Done","commit_id":"d23c62d3d4ca13a8c8228323319d880536272def"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"80099623a46163c4b89456cd3f784a35dd8f2a7f","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        :param limit: Maximum number of samples to return."},{"line_number":471,"context_line":"        \"\"\""},{"line_number":472,"context_line":"        if limit and limit \u003c 0:"},{"line_number":473,"context_line":"            raise ValueError(\"Limit must be positive\")"},{"line_number":474,"context_line":"        kwargs \u003d _query_to_kwargs(q, storage.SampleFilter.__init__)"},{"line_number":475,"context_line":"        kwargs[\u0027meter\u0027] \u003d self._id"},{"line_number":476,"context_line":"        f \u003d storage.SampleFilter(**kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FdyU%3D","line":473,"updated":"2013-06-03 10:48:00.000000000","message":"Just wondering if we should make this test strictly positive?\n\n(as requesting an empty result set with a limit of zero is only vaguely more sensible than a limit of -1).","commit_id":"b61209c571fda5c1103e92b32c2b1cd4ebd99022"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3d8f9763cf049d5cce15c74252d3914e8492060b","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        :param limit: Maximum number of samples to return."},{"line_number":471,"context_line":"        \"\"\""},{"line_number":472,"context_line":"        if limit and limit \u003c 0:"},{"line_number":473,"context_line":"            raise ValueError(\"Limit must be positive\")"},{"line_number":474,"context_line":"        kwargs \u003d _query_to_kwargs(q, storage.SampleFilter.__init__)"},{"line_number":475,"context_line":"        kwargs[\u0027meter\u0027] \u003d self._id"},{"line_number":476,"context_line":"        f \u003d storage.SampleFilter(**kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FduU%3D","line":473,"in_reply_to":"AAAAPH%2F%2FdyU%3D","updated":"2013-06-03 12:02:46.000000000","message":"Well, I imagine that some program might end up at some point requesting 0 result due to a bad programmer mistake. I think it\u0027s more liberal to accept it and return nothing that raising an error.\n\n\"be liberal in what you accept\"","commit_id":"b61209c571fda5c1103e92b32c2b1cd4ebd99022"}]}