)]}'
{"ceilometer/tests/functional/test_notification.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"cd9d4287af5e33b35aa9ffb649c069931a48c2d1","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        self.srv.start()"},{"line_number":396,"context_line":"        self.addCleanup(self.srv.stop)"},{"line_number":397,"context_line":"        listener \u003d self.srv.pipeline_listener"},{"line_number":398,"context_line":"        self.assertEqual(20, len(mock_listener.call_args[0][1]))"},{"line_number":399,"context_line":"        self.srv._configure_pipeline_listener()"},{"line_number":400,"context_line":"        self.assertEqual(20, len(mock_listener.call_args[0][1]))"},{"line_number":401,"context_line":"        self.assertIsNot(listener, self.srv.pipeline_listener)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_71ae2682","line":398,"updated":"2016-05-10 19:47:27.000000000","message":"to be honest, this is really hard to tell what is happening here. is this done so it\u0027s backward compatible for pre-5.x?\n\ni think the difference is that the target is now attached to server rather than dispatcher.","commit_id":"bce8bdbf8e4b97ad2377f493e90c637d938609d4"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"f5c4ce4d6a2417129e4a51d1399d81432e0831d6","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        self.srv.start()"},{"line_number":396,"context_line":"        self.addCleanup(self.srv.stop)"},{"line_number":397,"context_line":"        listener \u003d self.srv.pipeline_listener"},{"line_number":398,"context_line":"        self.assertEqual(20, len(mock_listener.call_args[0][1]))"},{"line_number":399,"context_line":"        self.srv._configure_pipeline_listener()"},{"line_number":400,"context_line":"        self.assertEqual(20, len(mock_listener.call_args[0][1]))"},{"line_number":401,"context_line":"        self.assertIsNot(listener, self.srv.pipeline_listener)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_b9498862","line":398,"in_reply_to":"dab17558_71ae2682","updated":"2016-05-11 02:36:55.000000000","message":"yes, now it belongs to server\n\nhowever, 5.0 and pre 5.0 return different type of object, they have different attribute, I think we should not have if...else branch just to check return type, so I check the calling argument\n\nif you do want it to be precise, I can add a check for the call_args[0][1] type, but I think such things already done in L173, so I don\u0027t repeat here, however, as independent unit test, maybe it is worth to do so","commit_id":"bce8bdbf8e4b97ad2377f493e90c637d938609d4"}]}