)]}'
{"ceilometer/collector.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"a7874bff78a4f97264b406d8bb583bcb4ee8b01f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.event_listener \u003d None"},{"line_number":69,"context_line":"        self.udp_thread \u003d None"},{"line_number":70,"context_line":"        dispatcher_managers \u003d dispatcher.load_dispatcher_manager()"},{"line_number":71,"context_line":"        (self.meter_manager, self.event_manager) \u003d dispatcher_managers"},{"line_number":72,"context_line":"        super(CollectorService, self).start()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if cfg.CONF.collector.udp_address:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_f304b54a","line":71,"updated":"2016-05-17 12:09:20.000000000","message":"I don\u0027t see any good reasons to move these lines?","commit_id":"d3da20a4df32f1d19e3e5d406f51bb1f50ea85c3"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"6b2a5f0227683bf4c375ff87ff804d29fb9449e4","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.event_listener \u003d None"},{"line_number":69,"context_line":"        self.udp_thread \u003d None"},{"line_number":70,"context_line":"        dispatcher_managers \u003d dispatcher.load_dispatcher_manager()"},{"line_number":71,"context_line":"        (self.meter_manager, self.event_manager) \u003d dispatcher_managers"},{"line_number":72,"context_line":"        super(CollectorService, self).start()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if cfg.CONF.collector.udp_address:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_5f066086","line":71,"in_reply_to":"dab17558_f304b54a","updated":"2016-05-17 13:13:41.000000000","message":"it seems I lost all logs with proves that it is needed :) will return this change when see it again.","commit_id":"d3da20a4df32f1d19e3e5d406f51bb1f50ea85c3"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"5a554fa217a85e9e501da24ea77731f6ce6b9ac0","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        if self.sample_listener:"},{"line_number":131,"context_line":"            utils.kill_listeners([self.sample_listener])"},{"line_number":132,"context_line":"        if self.event_listener:"},{"line_number":133,"context_line":"            utils.kill_listeners([self.event_listener])"},{"line_number":134,"context_line":"        if self.udp_thread:"},{"line_number":135,"context_line":"            self.udp_run \u003d False"},{"line_number":136,"context_line":"            self.udp_thread.join()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_3aa0caf3","side":"PARENT","line":133,"updated":"2016-05-17 13:20:50.000000000","message":"This is not a good idea, we have to wait that all in progress threads to finish before return to ensure oslo.service doesn\u0027t do os._exit during message processing.\n\nYour error message comes from the fact that stop is called in parent process AND children processes by oslo.service (yeah oslo.service API sucks...), when for us we want it to be called only in children processes (like oslo.service does for start).\n\nI have proposed https://review.openstack.org/#/c/309331/ that workaround oslo.service API design issue cleanly and should fix your issue.","commit_id":"0718eebe96fd131caee5b551938d95ca050e24ca"}]}