)]}'
{"ceilometer/compute/virt/libvirt/inspector.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"e44ea5c24b58d25cd38791640457b81a5d5a1751","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            except ImportError:"},{"line_number":85,"context_line":"                LOG.warning(_LW(\"Libvirt module could not be loaded. \""},{"line_number":86,"context_line":"                                \"LibvirtInspector will not work correctly.\"))"},{"line_number":87,"context_line":"            if libvirt is None:"},{"line_number":88,"context_line":"                libvirt \u003d __import__(\u0027libvirt\u0027)"},{"line_number":89,"context_line":"            LOG.debug(\u0027Connecting to libvirt: %s\u0027, self.uri)"},{"line_number":90,"context_line":"            self.connection \u003d libvirt.openReadOnly(self.uri)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_81eb04b0","line":88,"range":{"start_line":87,"start_character":12,"end_line":88,"end_character":47},"updated":"2016-05-24 12:45:15.000000000","message":"Then you can remove that, and probably fail more badly if libvirt is not found and get_connection has been called.","commit_id":"4b80bddce6dbe11250a9c84fd78f99843a5f9bdc"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"be7ecf0d1d2addf865a224e656e03e2c1a449292","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        if not self.connection:"},{"line_number":81,"context_line":"            global libvirt"},{"line_number":82,"context_line":"            if libvirt is None:"},{"line_number":83,"context_line":"                libvirt \u003d importutils.import_module(\u0027libvirt\u0027)"},{"line_number":84,"context_line":"            LOG.debug(\u0027Connecting to libvirt: %s\u0027, self.uri)"},{"line_number":85,"context_line":"            self.connection \u003d libvirt.openReadOnly(self.uri)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_18d77e24","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":62},"updated":"2016-05-24 14:27:21.000000000","message":"def import_module(import_str):\n    \"\"\"Import a module.\n    .. versionadded:: 0.3\n    \"\"\"\n    __import__(import_str)\n    return sys.modules[import_str]\n\nwhich actually improves nothing :(","commit_id":"068077eadcef74397d90c3778869229466cd2aba"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"1f07c85f55e8f4cfe9aafefcfb3f12b324b8277b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        if not self.connection:"},{"line_number":81,"context_line":"            global libvirt"},{"line_number":82,"context_line":"            if libvirt is None:"},{"line_number":83,"context_line":"                libvirt \u003d importutils.import_module(\u0027libvirt\u0027)"},{"line_number":84,"context_line":"            LOG.debug(\u0027Connecting to libvirt: %s\u0027, self.uri)"},{"line_number":85,"context_line":"            self.connection \u003d libvirt.openReadOnly(self.uri)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_ea08e8db","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":62},"in_reply_to":"9abb7d3a_09144a42","updated":"2016-07-22 15:58:29.000000000","message":"+1","commit_id":"068077eadcef74397d90c3778869229466cd2aba"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"c44b740eff02b3ea6974aef5bc6fc4ad77c68ec1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        if not self.connection:"},{"line_number":81,"context_line":"            global libvirt"},{"line_number":82,"context_line":"            if libvirt is None:"},{"line_number":83,"context_line":"                libvirt \u003d importutils.import_module(\u0027libvirt\u0027)"},{"line_number":84,"context_line":"            LOG.debug(\u0027Connecting to libvirt: %s\u0027, self.uri)"},{"line_number":85,"context_line":"            self.connection \u003d libvirt.openReadOnly(self.uri)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_6baa15d4","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":62},"in_reply_to":"9abb7d3a_09144a42","updated":"2016-07-24 19:21:20.000000000","message":"Agree with the previous comments.","commit_id":"068077eadcef74397d90c3778869229466cd2aba"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"7ce31c9ffb827926edc113633b059cee59072a79","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        if not self.connection:"},{"line_number":81,"context_line":"            global libvirt"},{"line_number":82,"context_line":"            if libvirt is None:"},{"line_number":83,"context_line":"                libvirt \u003d importutils.import_module(\u0027libvirt\u0027)"},{"line_number":84,"context_line":"            LOG.debug(\u0027Connecting to libvirt: %s\u0027, self.uri)"},{"line_number":85,"context_line":"            self.connection \u003d libvirt.openReadOnly(self.uri)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_09144a42","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":62},"in_reply_to":"bab6814e_18d77e24","updated":"2016-05-29 02:06:47.000000000","message":"whatever, here should add try...exception...\nUsing oslo_utils is better, although actually improves nothing. Thank you. :)","commit_id":"068077eadcef74397d90c3778869229466cd2aba"}]}