)]}'
{"id":"openstack%2Fceilometer~32883","triplet_id":"openstack%2Fceilometer~master~I89f5829c75b874fdfe59bc88dad809e0d54b006a","project":"openstack/ceilometer","branch":"master","topic":"jd/code-cleanup","hashtags":[],"change_id":"I89f5829c75b874fdfe59bc88dad809e0d54b006a","subject":"Code cleanup","status":"MERGED","created":"2013-06-13 13:08:26.000000000","updated":"2013-06-14 01:50:58.000000000","submitted":"2013-06-14 01:50:58.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f440525b4cc16dc7214125d6ae1cab7b307600cd","_number":32883,"virtual_id_number":32883,"owner":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-06-14 01:50:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":0,"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":2,"date":"2013-06-14 01:32:38.000000000","_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":2,"date":"2013-06-13 16:35:33.000000000","_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":0,"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":1,"date":"2013-06-14 01:32:38.000000000","_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":0,"date":"2013-06-13 16:35:33.000000000","_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":0,"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-06-13 14:47:18.000000000","updated_by":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"reviewer":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"state":"REVIEWER"},{"updated":"2013-06-13 16:35:33.000000000","updated_by":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"reviewer":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"state":"REVIEWER"},{"updated":"2013-06-14 01:32:38.000000000","updated_by":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"reviewer":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"state":"REVIEWER"},{"updated":"2013-06-14 01:50:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"fc5d17a81c09791ceb1dd9b5424567d2f536b946","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-13 13:14:37.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/32883/1/check/gate-ceilometer-pep8/2819 : SUCCESS in 2m 16s\n- http://docs-draft.openstack.org/32883/1/check/gate-ceilometer-docs/1624/doc/build/html/ : SUCCESS in 4m 17s\n- http://logs.openstack.org/32883/1/check/gate-ceilometer-python26/2752 : FAILURE in 5m 53s\n- http://logs.openstack.org/32883/1/check/gate-ceilometer-python27/2749 : FAILURE in 3m 40s\n","accounts_in_message":[],"_revision_number":1},{"id":"2697bf5bd69f6c81784ebc441c4174ec6dcaed60","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-06-13 14:18:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"02a0658312fa78bf5747efd5ff42ed54a3971e74","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-13 14:36:33.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/32883/2/check/gate-ceilometer-pep8/2822 : SUCCESS in 2m 15s\n- http://docs-draft.openstack.org/32883/2/check/gate-ceilometer-docs/1627/doc/build/html/ : SUCCESS in 3m 11s\n- http://logs.openstack.org/32883/2/check/gate-ceilometer-python26/2755 : SUCCESS in 17m 45s\n- http://logs.openstack.org/32883/2/check/gate-ceilometer-python27/2752 : SUCCESS in 4m 10s\n","accounts_in_message":[],"_revision_number":2},{"id":"f55c3f68c021b5f32e9fdbf53d0dd21147f31cc2","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-06-13 14:38:08.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"05b833524e0f7c2366c5c278a0aa03d509a466ec","author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"date":"2013-06-13 14:47:18.000000000","message":"Patch Set 3: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"a808aed2197cc506a3d7835746bb56f7e262ce55","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2013-06-13 14:50:54.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"115fcb54cf06c6b4bea4c689cb35b926861c9f00","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-13 14:57:11.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/32883/3/check/gate-ceilometer-pep8/2823 : SUCCESS in 1m 06s\n- http://docs-draft.openstack.org/32883/3/check/gate-ceilometer-docs/1628/doc/build/html/ : SUCCESS in 2m 58s\n- http://logs.openstack.org/32883/3/check/gate-ceilometer-python26/2756 : FAILURE in 18m 42s\n- http://logs.openstack.org/32883/3/check/gate-ceilometer-python27/2753 : FAILURE in 3m 43s\n","accounts_in_message":[],"_revision_number":3},{"id":"d05682d0a380fd86b69c84701cddee4286f88336","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-06-13 15:18:56.000000000","message":"Patch Set 3: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"81e49acc7b54403f1882410d1a74dfc2edd6f93d","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-06-13 15:19:51.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"2a8a00624ec5593a04e847b26f5f0b1f1867937e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-13 15:39:09.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/32883/4/check/gate-ceilometer-pep8/2824 : SUCCESS in 2m 23s\n- http://docs-draft.openstack.org/32883/4/check/gate-ceilometer-docs/1629/doc/build/html/ : SUCCESS in 4m 49s\n- http://logs.openstack.org/32883/4/check/gate-ceilometer-python26/2757 : SUCCESS in 18m 38s\n- http://logs.openstack.org/32883/4/check/gate-ceilometer-python27/2754 : SUCCESS in 4m 13s\n","accounts_in_message":[],"_revision_number":4},{"id":"3cadb86a1ebc2105ab1368f14ed237d6f81c6d41","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2013-06-13 16:35:33.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"c7ff3c8d01f515622824090e9f3f09aa1cdb04f6","author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"date":"2013-06-14 01:32:38.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":4},{"id":"309ced92961bf52f698b79fd195e309e68ee4c1a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-14 01:32:52.000000000","message":"Patch Set 4: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"2847f7477e654d7af2931fdab0f2284c71e6b3be","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-14 01:50:58.000000000","message":"Patch Set 4: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/32883/4/gate/gate-ceilometer-docs/1636/doc/build/html/ : SUCCESS in 3m 20s\n- http://logs.openstack.org/32883/4/gate/gate-ceilometer-pep8/2831 : SUCCESS in 1m 12s\n- http://logs.openstack.org/32883/4/gate/gate-ceilometer-python26/2764 : SUCCESS in 17m 18s\n- http://logs.openstack.org/32883/4/gate/gate-ceilometer-python27/2761 : SUCCESS in 4m 04s\n","accounts_in_message":[],"_revision_number":4},{"id":"3a0a06b2257656925771c4b6d555cad919d165f0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-14 01:50:58.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"6af55da0dfa1e50e12dbdbf8ffaf96e6b0c41ef7","revisions":{"4b5de008667890ecb816625849e6d9be03f3203c":{"kind":"REWORK","_number":1,"created":"2013-06-13 13:08:26.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/83/32883/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/83/32883/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/1"}}},"commit":{"parents":[{"commit":"21f650e8ef696d409b380fc3afdb9c2b8a240215","subject":"Merge \"Use Flake8 gating for bin/ceilometer-*\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/21f650e8ef696d409b380fc3afdb9c2b8a240215"}]}],"author":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-06-13 13:07:41.000000000","tz":120},"committer":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-06-13 13:07:41.000000000","tz":120},"subject":"Code cleanup","message":"Code cleanup\n\n- Mark static methods\n- Remove some useless code\n\nChange-Id: I89f5829c75b874fdfe59bc88dad809e0d54b006a\nSigned-off-by: Julien Danjou \u003cjulien@danjou.info\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/4b5de008667890ecb816625849e6d9be03f3203c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/4b5de008667890ecb816625849e6d9be03f3203c"}]},"branch":"refs/heads/master"},"4d64257ea9265e18e17b115a06b860fe15928bcc":{"kind":"REWORK","_number":2,"created":"2013-06-13 14:18:31.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/83/32883/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/83/32883/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/2"}}},"commit":{"parents":[{"commit":"8a86298bbde9186e1b92dc020ca646e21a383337","subject":"Update Oslo","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/8a86298bbde9186e1b92dc020ca646e21a383337"}]}],"author":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-06-13 13:07:41.000000000","tz":120},"committer":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-06-13 14:14:17.000000000","tz":120},"subject":"Code cleanup","message":"Code cleanup\n\n- Mark static methods\n- Remove some useless code\n\nChange-Id: I89f5829c75b874fdfe59bc88dad809e0d54b006a\nSigned-off-by: Julien Danjou \u003cjulien@danjou.info\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/4d64257ea9265e18e17b115a06b860fe15928bcc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/4d64257ea9265e18e17b115a06b860fe15928bcc"}]},"branch":"refs/heads/master"},"594c0b42cb0bea12f9fc4c844c2fe7bd8697a1cd":{"kind":"REWORK","_number":3,"created":"2013-06-13 14:38:08.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/83/32883/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/83/32883/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/3"}}},"commit":{"parents":[{"commit":"8a86298bbde9186e1b92dc020ca646e21a383337","subject":"Update Oslo","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/8a86298bbde9186e1b92dc020ca646e21a383337"}]}],"author":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-06-13 13:07:41.000000000","tz":120},"committer":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-06-13 14:37:54.000000000","tz":120},"subject":"Code cleanup","message":"Code cleanup\n\n- Mark static methods\n- Remove some useless code\n\nChange-Id: I89f5829c75b874fdfe59bc88dad809e0d54b006a\nSigned-off-by: Julien Danjou \u003cjulien@danjou.info\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/594c0b42cb0bea12f9fc4c844c2fe7bd8697a1cd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/594c0b42cb0bea12f9fc4c844c2fe7bd8697a1cd"}]},"branch":"refs/heads/master"},"6af55da0dfa1e50e12dbdbf8ffaf96e6b0c41ef7":{"kind":"REWORK","_number":4,"created":"2013-06-13 15:19:51.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/83/32883/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/83/32883/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/83/32883/4"}}},"commit":{"parents":[{"commit":"8a86298bbde9186e1b92dc020ca646e21a383337","subject":"Update Oslo","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/8a86298bbde9186e1b92dc020ca646e21a383337"}]}],"author":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-06-13 13:07:41.000000000","tz":120},"committer":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-06-13 15:18:12.000000000","tz":120},"subject":"Code cleanup","message":"Code cleanup\n\n- Mark static methods\n- Remove some useless code\n\nChange-Id: I89f5829c75b874fdfe59bc88dad809e0d54b006a\nSigned-off-by: Julien Danjou \u003cjulien@danjou.info\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/6af55da0dfa1e50e12dbdbf8ffaf96e6b0c41ef7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/6af55da0dfa1e50e12dbdbf8ffaf96e6b0c41ef7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}