)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6de501981b072509a4f612d60f939ecc971355c9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liusheng \u003cliusheng@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-20 09:44:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Swich to use glanceclient to get image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since Nova has deprecated the API proxies, see[1], we need to switch to"},{"line_number":10,"context_line":"use glanceclient to get image in ceilometer/nova_client.py."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a9d85d2_5ea0f390","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2016-06-20 07:06:21.000000000","message":"switch","commit_id":"88eb1df6c192cbbac4b06850241626709046ad14"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"dc402e472f9790b3925f55a10b713bc74c3ed762","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liusheng \u003cliusheng@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-20 09:44:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Swich to use glanceclient to get image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since Nova has deprecated the API proxies, see[1], we need to switch to"},{"line_number":10,"context_line":"use glanceclient to get image in ceilometer/nova_client.py."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a9d85d2_2f0fafe2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"5a9d85d2_5ea0f390","updated":"2016-06-20 08:58:01.000000000","message":"Done","commit_id":"88eb1df6c192cbbac4b06850241626709046ad14"}],"ceilometer/nova_client.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"c22fc972a767aeb31998fb9eda9f1dc6850fec99","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            region_name\u003dconf.region_name,"},{"line_number":93,"context_line":"            interface\u003dconf.interface,"},{"line_number":94,"context_line":"            service_type\u003dcfg.CONF.service_types.glance,"},{"line_number":95,"context_line":"            endpoint_override\u003dendpoint_override,"},{"line_number":96,"context_line":"            auth\u003dauth)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def _with_flavor_and_image(self, instances):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_db36b6b3","line":95,"range":{"start_line":95,"start_character":30,"end_line":95,"end_character":48},"updated":"2016-06-20 07:04:16.000000000","message":"I think endpoint_override is not a True/False option but a string pointing to the real endpoint\n\nand actually the endpoint_override and auth parameters are never used, you can safely remove them from parameter list IIUC","commit_id":"88eb1df6c192cbbac4b06850241626709046ad14"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"dc402e472f9790b3925f55a10b713bc74c3ed762","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            region_name\u003dconf.region_name,"},{"line_number":93,"context_line":"            interface\u003dconf.interface,"},{"line_number":94,"context_line":"            service_type\u003dcfg.CONF.service_types.glance,"},{"line_number":95,"context_line":"            endpoint_override\u003dendpoint_override,"},{"line_number":96,"context_line":"            auth\u003dauth)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def _with_flavor_and_image(self, instances):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_ef7807fb","line":95,"range":{"start_line":95,"start_character":30,"end_line":95,"end_character":48},"in_reply_to":"5a9d85d2_db36b6b3","updated":"2016-06-20 08:58:01.000000000","message":"yes, thanks for reminding, will do it.","commit_id":"88eb1df6c192cbbac4b06850241626709046ad14"},{"author":{"_account_id":13229,"name":"Wenyan Zhang","email":"zhang.wenyan3@zte.com.cn","username":"WenyanZhang"},"change_message_id":"1052fbddc856931089379b6a4ae6da5b1cd27ada","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        else:"},{"line_number":134,"context_line":"            try:"},{"line_number":135,"context_line":"                image \u003d self.glance_client.images.get(iid)"},{"line_number":136,"context_line":"            except novaclient.exceptions.NotFound:"},{"line_number":137,"context_line":"                image \u003d None"},{"line_number":138,"context_line":"            cache[iid] \u003d image"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_3a9a1d64","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":50},"updated":"2016-06-21 06:27:32.000000000","message":"Should this been the exception such as \"glanceclient\", but not \"novaclient\"?","commit_id":"9eff65f07b8e56f603c9d09fd5f979887f7412f9"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"5a204fee8ba242a5e515662f9b75d700baa7bbb0","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        else:"},{"line_number":134,"context_line":"            try:"},{"line_number":135,"context_line":"                image \u003d self.glance_client.images.get(iid)"},{"line_number":136,"context_line":"            except novaclient.exceptions.NotFound:"},{"line_number":137,"context_line":"                image \u003d None"},{"line_number":138,"context_line":"            cache[iid] \u003d image"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_1a7121e1","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":50},"in_reply_to":"5a9d85d2_3a9a1d64","updated":"2016-06-21 06:29:15.000000000","message":"oh, thanks for reminding me, my mistake.","commit_id":"9eff65f07b8e56f603c9d09fd5f979887f7412f9"}],"ceilometer/tests/unit/test_novaclient.py":[{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"59594ec02c1de25b9e3af88b221b8db0c180c6a6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            a.name \u003d image_details[a.id][0]"},{"line_number":66,"context_line":"            a.metadata \u003d image_details[a.id][1]"},{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            raise novaclient.exceptions.NotFound(\u0027foobar\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        return a"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_35c69d49","line":68,"range":{"start_line":68,"start_character":18,"end_line":68,"end_character":28},"updated":"2016-06-21 12:51:08.000000000","message":"Maybe some wrongs with this, but I\u0027m not sure.","commit_id":"8f7bde563aaac9b5e89da6d7b0392952d242d13e"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"3dff581491cae066dc04cc13070468c3dfdd29ed","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            a.name \u003d image_details[a.id][0]"},{"line_number":66,"context_line":"            a.metadata \u003d image_details[a.id][1]"},{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            raise novaclient.exceptions.NotFound(\u0027foobar\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        return a"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_5ecaa8a2","line":68,"range":{"start_line":68,"start_character":18,"end_line":68,"end_character":28},"in_reply_to":"5a9d85d2_35c69d49","updated":"2016-06-22 01:41:31.000000000","message":"right, it should be \"glanceclient.exc.HTTPNotFound\"","commit_id":"8f7bde563aaac9b5e89da6d7b0392952d242d13e"}]}