)]}'
{"id":"openstack%2Fceilometer~34014","triplet_id":"openstack%2Fceilometer~master~Id999005e4de5d77309b0a32ad582804525ec1494","project":"openstack/ceilometer","branch":"master","hashtags":[],"change_id":"Id999005e4de5d77309b0a32ad582804525ec1494","subject":"Change period type in alarms API to int.","status":"MERGED","created":"2013-06-21 16:38:55.000000000","updated":"2013-06-24 10:00:59.000000000","submitted":"2013-06-24 10:00:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"24a4c6bbf3d378394792016f5dacf9a8ebab3af7","_number":34014,"virtual_id_number":34014,"owner":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-06-24 10:00:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-06-24 09:42:56.000000000","_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":2,"date":"2013-06-24 01:23:57.000000000","_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-06-24 09:42:56.000000000","_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"date":"2013-06-24 01:23:57.000000000","_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},{"value":0,"date":"2013-06-21 16:40:48.000000000","_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-06-24 01:23:57.000000000","updated_by":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"reviewer":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"state":"REVIEWER"},{"updated":"2013-06-24 09:42:56.000000000","updated_by":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"reviewer":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"state":"REVIEWER"},{"updated":"2013-06-24 10:00:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6fe2c65e155ce9e0e3e11979ba6e28ecbe786518","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2013-06-21 16:40:48.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cc18adb8aab9d365ae9f22d7109c96b08820064c","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-06-21 16:40:53.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"47c8f6f37bccb52d55683f504252a96871db7a33","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-21 16:59:49.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/34014/2/check/gate-ceilometer-pep8/2912 : SUCCESS in 1m 10s\n- http://docs-draft.openstack.org/34014/2/check/gate-ceilometer-docs/1717/doc/build/html/ : SUCCESS in 3m 43s\n- http://logs.openstack.org/34014/2/check/gate-ceilometer-python26/2845 : SUCCESS in 18m 56s\n- http://logs.openstack.org/34014/2/check/gate-ceilometer-python27/2842 : SUCCESS in 4m 25s\n","accounts_in_message":[],"_revision_number":2},{"id":"a72cffab02fa69b480fcd515d627d53d4008c1b7","author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"date":"2013-06-24 01:23:57.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nWe have only just added the API and the backend is not functional, so I think the API is up for grabs as no one can\nactually use alarms yet.","accounts_in_message":[],"_revision_number":2},{"id":"6c105a918cf633ad19e5167e76fd7af536fe1cd8","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-06-24 09:42:56.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"e52acede2da739544f69905b458c4945b4fa9043","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-24 09:42:58.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"3686673a4477b7390efb0929f2ea4a7dc8cd6a57","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-24 10:00:59.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"24a4c6bbf3d378394792016f5dacf9a8ebab3af7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-24 10:00:59.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/34014/2/gate/gate-ceilometer-docs/1736/doc/build/html/ : SUCCESS in 3m 18s\n- http://logs.openstack.org/34014/2/gate/gate-ceilometer-pep8/2931 : SUCCESS in 1m 16s\n- http://logs.openstack.org/34014/2/gate/gate-ceilometer-python26/2864 : SUCCESS in 17m 58s\n- http://logs.openstack.org/34014/2/gate/gate-ceilometer-python27/2861 : SUCCESS in 4m 56s\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4c9bf8a130127c3311add686f4b59c226984919a","revisions":{"780085cfe63c4926bc8d49a75fe31450d947728b":{"kind":"REWORK","_number":1,"created":"2013-06-21 16:38:55.000000000","uploader":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"ref":"refs/changes/14/34014/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/14/34014/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/14/34014/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/14/34014/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/14/34014/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/14/34014/1"}}},"commit":{"parents":[{"commit":"0dd652412e33f8c6c0b6c9cf2129867e0e179369","subject":"Merge \"Imported Translations from Transifex\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/0dd652412e33f8c6c0b6c9cf2129867e0e179369"}]}],"author":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-06-21 16:11:06.000000000","tz":0},"committer":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-06-21 16:30:40.000000000","tz":60},"subject":"Change period type in alarms API to int.","message":"Change period type in alarms API to int.\n\nPreviously this was float, which looks like an over-sight,\nas we will not be supporting sub-second evaluation.\n\nAlso float is a mismatch with the v2 statistics API, which\nrequires that the given period be an int (the alarm period\nis passed to the statistics API).\n\nFinally, the sqlalchmey schema defines the period as Integer,\nso it makes no sense for the types stored mongo \u0026 mysql to\ndiffer.\n\nSubmitting this one-liner as a separate patch, as it may be\nslightly controversial because it requires that all existing\nalarms stored in mongo be deleted and re-created (as we don\u0027t\nhave a schema migration mechnanism for mongo).\n\nChange-Id: Id999005e4de5d77309b0a32ad582804525ec1494\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/780085cfe63c4926bc8d49a75fe31450d947728b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/780085cfe63c4926bc8d49a75fe31450d947728b"}]},"branch":"refs/heads/master"},"4c9bf8a130127c3311add686f4b59c226984919a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-06-21 16:40:48.000000000","uploader":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"ref":"refs/changes/14/34014/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/14/34014/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/14/34014/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/14/34014/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/14/34014/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/14/34014/2"}}},"commit":{"parents":[{"commit":"0dd652412e33f8c6c0b6c9cf2129867e0e179369","subject":"Merge \"Imported Translations from Transifex\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/0dd652412e33f8c6c0b6c9cf2129867e0e179369"}]}],"author":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-06-21 16:11:06.000000000","tz":0},"committer":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-06-21 16:32:58.000000000","tz":60},"subject":"Change period type in alarms API to int.","message":"Change period type in alarms API to int.\n\nPreviously this was float, which looks like an over-sight,\nas we will not be supporting sub-second evaluation.\n\nAlso float is a mismatch with the v2 statistics API, which\nrequires that the given period be an int (the alarm period\nis passed to the statistics API during threshold eval).\n\nFinally, the sqlalchmey schema defines the period as Integer,\nso it makes no sense for the types stored mongo \u0026 mysql to\ndiffer.\n\nSubmitting this one-liner as a separate patch, as it may be\nslightly controversial because it requires that all existing\nalarms stored in mongo be deleted and re-created (as we don\u0027t\nhave a schema migration mechnanism for mongo).\n\nChange-Id: Id999005e4de5d77309b0a32ad582804525ec1494\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/4c9bf8a130127c3311add686f4b59c226984919a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/4c9bf8a130127c3311add686f4b59c226984919a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}