)]}'
{"ceilometer/compute/virt/libvirt/inspector.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"cf0ffc60bb6bb69f330e077843b32462f8ba4df0","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                                           allocation\u003dblock_info[1],"},{"line_number":220,"context_line":"                                           physical\u003dblock_info[2])"},{"line_number":221,"context_line":"            except libvirt.libvirtError as e:"},{"line_number":222,"context_line":"                _LW(\u0027Failed to inspect disk usage of %(instance_uuid)s, \u0027"},{"line_number":223,"context_line":"                    \u0027can not get info from libvirt: %(error)s\u0027) % {"},{"line_number":224,"context_line":"                    \u0027instance_uuid\u0027: instance.id, \u0027error\u0027: e}"},{"line_number":225,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_bd781990","line":222,"updated":"2016-07-13 14:17:34.000000000","message":"this needs to be raised or logged. that said, is there a more specific error we can catch? LibvirtError seems pretty generic.","commit_id":"9b5dcaa812b217b8b6dc1c9b1d73419b342a04b1"},{"author":{"_account_id":21356,"name":"Ildar Svetlov","email":"isvetlov@mirantis.com","username":"isvetlov"},"change_message_id":"10a79967dfa5799cdb395c687860cd2495a7f2c7","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                                           allocation\u003dblock_info[1],"},{"line_number":220,"context_line":"                                           physical\u003dblock_info[2])"},{"line_number":221,"context_line":"            except libvirt.libvirtError as e:"},{"line_number":222,"context_line":"                _LW(\u0027Failed to inspect disk usage of %(instance_uuid)s, \u0027"},{"line_number":223,"context_line":"                    \u0027can not get info from libvirt: %(error)s\u0027) % {"},{"line_number":224,"context_line":"                    \u0027instance_uuid\u0027: instance.id, \u0027error\u0027: e}"},{"line_number":225,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_e24927b9","line":222,"in_reply_to":"1aa78d24_bd781990","updated":"2016-07-14 14:15:04.000000000","message":"we cant catch more specific error, because libvirt raise LibvirtError for this situation.\nto catch this specific case, should add check of disk \"type\", and if disk type is \"network\", log this and skip this device.\ni done it in next patch","commit_id":"9b5dcaa812b217b8b6dc1c9b1d73419b342a04b1"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9c9e2b9dbcfa701a136e3030085f2b1c593b0f95","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            disk_type \u003d disk.get(\u0027type\u0027)"},{"line_number":211,"context_line":"            if disk_type:"},{"line_number":212,"context_line":"                if disk_type \u003d\u003d \u0027network\u0027:"},{"line_number":213,"context_line":"                    _LW(\u0027Inspection disk usage of network disk \u0027"},{"line_number":214,"context_line":"                        \u0027%(instance_uuid)s unsupported by libvirt\u0027) % {"},{"line_number":215,"context_line":"                        \u0027instance_uuid\u0027: instance.id}"},{"line_number":216,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_9694c544","line":213,"range":{"start_line":213,"start_character":20,"end_line":213,"end_character":64},"updated":"2016-07-15 01:40:33.000000000","message":"LOG.warning ?","commit_id":"60a75edca852670e99c03131c4591e103bd2ca6d"},{"author":{"_account_id":21356,"name":"Ildar Svetlov","email":"isvetlov@mirantis.com","username":"isvetlov"},"change_message_id":"07e4b52c48999b0d7cdd22d2ec03841a3b70a1c4","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            disk_type \u003d disk.get(\u0027type\u0027)"},{"line_number":211,"context_line":"            if disk_type:"},{"line_number":212,"context_line":"                if disk_type \u003d\u003d \u0027network\u0027:"},{"line_number":213,"context_line":"                    _LW(\u0027Inspection disk usage of network disk \u0027"},{"line_number":214,"context_line":"                        \u0027%(instance_uuid)s unsupported by libvirt\u0027) % {"},{"line_number":215,"context_line":"                        \u0027instance_uuid\u0027: instance.id}"},{"line_number":216,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_57dd6f6f","line":213,"range":{"start_line":213,"start_character":20,"end_line":213,"end_character":64},"in_reply_to":"1aa78d24_9694c544","updated":"2016-07-18 07:53:30.000000000","message":"What log.level would you prefer in this case?","commit_id":"60a75edca852670e99c03131c4591e103bd2ca6d"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"f9eed1e6a4a44e899acf4a13a00a9ec37537c841","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            disk_type \u003d disk.get(\u0027type\u0027)"},{"line_number":211,"context_line":"            if disk_type:"},{"line_number":212,"context_line":"                if disk_type \u003d\u003d \u0027network\u0027:"},{"line_number":213,"context_line":"                    _LW(\u0027Inspection disk usage of network disk \u0027"},{"line_number":214,"context_line":"                        \u0027%(instance_uuid)s unsupported by libvirt\u0027) % {"},{"line_number":215,"context_line":"                        \u0027instance_uuid\u0027: instance.id}"},{"line_number":216,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_7ac4d791","line":213,"range":{"start_line":213,"start_character":20,"end_line":213,"end_character":64},"in_reply_to":"dada55a8_57dd6f6f","updated":"2016-07-18 08:58:27.000000000","message":"I meant that you missed a LOG.warning, only a \"_LW\"","commit_id":"60a75edca852670e99c03131c4591e103bd2ca6d"},{"author":{"_account_id":21356,"name":"Ildar Svetlov","email":"isvetlov@mirantis.com","username":"isvetlov"},"change_message_id":"a0c3f3db9fe4c1c5bebeba2fb5dc957b62b4ec2c","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            disk_type \u003d disk.get(\u0027type\u0027)"},{"line_number":211,"context_line":"            if disk_type:"},{"line_number":212,"context_line":"                if disk_type \u003d\u003d \u0027network\u0027:"},{"line_number":213,"context_line":"                    _LW(\u0027Inspection disk usage of network disk \u0027"},{"line_number":214,"context_line":"                        \u0027%(instance_uuid)s unsupported by libvirt\u0027) % {"},{"line_number":215,"context_line":"                        \u0027instance_uuid\u0027: instance.id}"},{"line_number":216,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_5d374de3","line":213,"range":{"start_line":213,"start_character":20,"end_line":213,"end_character":64},"in_reply_to":"dada55a8_7ac4d791","updated":"2016-07-18 09:14:25.000000000","message":"Done","commit_id":"60a75edca852670e99c03131c4591e103bd2ca6d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"e39b29d142f2483fda3e840237167513841bc341","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            if disk_type:"},{"line_number":212,"context_line":"                if disk_type \u003d\u003d \u0027network\u0027:"},{"line_number":213,"context_line":"                    LOG.warning("},{"line_number":214,"context_line":"                        _LW(\u0027Inspection disk usage of network disk \u0027"},{"line_number":215,"context_line":"                            \u0027%(instance_uuid)s unsupported by libvirt\u0027) % {"},{"line_number":216,"context_line":"                            \u0027instance_uuid\u0027: instance.id})"},{"line_number":217,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_99ab8789","line":214,"updated":"2016-07-18 14:52:40.000000000","message":"s/Inspection/Inspecting/","commit_id":"3b14d40a27ba3ceea418e6c0eb18dd2e9fbef6c6"}]}