)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1918,"name":"François Charlier","email":"francois.charlier@redhat.com","username":"francois-charlier"},"change_message_id":"3a710e524ad7e2b2735227b56528f9eff1fae20b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"As a result, when the primary mongod node is down, ceilometer can"},{"line_number":11,"context_line":"not write or read meters."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Use pymongo.Connection object\u0027s replicaSet param will let the mongodb"},{"line_number":14,"context_line":"connection support replication set."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8404ca5b08b6e73366161c07b3815f75bed7e0eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAPn%2F%2Fnsg%3D","line":13,"updated":"2013-06-26 15:50:46.000000000","message":"Would you eventually complete this statement with : \"[replicaSet param] and allowing to connect with a host seed list [will let the]\"\n\nI also tested this changeset and except my previous remark it looks good to me !","commit_id":"c3062ab319c264c381ab7259be08597f9673dedf"}],"ceilometer/storage/impl_mongodb.py":[{"author":{"_account_id":1918,"name":"François Charlier","email":"francois.charlier@redhat.com","username":"francois-charlier"},"change_message_id":"9fa1a14e8362505fe19d60e65b7b7b4a71b440f1","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    OPTIONS \u003d ["},{"line_number":71,"context_line":"        cfg.StrOpt(\u0027replica_set_name\u0027,"},{"line_number":72,"context_line":"                   default\u003dNone,"},{"line_number":73,"context_line":"                   help\u003d\u0027Used to identify the replication set name\u0027,"},{"line_number":74,"context_line":"                   ),"},{"line_number":75,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FujE%3D","line":72,"updated":"2013-06-24 11:34:26.000000000","message":"You should set default to empty string, allowing to always pass the parameter to pymongo.Connection().\n\nThe \"_create_pymongo_connection()\" method can be removed and the \"replicaset\u003d…\" parameter can be added directly in \"self.conn \u003d pymongo.Connection(…)\"","commit_id":"13c7f3318ea0e2100ee542f1ec04d3eb0c811553"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"641c8704cfa65b79bbb38e0eddc5b4e5aa97ea86","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                   ),"},{"line_number":75,"context_line":"    ]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    OPTION_GROUP \u003d cfg.OptGroup(name\u003d\u0027mongodb\u0027,"},{"line_number":78,"context_line":"                                title\u003d\u0027Options for the mongodb storage\u0027)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def register_opts(self, conf):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPn%2F%2Fdi0%3D","line":77,"updated":"2013-07-01 13:46:18.000000000","message":"storage_mongodb would be better I think","commit_id":"5e13549714b226220993eed4bcb5fe7edeb13c44"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"641c8704cfa65b79bbb38e0eddc5b4e5aa97ea86","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    # FIXME(xingzhou): ceilometer-api will create a Connection object for"},{"line_number":87,"context_line":"    # each request. As pymongo.Connection has already maintained a db"},{"line_number":88,"context_line":"    # connection pool for client, it is better to use a cached Connection"},{"line_number":89,"context_line":"    # object to connect to mongodb."},{"line_number":90,"context_line":"    def get_connection(self, conf):"},{"line_number":91,"context_line":"        \"\"\"Return a Connection instance based on the configuration settings."},{"line_number":92,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPn%2F%2Fdis%3D","line":89,"updated":"2013-07-01 13:46:18.000000000","message":"Yes we have a bug about this.","commit_id":"5e13549714b226220993eed4bcb5fe7edeb13c44"},{"author":{"_account_id":7302,"name":"xingzhou","email":"xingzhou@cn.ibm.com","username":"xingzhou"},"change_message_id":"c02db63b214d2736fb2bfe090ac791fc912ffa67","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    # FIXME(xingzhou): ceilometer-api will create a Connection object for"},{"line_number":87,"context_line":"    # each request. As pymongo.Connection has already maintained a db"},{"line_number":88,"context_line":"    # connection pool for client, it is better to use a cached Connection"},{"line_number":89,"context_line":"    # object to connect to mongodb."},{"line_number":90,"context_line":"    def get_connection(self, conf):"},{"line_number":91,"context_line":"        \"\"\"Return a Connection instance based on the configuration settings."},{"line_number":92,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPn%2F%2Fbjs%3D","line":89,"in_reply_to":"AAAAPn%2F%2Fdis%3D","updated":"2013-07-02 05:07:48.000000000","message":"@jd__, is this the bug that fixes this issue: https://bugs.launchpad.net/ceilometer/+bug/1178845? if so, I had a discussion with Doug, but he said this bug is only for scanning the plug-in once. if it\u0027s ok, I would like to open new defect on this issue to fix it.","commit_id":"5e13549714b226220993eed4bcb5fe7edeb13c44"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"8781b2ea400fbb4a6be4edefccf0d99e4138912f","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        opts \u003d self._parse_connection_url(conf.database.connection)"},{"line_number":214,"context_line":"        LOG.info(\u0027connecting to MongoDB replicaset \"%s\" on %s\u0027,"},{"line_number":215,"context_line":"                 conf.mongodb.replica_set_name,"},{"line_number":216,"context_line":"                 opts[\u0027netloc\u0027])"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        if opts[\u0027netloc\u0027] \u003d\u003d \u0027__test__\u0027:"},{"line_number":219,"context_line":"            url \u003d os.environ.get(\u0027CEILOMETER_TEST_MONGODB_URL\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPn%2F%2Fh0Q%3D","line":216,"updated":"2013-06-28 13:55:03.000000000","message":"this log should be moved and paired with the actual replicaset connection","commit_id":"5e13549714b226220993eed4bcb5fe7edeb13c44"},{"author":{"_account_id":7302,"name":"xingzhou","email":"xingzhou@cn.ibm.com","username":"xingzhou"},"change_message_id":"a4284d58f7b20d92eb0676886f64182620632e0b","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        opts \u003d self._parse_connection_url(conf.database.connection)"},{"line_number":214,"context_line":"        LOG.info(\u0027connecting to MongoDB replicaset \"%s\" on %s\u0027,"},{"line_number":215,"context_line":"                 conf.mongodb.replica_set_name,"},{"line_number":216,"context_line":"                 opts[\u0027netloc\u0027])"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        if opts[\u0027netloc\u0027] \u003d\u003d \u0027__test__\u0027:"},{"line_number":219,"context_line":"            url \u003d os.environ.get(\u0027CEILOMETER_TEST_MONGODB_URL\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPn%2F%2FeDU%3D","line":216,"in_reply_to":"AAAAPn%2F%2Fh0Q%3D","updated":"2013-07-01 09:38:37.000000000","message":"@gordon, currently, pymongo.Connection is using replicaset only to verify whether a node belongs to the set. So Connection object only use the replicaSet param inputted. I\u0027ve a review of the Connection code and seems there is no method to return the replica set name","commit_id":"5e13549714b226220993eed4bcb5fe7edeb13c44"}]}
