)]}'
{"ceilometer/compute/pollsters/memory.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"a4adcf030bb79da050786bc4f900d17997a04c4a","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            volume\u003dgetattr(c_data, _element),"},{"line_number":139,"context_line":"        )]"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":142,"context_line":"        self._inspection_duration \u003d self._record_poll_time()"},{"line_number":143,"context_line":"        for instance in resources:"},{"line_number":144,"context_line":"            LOG.debug(\u0027Checking resident memory for instance %s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_4a2958e5","line":141,"range":{"start_line":141,"start_character":51,"end_line":141,"end_character":53},"updated":"2016-07-22 02:51:50.000000000","message":"we should leverage the cache just like the disk pollsters in https://github.com/openstack/ceilometer/blob/master/ceilometer/compute/pollsters/disk.py, there is no need to call the virt inspector twice to get both local and total bandwidth metrics, because hte virt inspector gives us both metrics in one call.","commit_id":"0bbdf31e92c0affe407250aa01da1b1a979e3963"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"1b6b3e5d3a4ef3ab824889df1ba8266c81308b46","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @abc.abstractmethod"},{"line_number":145,"context_line":"    def _get_samples(self, instance, c_data):"},{"line_number":146,"context_line":"        \"\"\"Return one or more Sample.\"\"\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _get_sample_total_and_local(self, instance, _name, _unit,"},{"line_number":149,"context_line":"                                    c_data, _element):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_6a2b5731","line":146,"range":{"start_line":146,"start_character":35,"end_line":146,"end_character":36},"updated":"2016-07-28 03:43:13.000000000","message":"s","commit_id":"98eab092909bcea463bd79ffd11b2dca75394319"}],"ceilometer/tests/unit/compute/pollsters/test_memory.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"a4adcf030bb79da050786bc4f900d17997a04c4a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    def test_get_samples(self):"},{"line_number":144,"context_line":"        next_value \u003d iter(("},{"line_number":145,"context_line":"            virt_inspector.MemoryBandwidthStats(total\u003d1892352, local\u003d1802240),"},{"line_number":146,"context_line":"            virt_inspector.MemoryBandwidthStats(total\u003d1081344, local\u003d90112),"},{"line_number":147,"context_line":"        ))"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        def inspect_memory_bandwidth(instance, duration):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_6ac25c54","line":146,"range":{"start_line":146,"start_character":74,"end_line":146,"end_character":76},"updated":"2016-07-22 02:51:50.000000000","message":"it would be much nice to test on the raise of NoDataException(), like TestResidentMemoryPollster does.","commit_id":"0bbdf31e92c0affe407250aa01da1b1a979e3963"}]}