)]}'
{"ceilometer/storage/impl_hbase.py":[{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"ebb7589140d01c33d416c1262b88658ba05e6234","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                self.conn \u003d self._get_connection(opts)"},{"line_number":107,"context_line":"            else:"},{"line_number":108,"context_line":"                # This is a in-memory usage for unit tests"},{"line_number":109,"context_line":"                if Connection._memory_instance is None:"},{"line_number":110,"context_line":"                    LOG.debug(\u0027Creating a new in-memory HBase \u0027"},{"line_number":111,"context_line":"                              \u0027Connection object\u0027)"},{"line_number":112,"context_line":"                    Connection._memory_instance \u003d MConnection()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FasM%3D","line":109,"updated":"2013-07-02 12:47:39.000000000","message":"missing test","commit_id":"d186b86862ed9007f54c736aebb19f905f614a90"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"unresolved":false,"context_lines":[{"line_number":106,"context_line":"                self.conn \u003d self._get_connection(opts)"},{"line_number":107,"context_line":"            else:"},{"line_number":108,"context_line":"                # This is a in-memory usage for unit tests"},{"line_number":109,"context_line":"                if Connection._memory_instance is None:"},{"line_number":110,"context_line":"                    LOG.debug(\u0027Creating a new in-memory HBase \u0027"},{"line_number":111,"context_line":"                              \u0027Connection object\u0027)"},{"line_number":112,"context_line":"                    Connection._memory_instance \u003d MConnection()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FZZ0%3D","line":109,"in_reply_to":"AAAAPn%2F%2FZj8%3D","updated":"2013-07-02 19:00:58.000000000","message":"If that\u0027s the case, perhaps it would be better to pass in the MConnection() object as a parameter via the tests and default to the _get_connection() call if not provided. \n\nBetter to keep unit test code out of the production code.\n\nBut, essentially, all code paths should have tests.","commit_id":"d186b86862ed9007f54c736aebb19f905f614a90"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"14af9d7cd7b1f75ff0f9c297e3341d2d158a88a0","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                self.conn \u003d self._get_connection(opts)"},{"line_number":107,"context_line":"            else:"},{"line_number":108,"context_line":"                # This is a in-memory usage for unit tests"},{"line_number":109,"context_line":"                if Connection._memory_instance is None:"},{"line_number":110,"context_line":"                    LOG.debug(\u0027Creating a new in-memory HBase \u0027"},{"line_number":111,"context_line":"                              \u0027Connection object\u0027)"},{"line_number":112,"context_line":"                    Connection._memory_instance \u003d MConnection()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FZj8%3D","line":109,"in_reply_to":"AAAAPn%2F%2FasM%3D","updated":"2013-07-02 18:03:28.000000000","message":"not sure what you wanted tested here. this is for unit tests only, should it test that we\u0027re actually using this?","commit_id":"d186b86862ed9007f54c736aebb19f905f614a90"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"ebb7589140d01c33d416c1262b88658ba05e6234","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                              \u0027Connection object\u0027)"},{"line_number":112,"context_line":"                    Connection._memory_instance \u003d MConnection()"},{"line_number":113,"context_line":"                self.conn \u003d Connection._memory_instance"},{"line_number":114,"context_line":"        else:"},{"line_number":115,"context_line":"            self.conn \u003d self._get_connection(opts)"},{"line_number":116,"context_line":"        self.conn.open()"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FasE%3D","line":114,"updated":"2013-07-02 12:47:39.000000000","message":"missing test","commit_id":"d186b86862ed9007f54c736aebb19f905f614a90"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"unresolved":false,"context_lines":[{"line_number":111,"context_line":"                              \u0027Connection object\u0027)"},{"line_number":112,"context_line":"                    Connection._memory_instance \u003d MConnection()"},{"line_number":113,"context_line":"                self.conn \u003d Connection._memory_instance"},{"line_number":114,"context_line":"        else:"},{"line_number":115,"context_line":"            self.conn \u003d self._get_connection(opts)"},{"line_number":116,"context_line":"        self.conn.open()"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FZZA%3D","line":114,"in_reply_to":"AAAAPn%2F%2FZkA%3D","updated":"2013-07-02 19:00:58.000000000","message":"Basically we want to ensure all code paths are covered by tests to ensure there are no errors that only show up under certain deployment conditions.","commit_id":"d186b86862ed9007f54c736aebb19f905f614a90"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"14af9d7cd7b1f75ff0f9c297e3341d2d158a88a0","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                              \u0027Connection object\u0027)"},{"line_number":112,"context_line":"                    Connection._memory_instance \u003d MConnection()"},{"line_number":113,"context_line":"                self.conn \u003d Connection._memory_instance"},{"line_number":114,"context_line":"        else:"},{"line_number":115,"context_line":"            self.conn \u003d self._get_connection(opts)"},{"line_number":116,"context_line":"        self.conn.open()"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FZkA%3D","line":114,"in_reply_to":"AAAAPn%2F%2FasE%3D","updated":"2013-07-02 18:03:28.000000000","message":"could you let me know what you wanted tested here? did you want a test that shows a valid connection is made? i would assume i would need to mock a new _get_connection for this since we\u0027re not testing against a real hbase","commit_id":"d186b86862ed9007f54c736aebb19f905f614a90"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"ebb7589140d01c33d416c1262b88658ba05e6234","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                        \u0027f:m_%s\u0027 % new_meter: \"1\""},{"line_number":209,"context_line":"                        }"},{"line_number":210,"context_line":"        # store metadata fields with prefix \"r_\""},{"line_number":211,"context_line":"        if data[\u0027resource_metadata\u0027]:"},{"line_number":212,"context_line":"            resource_metadata \u003d dict((\u0027f:r_%s\u0027 % k, v)"},{"line_number":213,"context_line":"                                     for (k, v)"},{"line_number":214,"context_line":"                                     in data[\u0027resource_metadata\u0027].iteritems())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2Far4%3D","line":211,"updated":"2013-07-02 12:47:39.000000000","message":"missing test","commit_id":"d186b86862ed9007f54c736aebb19f905f614a90"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"unresolved":false,"context_lines":[{"line_number":208,"context_line":"                        \u0027f:m_%s\u0027 % new_meter: \"1\""},{"line_number":209,"context_line":"                        }"},{"line_number":210,"context_line":"        # store metadata fields with prefix \"r_\""},{"line_number":211,"context_line":"        if data[\u0027resource_metadata\u0027]:"},{"line_number":212,"context_line":"            resource_metadata \u003d dict((\u0027f:r_%s\u0027 % k, v)"},{"line_number":213,"context_line":"                                     for (k, v)"},{"line_number":214,"context_line":"                                     in data[\u0027resource_metadata\u0027].iteritems())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FZT4%3D","line":211,"in_reply_to":"AAAAPn%2F%2Fagk%3D","updated":"2013-07-02 19:00:58.000000000","message":"Hmm, gotcha. I always assume that x.y.MyClass has a test in tests.x.y.test_myclass (vs looking in tests.api...)\n\nThanks ... larger problem I fear.","commit_id":"d186b86862ed9007f54c736aebb19f905f614a90"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"14af9d7cd7b1f75ff0f9c297e3341d2d158a88a0","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                        \u0027f:m_%s\u0027 % new_meter: \"1\""},{"line_number":209,"context_line":"                        }"},{"line_number":210,"context_line":"        # store metadata fields with prefix \"r_\""},{"line_number":211,"context_line":"        if data[\u0027resource_metadata\u0027]:"},{"line_number":212,"context_line":"            resource_metadata \u003d dict((\u0027f:r_%s\u0027 % k, v)"},{"line_number":213,"context_line":"                                     for (k, v)"},{"line_number":214,"context_line":"                                     in data[\u0027resource_metadata\u0027].iteritems())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2Fagk%3D","line":211,"in_reply_to":"AAAAPn%2F%2Far4%3D","updated":"2013-07-02 18:03:28.000000000","message":"this is tested by: tests.api.v2.test_impl_hbase.TestListResources.test_instance_no_metadata.\n\nit was just never run against hbase so the error was never detected until test was enabled.","commit_id":"d186b86862ed9007f54c736aebb19f905f614a90"}],"ceilometer/storage/impl_sqlalchemy.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"19b534b43c2daa01d08eccb025853a3ceb4e974f","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        :param resource: Optional resource filter."},{"line_number":254,"context_line":"        \"\"\""},{"line_number":255,"context_line":"        session \u003d sqlalchemy_session.get_session()"},{"line_number":256,"context_line":"        query \u003d session.query(Meter).group_by(Meter.resource_id)"},{"line_number":257,"context_line":"        if user is not None:"},{"line_number":258,"context_line":"            query \u003d query.filter(Meter.user_id \u003d\u003d user)"},{"line_number":259,"context_line":"        if source is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FihI%3D","line":256,"updated":"2013-06-28 07:59:37.000000000","message":"In this patch, really?","commit_id":"beaa2eda276b5a3691652a909a6a48503c85f520"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5d4b3337adbd414dec5014d92de3fba3158bf45b","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        :param resource: Optional resource filter."},{"line_number":254,"context_line":"        \"\"\""},{"line_number":255,"context_line":"        session \u003d sqlalchemy_session.get_session()"},{"line_number":256,"context_line":"        query \u003d session.query(Meter).group_by(Meter.resource_id)"},{"line_number":257,"context_line":"        if user is not None:"},{"line_number":258,"context_line":"            query \u003d query.filter(Meter.user_id \u003d\u003d user)"},{"line_number":259,"context_line":"        if source is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FiE0%3D","line":256,"in_reply_to":"AAAAPn%2F%2FihI%3D","updated":"2013-06-28 12:24:40.000000000","message":":( i\u0027ll drop it.","commit_id":"beaa2eda276b5a3691652a909a6a48503c85f520"}]}