)]}'
{"ceilometer/dispatcher/database.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"a688962331b3d8356da02f1cc18254dc1554e2e5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self._conn \u003d self._get_db_conn(conf, self.CONNECTION_TYPE, True)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _get_db_conn(self, conf, purpose, ignore_exception\u003dFalse):"},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            return storage.get_connection_from_config(conf, purpose)"},{"line_number":47,"context_line":"        except Exception as err:"},{"line_number":48,"context_line":"            params \u003d {\"purpose\": purpose, \"err\": err}"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_778120c3","side":"PARENT","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":12},"updated":"2016-08-10 09:48:13.000000000","message":"Why did you remove this try-except block?","commit_id":"28127f2d0153ac5168539c2e9353fa4f3cbc6652"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"264e10c4da0a659b8d51605ad173a95bcd65502b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self._conn \u003d self._get_db_conn(conf, self.CONNECTION_TYPE, True)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _get_db_conn(self, conf, purpose, ignore_exception\u003dFalse):"},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            return storage.get_connection_from_config(conf, purpose)"},{"line_number":47,"context_line":"        except Exception as err:"},{"line_number":48,"context_line":"            params \u003d {\"purpose\": purpose, \"err\": err}"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_f815eb3f","side":"PARENT","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":12},"in_reply_to":"9ad45d7e_778120c3","updated":"2016-08-10 15:24:39.000000000","message":"ignore_exception is removed so it\u0027s equivalent to be always true and raising. I just removed the whole logging exception part finally, as it\u0027s ought to be logged above anyway.","commit_id":"28127f2d0153ac5168539c2e9353fa4f3cbc6652"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1b0f581cdbf0dc8a602495b24eb4a8b514ec4dd0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self._conn \u003d self._get_db_conn(conf, self.CONNECTION_TYPE, True)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _get_db_conn(self, conf, purpose, ignore_exception\u003dFalse):"},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            return storage.get_connection_from_config(conf, purpose)"},{"line_number":47,"context_line":"        except Exception as err:"},{"line_number":48,"context_line":"            params \u003d {\"purpose\": purpose, \"err\": err}"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_059a8914","side":"PARENT","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":12},"in_reply_to":"9ad45d7e_f815eb3f","updated":"2016-08-15 15:05:03.000000000","message":"Ah, makes sense. Thanks for clarifying!","commit_id":"28127f2d0153ac5168539c2e9353fa4f3cbc6652"}]}