)]}'
{"ceilometer/hardware/inspector/snmp.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"b6ca3317e504e038e39a1b12a2c8140d3ffc8a07","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                value \u003d converter(value)"},{"line_number":197,"context_line":"            except ValueError:"},{"line_number":198,"context_line":"                if isinstance(value, NoSuchObject):"},{"line_number":199,"context_line":"                    return None"},{"line_number":200,"context_line":"        return value"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_773f6087","line":199,"range":{"start_line":199,"start_character":20,"end_line":199,"end_character":31},"updated":"2016-08-10 09:42:02.000000000","message":"I think it would be good to add a debug log here as well.","commit_id":"b71b4e1f27a6ce5de736770cdff8fb479be6efbb"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ec65bb7b95379c8958ced4de07634073ded593bf","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log"},{"line_number":21,"context_line":"from pysnmp.entity.rfc3413.oneliner import cmdgen"},{"line_number":22,"context_line":"from pysnmp.proto.rfc1905 import NoSuchObject"},{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":"import six.moves.urllib.parse as urlparse"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_67d02e20","line":22,"updated":"2016-08-10 20:58:04.000000000","message":"nit: you should import the class but the module:\n\n  from pysnmp.proto import rfc1905","commit_id":"9d907e97608082311e4f812d44c6d512c472b26d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ec65bb7b95379c8958ced4de07634073ded593bf","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            try:"},{"line_number":200,"context_line":"                value \u003d converter(value)"},{"line_number":201,"context_line":"            except ValueError:"},{"line_number":202,"context_line":"                if isinstance(value, NoSuchObject):"},{"line_number":203,"context_line":"                    LOG.debug(\"OID %s%s has no value\" % ("},{"line_number":204,"context_line":"                        oid, \" on %s\" % host.hostname if host else \"\"))"},{"line_number":205,"context_line":"                    return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_67978e48","line":202,"updated":"2016-08-10 20:58:04.000000000","message":"s/NoSuchObject/rfc1905.NoSuchObject/","commit_id":"9d907e97608082311e4f812d44c6d512c472b26d"}]}