)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"bca0ef06024533d02777be8ce10c8f2598a3a6d1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix flake8 errors"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix exclude rules so we do not run flake8 against code in the build,"},{"line_number":10,"context_line":".tox, or openstack/common directories since this code is not \"ours.\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fix flake8 errors in other code."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAPn%2F%2FYDw%3D","line":10,"updated":"2013-07-03 01:25:54.000000000","message":"message doesn\u0027t really match the code changes (for this not a big deal I guess).\n\nYou have fixed code in tools/* and doc/*, I don\u0027t get why they weren\u0027t getting checked before tho\u0027 - weird. The only thing you have changed in tox.ini is added \"build/\".\n\nAre you sure you have all your tox.ini changes here?","commit_id":"2f1378ebeaf6188963540a814d9ff418473796bc"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"8df3afce0dc989f3151797c1210287ee17b75f7e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix flake8 errors"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix exclude rules so we do not run flake8 against code in the build,"},{"line_number":10,"context_line":".tox, or openstack/common directories since this code is not \"ours.\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fix flake8 errors in other code."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAPn%2F%2FTBM%3D","line":10,"in_reply_to":"AAAAPn%2F%2FYDw%3D","updated":"2013-07-04 16:49:40.000000000","message":"I\u0027m not sure what was going on. I changed the specification for ignoring openstack/common because the existing one wasn\u0027t working for me. You\u0027re right that the mention of tox and tools is wrong -- I had originally added an --exclude option to the flake8 invocation, before finding the exclude setting at the bottom of the file.","commit_id":"2f1378ebeaf6188963540a814d9ff418473796bc"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"bca0ef06024533d02777be8ce10c8f2598a3a6d1","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Update the config checker script so if there are differences they"},{"line_number":15,"context_line":"are printed to the output. This should help track down false"},{"line_number":16,"context_line":"negatives in the tests."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I9938846943b7f8aab20f02266b870d560c6a2f80"},{"line_number":19,"context_line":"Signed-off-by: Doug Hellmann \u003cdoug.hellmann@dreamhost.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAPn%2F%2FYFQ%3D","line":16,"updated":"2013-07-03 01:25:54.000000000","message":"This was already \"show_source: True\"?","commit_id":"2f1378ebeaf6188963540a814d9ff418473796bc"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"8df3afce0dc989f3151797c1210287ee17b75f7e","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Update the config checker script so if there are differences they"},{"line_number":15,"context_line":"are printed to the output. This should help track down false"},{"line_number":16,"context_line":"negatives in the tests."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I9938846943b7f8aab20f02266b870d560c6a2f80"},{"line_number":19,"context_line":"Signed-off-by: Doug Hellmann \u003cdoug.hellmann@dreamhost.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAPn%2F%2FTBA%3D","line":16,"in_reply_to":"AAAAPn%2F%2FYFQ%3D","updated":"2013-07-04 16:49:40.000000000","message":"This is referring to the change in tools/conf/check_uptodate.sh. It was using cmp with the -s (silent) option. I\u0027ve changed it to just run diff so we get the output.","commit_id":"2f1378ebeaf6188963540a814d9ff418473796bc"}],"etc/ceilometer/ceilometer.conf.sample":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"631e6d536c6a874894f07729d14b77628ee73ef6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#auth_strategy\u003dkeystone"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Deploy the deprecated v1 API. (boolean value)"},{"line_number":28,"context_line":"#enable_v1_api\u003dtrue"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAPn%2F%2FZOM%3D","side":"PARENT","line":28,"updated":"2013-07-02 19:23:07.000000000","message":"I\u0027m confused as to why this config option is being removed for the sample file.","commit_id":"afba75f61ba97cfd8c5a90725d060c62e0f045ef"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"473f0eeb12687dace99c49ee8d5b4a61e33ba571","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#auth_strategy\u003dkeystone"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Deploy the deprecated v1 API. (boolean value)"},{"line_number":28,"context_line":"#enable_v1_api\u003dtrue"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAPn%2F%2FZNk%3D","side":"PARENT","line":28,"in_reply_to":"AAAAPn%2F%2FZOM%3D","updated":"2013-07-02 19:27:56.000000000","message":"Me, too. The pep8 test told me to run the tool to regenerate this file, so I did. I assumed the results were correct because it didn\u0027t produce any output. Obviously they are not. I must be missing some package needed for the script to work properly.","commit_id":"afba75f61ba97cfd8c5a90725d060c62e0f045ef"}],"nova_tests/test_notifier.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3d1b1ed13ebbae2103fd3454784796da5be1d1a4","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# For nova_CONF.compute_manager, used in the nova_notifier module."},{"line_number":48,"context_line":"config.cfg.CONF.import_opt(\u0027compute_manager\u0027, \u0027nova.service\u0027)"},{"line_number":49,"context_line":"#from nova import service"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# HACK(dhellmann): Import this before any other ceilometer code"},{"line_number":52,"context_line":"# because the notifier module messes with the import path to force"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FZNE%3D","line":49,"updated":"2013-07-02 19:30:40.000000000","message":"I guess you can entirely remove this line.","commit_id":"7afef1895c84d7d009f0d0b0dab289d76a9bf496"}]}