)]}'
{"ceilometer/image/glance.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c5c6288520b60055b9fbf2b4ecadc7dc92ea5b52","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _iter_images(self, ksclient, cache):"},{"line_number":73,"context_line":"        \"\"\"Iterate over all images.\"\"\""},{"line_number":74,"context_line":"        if \u0027images\u0027 not in cache:"},{"line_number":75,"context_line":"            cache[\u0027images\u0027] \u003d list(self._get_images(ksclient))"},{"line_number":76,"context_line":"        return iter(cache[\u0027images\u0027])"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FTOU%3D","line":74,"updated":"2013-07-04 15:09:53.000000000","message":"i\u0027m probably missing this somewhere but how does it know when the cache needs to be refreshed? (ie. new images?)","commit_id":"4437fb5f0b1820031d396a9ba39d50725d81d1eb"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4dc193cb4712ccf2c9cc963256d07d2d6945a847","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _iter_images(self, ksclient, cache):"},{"line_number":73,"context_line":"        \"\"\"Iterate over all images.\"\"\""},{"line_number":74,"context_line":"        if \u0027images\u0027 not in cache:"},{"line_number":75,"context_line":"            cache[\u0027images\u0027] \u003d list(self._get_images(ksclient))"},{"line_number":76,"context_line":"        return iter(cache[\u0027images\u0027])"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FS1w%3D","line":74,"in_reply_to":"AAAAPn%2F%2FTCY%3D","updated":"2013-07-04 18:21:25.000000000","message":"ah, previous patch. didn\u0027t connect the two.","commit_id":"4437fb5f0b1820031d396a9ba39d50725d81d1eb"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"0a7d1e53f48e35d3817335bfc8b7a3446e11924a","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _iter_images(self, ksclient, cache):"},{"line_number":73,"context_line":"        \"\"\"Iterate over all images.\"\"\""},{"line_number":74,"context_line":"        if \u0027images\u0027 not in cache:"},{"line_number":75,"context_line":"            cache[\u0027images\u0027] \u003d list(self._get_images(ksclient))"},{"line_number":76,"context_line":"        return iter(cache[\u0027images\u0027])"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FTNw%3D","line":74,"in_reply_to":"AAAAPn%2F%2FTOU%3D","updated":"2013-07-04 15:13:18.000000000","message":"Cache is empty at each run AFAIU.","commit_id":"4437fb5f0b1820031d396a9ba39d50725d81d1eb"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b53bea040413f119d01f412e1058f05ecb36a2ac","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _iter_images(self, ksclient, cache):"},{"line_number":73,"context_line":"        \"\"\"Iterate over all images.\"\"\""},{"line_number":74,"context_line":"        if \u0027images\u0027 not in cache:"},{"line_number":75,"context_line":"            cache[\u0027images\u0027] \u003d list(self._get_images(ksclient))"},{"line_number":76,"context_line":"        return iter(cache[\u0027images\u0027])"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FTCY%3D","line":74,"in_reply_to":"AAAAPn%2F%2FTOU%3D","updated":"2013-07-04 16:40:35.000000000","message":"Julien is right. A new cache dictionary is created at the start of each loop in the manager, so each time the pollsters are polled they have a fresh cache.","commit_id":"4437fb5f0b1820031d396a9ba39d50725d81d1eb"}]}