)]}'
{"ceilometer/volume/cinder.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"af0dabcfbf31d01e90118b442b7a2f77c681cf4d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            \u0027bootable\u0027: volume.bootable,"},{"line_number":38,"context_line":"            \u0027created_at\u0027: volume.created_at,"},{"line_number":39,"context_line":"            \u0027display_name\u0027: volume.name,"},{"line_number":40,"context_line":"            \u0027volume_id\u0027: volume.id,"},{"line_number":41,"context_line":"            \u0027encrypted\u0027: volume.encrypted,"},{"line_number":42,"context_line":"            \u0027host\u0027: getattr(volume, \u0027os-vol-host-attr:host\u0027),"},{"line_number":43,"context_line":"            \u0027project_id\u0027: getattr(volume, \u0027os-vol-tenant-attr:tenant_id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_c7fe9b37","line":40,"updated":"2016-09-06 19:21:59.000000000","message":"why duplicate this in metadata?","commit_id":"86dcbda62928d32e5fa37fc607779fb30e6eba34"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"af0dabcfbf31d01e90118b442b7a2f77c681cf4d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            \u0027volume_id\u0027: volume.id,"},{"line_number":41,"context_line":"            \u0027encrypted\u0027: volume.encrypted,"},{"line_number":42,"context_line":"            \u0027host\u0027: getattr(volume, \u0027os-vol-host-attr:host\u0027),"},{"line_number":43,"context_line":"            \u0027project_id\u0027: getattr(volume, \u0027os-vol-tenant-attr:tenant_id\u0027),"},{"line_number":44,"context_line":"            \u0027user_id\u0027: volume.user_id,"},{"line_number":45,"context_line":"            \u0027size\u0027: volume.size,"},{"line_number":46,"context_line":"            \u0027snapshot_id\u0027: volume.snapshot_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_a7dc37e5","line":43,"updated":"2016-09-06 19:21:59.000000000","message":"why duplicate this in metadata?","commit_id":"86dcbda62928d32e5fa37fc607779fb30e6eba34"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"af0dabcfbf31d01e90118b442b7a2f77c681cf4d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            \u0027encrypted\u0027: volume.encrypted,"},{"line_number":42,"context_line":"            \u0027host\u0027: getattr(volume, \u0027os-vol-host-attr:host\u0027),"},{"line_number":43,"context_line":"            \u0027project_id\u0027: getattr(volume, \u0027os-vol-tenant-attr:tenant_id\u0027),"},{"line_number":44,"context_line":"            \u0027user_id\u0027: volume.user_id,"},{"line_number":45,"context_line":"            \u0027size\u0027: volume.size,"},{"line_number":46,"context_line":"            \u0027snapshot_id\u0027: volume.snapshot_id,"},{"line_number":47,"context_line":"            \u0027source_volid\u0027: volume.source_volid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_07e2439f","line":44,"updated":"2016-09-06 19:21:59.000000000","message":"why duplicate this in metadata?","commit_id":"86dcbda62928d32e5fa37fc607779fb30e6eba34"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"af0dabcfbf31d01e90118b442b7a2f77c681cf4d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \u0027user_id\u0027: volume.user_id,"},{"line_number":45,"context_line":"            \u0027size\u0027: volume.size,"},{"line_number":46,"context_line":"            \u0027snapshot_id\u0027: volume.snapshot_id,"},{"line_number":47,"context_line":"            \u0027source_volid\u0027: volume.source_volid,"},{"line_number":48,"context_line":"            \u0027status\u0027: volume.status,"},{"line_number":49,"context_line":"            \u0027image\u0027: getattr(volume, \"volume_image_metadata\", {}),"},{"line_number":50,"context_line":"            \u0027image_ref\u0027: image_ref,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_8771f3e2","line":47,"updated":"2016-09-06 19:21:59.000000000","message":"what\u0027s volid?","commit_id":"86dcbda62928d32e5fa37fc607779fb30e6eba34"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"c6baa7f2be25def4cfa682c05daffd08840a4117","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \u0027user_id\u0027: volume.user_id,"},{"line_number":45,"context_line":"            \u0027size\u0027: volume.size,"},{"line_number":46,"context_line":"            \u0027snapshot_id\u0027: volume.snapshot_id,"},{"line_number":47,"context_line":"            \u0027source_volid\u0027: volume.source_volid,"},{"line_number":48,"context_line":"            \u0027status\u0027: volume.status,"},{"line_number":49,"context_line":"            \u0027image\u0027: getattr(volume, \"volume_image_metadata\", {}),"},{"line_number":50,"context_line":"            \u0027image_ref\u0027: image_ref,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_47e35433","line":47,"in_reply_to":"9a89bdaa_8771f3e2","updated":"2016-09-07 08:35:41.000000000","message":"An attribute in the result of \u0027cinder show\u0027.","commit_id":"86dcbda62928d32e5fa37fc607779fb30e6eba34"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"af0dabcfbf31d01e90118b442b7a2f77c681cf4d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \u0027snapshot_id\u0027: volume.snapshot_id,"},{"line_number":47,"context_line":"            \u0027source_volid\u0027: volume.source_volid,"},{"line_number":48,"context_line":"            \u0027status\u0027: volume.status,"},{"line_number":49,"context_line":"            \u0027image\u0027: getattr(volume, \"volume_image_metadata\", {}),"},{"line_number":50,"context_line":"            \u0027image_ref\u0027: image_ref,"},{"line_number":51,"context_line":"            \u0027volume_type\u0027: volume.volume_type,"},{"line_number":52,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_c773fbe5","line":49,"updated":"2016-09-06 19:21:59.000000000","message":"why is metadata key called \u0027image\u0027?","commit_id":"86dcbda62928d32e5fa37fc607779fb30e6eba34"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"af0dabcfbf31d01e90118b442b7a2f77c681cf4d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                name\u003d\u0027volume\u0027,"},{"line_number":60,"context_line":"                type\u003dsample.TYPE_GAUGE,"},{"line_number":61,"context_line":"                unit\u003d\u0027volume\u0027,"},{"line_number":62,"context_line":"                volume\u003d1,"},{"line_number":63,"context_line":"                user_id\u003dvolume.user_id,"},{"line_number":64,"context_line":"                project_id\u003dgetattr(volume, \u0027os-vol-tenant-attr:tenant_id\u0027),"},{"line_number":65,"context_line":"                resource_id\u003dvolume.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_a7d277fe","line":62,"updated":"2016-09-06 19:21:59.000000000","message":"what is this suppose to be measuring?","commit_id":"86dcbda62928d32e5fa37fc607779fb30e6eba34"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"c6baa7f2be25def4cfa682c05daffd08840a4117","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                name\u003d\u0027volume\u0027,"},{"line_number":60,"context_line":"                type\u003dsample.TYPE_GAUGE,"},{"line_number":61,"context_line":"                unit\u003d\u0027volume\u0027,"},{"line_number":62,"context_line":"                volume\u003d1,"},{"line_number":63,"context_line":"                user_id\u003dvolume.user_id,"},{"line_number":64,"context_line":"                project_id\u003dgetattr(volume, \u0027os-vol-tenant-attr:tenant_id\u0027),"},{"line_number":65,"context_line":"                resource_id\u003dvolume.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_870c7cee","line":62,"in_reply_to":"9a89bdaa_a7d277fe","updated":"2016-09-07 08:35:41.000000000","message":"yes, it same as image at ceilometer/image/glance.py.","commit_id":"86dcbda62928d32e5fa37fc607779fb30e6eba34"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"af0dabcfbf31d01e90118b442b7a2f77c681cf4d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        return {"},{"line_number":94,"context_line":"            \u0027created_at\u0027: snapshot.created_at,"},{"line_number":95,"context_line":"            \u0027name\u0027: snapshot.name,"},{"line_number":96,"context_line":"            \u0027id\u0027: snapshot.id,"},{"line_number":97,"context_line":"            \u0027project_id\u0027: getattr(snapshot,"},{"line_number":98,"context_line":"                                  \u0027os-extended-snapshot-attributes:project_id\u0027,"},{"line_number":99,"context_line":"                                  None),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_077403fb","line":96,"updated":"2016-09-06 19:21:59.000000000","message":"why list this again in metadata?","commit_id":"86dcbda62928d32e5fa37fc607779fb30e6eba34"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"af0dabcfbf31d01e90118b442b7a2f77c681cf4d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            \u0027created_at\u0027: snapshot.created_at,"},{"line_number":95,"context_line":"            \u0027name\u0027: snapshot.name,"},{"line_number":96,"context_line":"            \u0027id\u0027: snapshot.id,"},{"line_number":97,"context_line":"            \u0027project_id\u0027: getattr(snapshot,"},{"line_number":98,"context_line":"                                  \u0027os-extended-snapshot-attributes:project_id\u0027,"},{"line_number":99,"context_line":"                                  None),"},{"line_number":100,"context_line":"            \u0027size\u0027: snapshot.size,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_c7693b27","line":97,"updated":"2016-09-06 19:21:59.000000000","message":"same","commit_id":"86dcbda62928d32e5fa37fc607779fb30e6eba34"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"af0dabcfbf31d01e90118b442b7a2f77c681cf4d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            \u0027project_id\u0027: getattr(snapshot,"},{"line_number":98,"context_line":"                                  \u0027os-extended-snapshot-attributes:project_id\u0027,"},{"line_number":99,"context_line":"                                  None),"},{"line_number":100,"context_line":"            \u0027size\u0027: snapshot.size,"},{"line_number":101,"context_line":"            \u0027status\u0027: snapshot.status,"},{"line_number":102,"context_line":"            \u0027volume_id\u0027: snapshot.volume_id,"},{"line_number":103,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_47644b48","line":100,"updated":"2016-09-06 19:21:59.000000000","message":"same","commit_id":"86dcbda62928d32e5fa37fc607779fb30e6eba34"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"af0dabcfbf31d01e90118b442b7a2f77c681cf4d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                name\u003d\u0027snapshot\u0027,"},{"line_number":111,"context_line":"                type\u003dsample.TYPE_GAUGE,"},{"line_number":112,"context_line":"                unit\u003d\u0027snapshot\u0027,"},{"line_number":113,"context_line":"                volume\u003d1,"},{"line_number":114,"context_line":"                user_id\u003dNone,"},{"line_number":115,"context_line":"                project_id\u003dgetattr("},{"line_number":116,"context_line":"                    snapshot, \u0027os-extended-snapshot-attributes:project_id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_8702d36d","line":113,"updated":"2016-09-06 19:21:59.000000000","message":"same","commit_id":"86dcbda62928d32e5fa37fc607779fb30e6eba34"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"af0dabcfbf31d01e90118b442b7a2f77c681cf4d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                volume\u003d1,"},{"line_number":114,"context_line":"                user_id\u003dNone,"},{"line_number":115,"context_line":"                project_id\u003dgetattr("},{"line_number":116,"context_line":"                    snapshot, \u0027os-extended-snapshot-attributes:project_id\u0027),"},{"line_number":117,"context_line":"                resource_id\u003dsnapshot.id,"},{"line_number":118,"context_line":"                resource_metadata\u003dself.extract_snapshot_metadata(snapshot),"},{"line_number":119,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_074b23b1","line":116,"updated":"2016-09-06 19:21:59.000000000","message":"why do we not default here if we default in extract_snapshot_metadata?","commit_id":"86dcbda62928d32e5fa37fc607779fb30e6eba34"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5d825144735a12a98d54ebd3a67206d5ce31b32f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                name\u003d\u0027volume\u0027,"},{"line_number":62,"context_line":"                type\u003dsample.TYPE_GAUGE,"},{"line_number":63,"context_line":"                unit\u003d\u0027volume\u0027,"},{"line_number":64,"context_line":"                volume\u003d1,"},{"line_number":65,"context_line":"                user_id\u003dvolume.user_id,"},{"line_number":66,"context_line":"                project_id\u003dgetattr(volume, \u0027os-vol-tenant-attr:tenant_id\u0027),"},{"line_number":67,"context_line":"                resource_id\u003dvolume.id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_3a624cae","line":64,"updated":"2016-09-09 13:10:17.000000000","message":"my point was that we\u0027re trying to stop doing this. this isn\u0027t measuring anything. it is just generating load on API and unused entries in db. so we should have a very good reason for adding this.","commit_id":"dc8330086269dc73acf7e4d59a7222050827b53f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"07236407b483bb096fbe81c4a7d721f86bd05534","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \u0027restoring-backup\u0027: 8,"},{"line_number":37,"context_line":"    \u0027error_restoring\u0027: 9,"},{"line_number":38,"context_line":"    \u0027error_extending\u0027: 10,"},{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# volume snapshot status map for converting metric status to volume int"},{"line_number":42,"context_line":"VOLUME_SNAPSHOT_STATUS \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_f6933459","line":39,"updated":"2016-09-12 21:51:27.000000000","message":"to be honest, i\u0027m not a fan of this. i realise you are trying to capture state, but from a storage POV this makes very little sense. how would you use this?\n\ni think we need prioritize the ability to form events from polling in next cycle because this is what you are trying to achieve i believe. or maybe you can present a query that can utilise these mappings.","commit_id":"8b477b07fb2a62f10207c4f77c11ce6304152b99"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"ee914c3fc5c559fc7ed36f27ce4c39cd57ac2cc7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \u0027restoring-backup\u0027: 8,"},{"line_number":37,"context_line":"    \u0027error_restoring\u0027: 9,"},{"line_number":38,"context_line":"    \u0027error_extending\u0027: 10,"},{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# volume snapshot status map for converting metric status to volume int"},{"line_number":42,"context_line":"VOLUME_SNAPSHOT_STATUS \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_35d974f4","line":39,"in_reply_to":"9a89bdaa_f6933459","updated":"2016-09-29 07:23:22.000000000","message":"please have a look at my comment at the line 107.","commit_id":"8b477b07fb2a62f10207c4f77c11ce6304152b99"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"ee914c3fc5c559fc7ed36f27ce4c39cd57ac2cc7","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                name\u003d\u0027volume\u0027,"},{"line_number":105,"context_line":"                type\u003dsample.TYPE_GAUGE,"},{"line_number":106,"context_line":"                unit\u003d\u0027volume\u0027,"},{"line_number":107,"context_line":"                volume\u003dstatus,"},{"line_number":108,"context_line":"                user_id\u003dvolume.user_id,"},{"line_number":109,"context_line":"                project_id\u003dgetattr(volume, \u0027os-vol-tenant-attr:tenant_id\u0027),"},{"line_number":110,"context_line":"                resource_id\u003dvolume.id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_f588ece9","line":107,"range":{"start_line":107,"start_character":16,"end_line":107,"end_character":30},"updated":"2016-09-29 07:23:22.000000000","message":"@gordon chung\nSorry, I really don\u0027t known how to deal with it.\nI think \u0027volume\u003d1\u0027 is OK, but you have not agreed it at patch set 3, so what\u0027s way to the problem?  Thank you. :)","commit_id":"8b477b07fb2a62f10207c4f77c11ce6304152b99"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"ee914c3fc5c559fc7ed36f27ce4c39cd57ac2cc7","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                name\u003d\u0027snapshot\u0027,"},{"line_number":170,"context_line":"                type\u003dsample.TYPE_GAUGE,"},{"line_number":171,"context_line":"                unit\u003d\u0027snapshot\u0027,"},{"line_number":172,"context_line":"                volume\u003dstatus,"},{"line_number":173,"context_line":"                user_id\u003dNone,"},{"line_number":174,"context_line":"                project_id\u003dgetattr("},{"line_number":175,"context_line":"                    snapshot, \u0027os-extended-snapshot-attributes:project_id\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_b57e64e2","line":172,"range":{"start_line":172,"start_character":16,"end_line":172,"end_character":30},"updated":"2016-09-29 07:23:22.000000000","message":"ditto","commit_id":"8b477b07fb2a62f10207c4f77c11ce6304152b99"}]}