)]}'
{"ceilometer/cmd/storage.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"80dc32276a5db6a58cb479debbd16af8ece14dc5","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def db_clean_legacy():"},{"line_number":59,"context_line":"    confirm \u003d moves.input(\"Do you really want to drop the legacy alarm tables?\""},{"line_number":60,"context_line":"                          \"This will destroy data definitely if it exist. \""},{"line_number":61,"context_line":"                          \"Please type \u0027YES\u0027 to confirm: \")"},{"line_number":62,"context_line":"    if confirm !\u003d \u0027YES\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_584ada28","side":"PARENT","line":59,"updated":"2016-08-31 06:22:11.000000000","message":"This script is going to really DROP tables,  this safeguard looks important to me.\n\nIf this is removed for automation purpose, I would prefer to add a oslo.config cli opt to skip the check.","commit_id":"683069a1507aea0afb08581f136659f5922ca22e"},{"author":{"_account_id":22739,"name":"Zhuangqing Xiao","email":"zhuangqing.xiao@easystack.cn","username":"xiaozhuangqing"},"change_message_id":"d1796275a4663edbeac916f5c4d77134ae06329f","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def db_clean_legacy():"},{"line_number":59,"context_line":"    confirm \u003d moves.input(\"Do you really want to drop the legacy alarm tables?\""},{"line_number":60,"context_line":"                          \"This will destroy data definitely if it exist. \""},{"line_number":61,"context_line":"                          \"Please type \u0027YES\u0027 to confirm: \")"},{"line_number":62,"context_line":"    if confirm !\u003d \u0027YES\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_78915e52","side":"PARENT","line":59,"in_reply_to":"fa7ab95a_584ada28","updated":"2016-08-31 07:55:12.000000000","message":"Done","commit_id":"683069a1507aea0afb08581f136659f5922ca22e"},{"author":{"_account_id":22739,"name":"Zhuangqing Xiao","email":"zhuangqing.xiao@easystack.cn","username":"xiaozhuangqing"},"change_message_id":"2383259c397f42137e991958f5c358d37641db12","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def db_clean_legacy():"},{"line_number":59,"context_line":"    confirm \u003d moves.input(\"Do you really want to drop the legacy alarm tables?\""},{"line_number":60,"context_line":"                          \"This will destroy data definitely if it exist. \""},{"line_number":61,"context_line":"                          \"Please type \u0027YES\u0027 to confirm: \")"},{"line_number":62,"context_line":"    if confirm !\u003d \u0027YES\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_d7c910ae","side":"PARENT","line":59,"in_reply_to":"fa7ab95a_584ada28","updated":"2016-09-01 04:19:56.000000000","message":"you mean add a oslo.config cli opt to skip the check??","commit_id":"683069a1507aea0afb08581f136659f5922ca22e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"06162e709fc9f27567f0513b33f765c62075213a","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def db_clean_legacy():"},{"line_number":59,"context_line":"    confirm \u003d moves.input(\"Do you really want to drop the legacy alarm tables?\""},{"line_number":60,"context_line":"                          \"This will destroy data definitely if it exist. \""},{"line_number":61,"context_line":"                          \"Please type \u0027YES\u0027 to confirm: \")"},{"line_number":62,"context_line":"    if confirm !\u003d \u0027YES\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_75f655fa","side":"PARENT","line":59,"in_reply_to":"fa7ab95a_d7c910ae","updated":"2016-09-01 15:48:33.000000000","message":"Yes","commit_id":"683069a1507aea0afb08581f136659f5922ca22e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f54d12dcad7e3152bec67f75a92ce2f9664830b2","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        cfg.strOpt(\u0027drop_alarm_table\u0027,"},{"line_number":94,"context_line":"                   short\u003d\u0027n\u0027,"},{"line_number":95,"context_line":"                   help\u003d\u0027confirm to drop the legacy alarm tables\u0027,"},{"line_number":96,"context_line":"                   required\u003dTrue)])"},{"line_number":97,"context_line":"    service.prepare_service()"},{"line_number":98,"context_line":"    for purpose in [\u0027metering\u0027, \u0027event\u0027]:"},{"line_number":99,"context_line":"        url \u003d (getattr(cfg.CONF.database, \u0027%s_connection\u0027 % purpose) or"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_5aaf227d","line":96,"updated":"2016-09-09 08:20:34.000000000","message":"The goal is to not break previous behavior. So we need the old code and your new code.\n\nThe old code need to be wrapper just after your new code by:\n\n    if not cfg.CONF.confirm_drop_alarm_table:\n\nAlso the opt should be named something like \u0027confirm-drop-alarm-table\u0027, oslo_config will automatically convert - to _ for the code need.\n\nrequired\u003dTrue is not wanted here, because perhaps already use this script in automation tools and we don\u0027t wnat to break them.","commit_id":"acf4ee714b67f37aa10fdfae8a0c7dee4ad7e3d5"},{"author":{"_account_id":22739,"name":"Zhuangqing Xiao","email":"zhuangqing.xiao@easystack.cn","username":"xiaozhuangqing"},"change_message_id":"742dbe0d759fda89f00cd788b35f5cdd2de02463","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        cfg.strOpt(\u0027drop_alarm_table\u0027,"},{"line_number":94,"context_line":"                   short\u003d\u0027n\u0027,"},{"line_number":95,"context_line":"                   help\u003d\u0027confirm to drop the legacy alarm tables\u0027,"},{"line_number":96,"context_line":"                   required\u003dTrue)])"},{"line_number":97,"context_line":"    service.prepare_service()"},{"line_number":98,"context_line":"    for purpose in [\u0027metering\u0027, \u0027event\u0027]:"},{"line_number":99,"context_line":"        url \u003d (getattr(cfg.CONF.database, \u0027%s_connection\u0027 % purpose) or"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_dae412ae","line":96,"in_reply_to":"9a89bdaa_5aaf227d","updated":"2016-09-09 08:29:55.000000000","message":"Done","commit_id":"acf4ee714b67f37aa10fdfae8a0c7dee4ad7e3d5"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"227712202c775e8d5c3aecbbfc10c6995833d69e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        cfg.strOpt(\u0027drop_alarm_table\u0027,"},{"line_number":94,"context_line":"                   short\u003d\u0027n\u0027,"},{"line_number":95,"context_line":"                   help\u003d\u0027confirm to drop the legacy alarm tables\u0027,"},{"line_number":96,"context_line":"                   required\u003dTrue)])"},{"line_number":97,"context_line":"    service.prepare_service()"},{"line_number":98,"context_line":"    for purpose in [\u0027metering\u0027, \u0027event\u0027]:"},{"line_number":99,"context_line":"        url \u003d (getattr(cfg.CONF.database, \u0027%s_connection\u0027 % purpose) or"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_01ad2a88","line":96,"in_reply_to":"9a89bdaa_dae412ae","updated":"2016-09-09 11:06:16.000000000","message":"\"Done\" is for when a new patchset have been send with the comment fixed... I don\u0027t see a new patchset 2 hours after the comment...","commit_id":"acf4ee714b67f37aa10fdfae8a0c7dee4ad7e3d5"}]}