)]}'
{"ceilometer/messaging.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"7cd1ce33825d4963905ca116d52a58261807fa1f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    \"\"\"Return a configured oslo_messaging notification listener.\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    # Just fetch the number of messages needed to fill our working threads"},{"line_number":67,"context_line":"    # instead of an unlimit amought of messages."},{"line_number":68,"context_line":"    qos \u003d (batch_size * transport.conf.executor_thread_pool_size)"},{"line_number":69,"context_line":"    transport.conf.set_default(\u0027rabbit_qos_prefetch_count\u0027, qos,"},{"line_number":70,"context_line":"                               group\u003d\"oslo_messaging_rabbit\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_e6cf2f7d","line":67,"range":{"start_line":67,"start_character":28,"end_line":67,"end_character":35},"updated":"2016-09-06 15:12:04.000000000","message":"amount","commit_id":"e8ebef8416895c54a07585ecdbdbb179a80eec9d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"7cd1ce33825d4963905ca116d52a58261807fa1f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    \"\"\"Return a configured oslo_messaging notification listener.\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    # Just fetch the number of messages needed to fill our working threads"},{"line_number":67,"context_line":"    # instead of an unlimit amought of messages."},{"line_number":68,"context_line":"    qos \u003d (batch_size * transport.conf.executor_thread_pool_size)"},{"line_number":69,"context_line":"    transport.conf.set_default(\u0027rabbit_qos_prefetch_count\u0027, qos,"},{"line_number":70,"context_line":"                               group\u003d\"oslo_messaging_rabbit\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_06cb3373","line":67,"range":{"start_line":67,"start_character":20,"end_line":67,"end_character":27},"updated":"2016-09-06 15:12:04.000000000","message":"unlimited","commit_id":"e8ebef8416895c54a07585ecdbdbb179a80eec9d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"87d8c63647e4643d578ef41c7a4829f43d5c2e18","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        batch_size\u003dbatch_size, batch_timeout\u003dbatch_timeout)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # Just fetch the number of messages needed to fill our working threads"},{"line_number":72,"context_line":"    # instead of an unlimit amought of messages."},{"line_number":73,"context_line":"    qos \u003d (batch_size * listener.conf.executor_thread_pool_size)"},{"line_number":74,"context_line":"    listener.conf.set_default(\u0027rabbit_qos_prefetch_count\u0027, qos,"},{"line_number":75,"context_line":"                              group\u003d\"oslo_messaging_rabbit\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_0e4b45ca","line":72,"updated":"2016-09-06 16:29:58.000000000","message":"same feedback\n\ns/unlimit/unlimited/\n\ns/amought/amount/","commit_id":"08a4f05db54dda78a9d50357154fdf3c68e66785"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"87d8c63647e4643d578ef41c7a4829f43d5c2e18","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    # Just fetch the number of messages needed to fill our working threads"},{"line_number":72,"context_line":"    # instead of an unlimit amought of messages."},{"line_number":73,"context_line":"    qos \u003d (batch_size * listener.conf.executor_thread_pool_size)"},{"line_number":74,"context_line":"    listener.conf.set_default(\u0027rabbit_qos_prefetch_count\u0027, qos,"},{"line_number":75,"context_line":"                              group\u003d\"oslo_messaging_rabbit\")"},{"line_number":76,"context_line":"    return listener"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_2eef29b1","line":74,"updated":"2016-09-06 16:29:58.000000000","message":"what\u0027s this other prefetch for?\n\nhttps://github.com/openstack/oslo.messaging/blob/bafe720867c0ebcc11634340eaeb5565d86efc1d/oslo_messaging/_drivers/base.py#L147\n\nis it a more generic value?","commit_id":"08a4f05db54dda78a9d50357154fdf3c68e66785"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f5abbb2fb6297ea72ea282df4de9f5fe7629dee9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    # Just fetch the number of messages needed to fill our working threads"},{"line_number":72,"context_line":"    # instead of an unlimit amought of messages."},{"line_number":73,"context_line":"    qos \u003d (batch_size * listener.conf.executor_thread_pool_size)"},{"line_number":74,"context_line":"    listener.conf.set_default(\u0027rabbit_qos_prefetch_count\u0027, qos,"},{"line_number":75,"context_line":"                              group\u003d\"oslo_messaging_rabbit\")"},{"line_number":76,"context_line":"    return listener"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_01dbfcec","line":74,"in_reply_to":"9a89bdaa_2eef29b1","updated":"2016-09-07 07:29:58.000000000","message":"I have the feeling that the prefetch stuff in oslo.messaging is messy. I will dig deeper later, but all drivers have a different option to configure prefetch and not all support prefetch. The prefetch_size is the rabbit_qos_prefetch_count for the rabbit driver. But I just see that setting the default will not work because oslo.messaging driver register oslo.config option and directly copy the config value in another variable, making impossible to change the default...","commit_id":"08a4f05db54dda78a9d50357154fdf3c68e66785"}]}